From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2578EC369A2 for ; Fri, 11 Apr 2025 21:42:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 780D6680027; Fri, 11 Apr 2025 17:42:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7104A680024; Fri, 11 Apr 2025 17:42:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5CF61680027; Fri, 11 Apr 2025 17:42:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 4079E680024 for ; Fri, 11 Apr 2025 17:42:19 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 9BEB8AD430 for ; Fri, 11 Apr 2025 21:42:19 +0000 (UTC) X-FDA: 83323086798.03.81EF7CD Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf28.hostedemail.com (Postfix) with ESMTP id 4A726C000C for ; Fri, 11 Apr 2025 21:42:17 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=MFhTO1B+; spf=pass (imf28.hostedemail.com: domain of llong@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=llong@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744407737; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3gi9jx3ynN0Fvs6xU8s9qk3uwTlKkqCTwIN8L/fT3WM=; b=LqmmsypVmIM1NpTMYJLabizkiNfuCBJsuNxux0srUsk/fuEFI1MJOhhGi83q15Dii4yLRG unN7hRmzr9oil16+DXpr6sVP1b8NrhMrCSB8smXUkjCycqphLrEtAVm4Tl5IQLY3Jq/tyc oGROxEIbOSRAHPj5A3jWgZXMjCLteyM= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=MFhTO1B+; spf=pass (imf28.hostedemail.com: domain of llong@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=llong@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744407737; a=rsa-sha256; cv=none; b=ACSBiGERaslnctqquhz7pMvCUj+FG/Weq06wEFEXHCCeOZ6L3RWnQ5er1/wNaEs16z2yzw a8Yy6qFMzRD4NZMxDd+ckts70vie2cJk03PmlqzWCzoiWXKi3tLyasMnlxsXIOhSPRchE7 LpkE9ueEJcuFL1bGZZUz1vO1oBSYma0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1744407736; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3gi9jx3ynN0Fvs6xU8s9qk3uwTlKkqCTwIN8L/fT3WM=; b=MFhTO1B+xOcqLf/+nAGrCF+yfV3rabt1iQyzeoVsQouikY0lXE8aZvewYnp3aTZkdQcQf7 yMM4TroHQiONTAvQa5hAhmlGBKiShlvVhvx1kYYs64ePTPzm8jlfuxabNiQWgR28J3R1/G iCmcDtTS3gjMNfgT2/qD9cTdfbQtJIU= Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-510-ZT7EdHhhOrakAEDGGOEFow-1; Fri, 11 Apr 2025 17:42:15 -0400 X-MC-Unique: ZT7EdHhhOrakAEDGGOEFow-1 X-Mimecast-MFC-AGG-ID: ZT7EdHhhOrakAEDGGOEFow_1744407734 Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-7c5f3b94827so439713885a.0 for ; Fri, 11 Apr 2025 14:42:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744407734; x=1745012534; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:user-agent:mime-version:date:message-id:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=3gi9jx3ynN0Fvs6xU8s9qk3uwTlKkqCTwIN8L/fT3WM=; b=Njow0OSNPtbzIumGoUFSDZ+hEyD6LGP0+r4234svTiWTiv6KtOjSLXVbH0O2tuB2p/ sG5jboqNTdcA1ZoOtBfe6H8iQACy6gm4nNMUMzLmZHLvlJILhXcYf9gEq2Rw+fBd2j/X xH3+gN9vPd78jqSgT+/DWjsah+iAoTYNhQ09E0pPlkdqhDiZ0gJMiU0La2lvUKr0jnaq CLiA0COszjJdRJcyNEK9kTTAC7tX9O1ZqTBAfyF/MWb0fK+Uqf5vYtelI4dCKM6gYUME uG9MmQUNxVZ3WyH5/YVcuPr7RljvCB3sCDI2zLXM23D5sasrvupO5MBnXZ1vOoXRVFjy rzgQ== X-Forwarded-Encrypted: i=1; AJvYcCUEBaR3l5tjXsA3CYgkzzyTgq5IojPxFz0xENi3ZaOv5OU4Ybxk0NkK+tXnAUS/OeiUXGNkThHFjg==@kvack.org X-Gm-Message-State: AOJu0YyQ4+exJo81l2XnH+f6cL0RKZa7LgN986jsw7VPDTyT0K8UYwYO WveP/k17n62oUuADHBBGajv6CwhX3NkXhrcNGANZGwPowcV9rphG++d7LztvOGJNZeDBqpAGzv9 PlnacY2IS2vpi9TBFSVACRpRr1J2reSyq8qdrHMjZYG5kQ+jT X-Gm-Gg: ASbGncuIZaVfn22mMNJen0irbFbRFHVqHfAAg0xWjnZcIm72t/lxph4z5cDpau4prWp vWZDh7byUVug/Q8YySZ2HMT+CKdOOQn4n/QI105Q8p4Fe/qYjKyOPJ2dWEn3PayM0iDtC1w73dk 5Qf3vD1vZ97M0SihXFzaRItv3LQvvA7bVD46nxQavgcRee2xg0TCwkYXoFX50pdZkjQwmkXDgl1 U/S7W+67jzozlsMMnSDL9syak8dpucVXUvV/fQS/xEX0X0C2ibMX9pyK3i5Qlfycj+OxlGKjtM5 u8qijCUY5FAQoDn6+DG8iK0RWHrkB44lsUDq4g7qFp6CHeHlv23pjfy9mg== X-Received: by 2002:a05:620a:4608:b0:7c7:70dc:e921 with SMTP id af79cd13be357-7c7af12df3emr861620585a.36.1744407734614; Fri, 11 Apr 2025 14:42:14 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGrW3e7AIHhIu7AXBF5LC5KsZhgZcA6ahLpM5fFHEpeXmV2PCGX62skPo0rxtAIqHbrxnoQTQ== X-Received: by 2002:a05:620a:4608:b0:7c7:70dc:e921 with SMTP id af79cd13be357-7c7af12df3emr861618085a.36.1744407734327; Fri, 11 Apr 2025 14:42:14 -0700 (PDT) Received: from ?IPV6:2601:188:c100:5710:315f:57b3:b997:5fca? ([2601:188:c100:5710:315f:57b3:b997:5fca]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7c7a895163asm317581185a.27.2025.04.11.14.42.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 11 Apr 2025 14:42:13 -0700 (PDT) From: Waiman Long X-Google-Original-From: Waiman Long Message-ID: <22368dc1-e026-4e9d-bb65-6df62f960a15@redhat.com> Date: Fri, 11 Apr 2025 17:42:12 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 2/2] selftests: memcg: Increase error tolerance of child memory.current check in test_memcg_protection() To: =?UTF-8?Q?Michal_Koutn=C3=BD?= Cc: Johannes Weiner , Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song , Andrew Morton , Tejun Heo , Shuah Khan , linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org References: <20250407162316.1434714-1-longman@redhat.com> <20250407162316.1434714-3-longman@redhat.com> In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: KRCkcUaZvcbkKM9n9mKj_PpDvoAdDGN07gdL-L_YRFs_1744407734 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 4A726C000C X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: 13e4ajjhy6yj3i1ipo3bpqweq77o96ib X-HE-Tag: 1744407737-851659 X-HE-Meta: U2FsdGVkX1/GschloLAcHGHA4Vah4rxYpggUySF6sjKpebGB7+s5pi4FfNmv6yLSdP/rbIu2Lk6RWQCx7lebTZrDfBfjBE6x74yJon02u38lzVKV5hwVajOP50R8AiFD5ekKrVY2ORCGNnN99oJHMrBHmZi0oDKy4fXQW3VbNcqZk47IfywYp312TE555eiTN31IlOK83L3Bi7gjlUMMrb6ItoXdVLyfNHSmKpASnj4REWx6fo+rO6u5tk0d9R/nBhM8ONeibZMc2jULEKoDjNmaSatesndEmOo2mCZqeh6vD2jmCUaXRU0Gx7hrSUioc1wtU2xXi3Unqy5dEhEMMf5aLqSkoNbT7nom5ZwQft8BoyjsjuKgxJOneWrBQmdMSL8km+Y7xFqvYYiYpPtHkkxR4jinfxSTbWI1eYs8QvSXrVObx1THCaI4rVBBh2Td9F+S86pP/1HqW50suzCQgdAdShDPb7WS2uPhw7gUJWgXC7S3Epruw9lU9h65JnmRrOVLvBUn4hckHEjsy040cV0ksJsYFovnK6Ax5yxzZzTSp0pbtTjCW3dty5Wqq9+i8Kp8VE7wKuUMdbZnaYGM7n8K+G3+yhL2XklndEDAacLBZEGQyeRzc32Vzer59hb6J+dXfLHO2LFimRuqQnYzukVPQNF1jRY/WU1PVhZ2S96YGQQfcSxE7jsdGKiosJwu08UvJ/MYcsmEIqSj9OoI+f2a2457V8Z5jb4i5Ohvq3aqTnF3/sVUOMENYyEv2o458CqVzpklWTyP3jmO3ldnSn1jity5x/CUxYLS3EAbv57mLOI+I8mDP6mqSjM9s/nNlBp320HcV+V/l0fLo4NcZssvGXXA8c8HkeugLxymCX/+fC89t5enOtw7JcX0GCDbquNtDl7a0v1etqkjUT3DVC7SVOjpvM+Ko48cVusUuAoltWQpnGp82rS8TmAwf5hBYJt360A3vZxhtGCWaxg bh/c5skX cuz+m5dQ2ESwe2FCMDeBLHGz1PPYEdVdURJJDj0ul351rmQZsrKOaPqJJV1+gmRY+pvYV17g1Rr7dfRdIVVSWq5X5nAVMS//2XZAkI+6pk4u6Gw0cbO24cn6bp3LPs5rzfHt7e5cRhy9JDcFA6oM8a5nSGSAlHCKQhdrHbMKrMHSAb1KpV0HKCZwgkWLATN80XqXggTeq2FLi7bkxDDrfhnauYK1oe54xgrrfhKa0aLQg1/aVeTLpP0aOH37ZTBrK0NLuissHCauZveXGrqD/XIg4720LqkBq97YcQ5SxNHt6K2EpjmQPSmpjIpEkH4arAPfUJzb8L76maKmLRumWNTHKC/dh4nxY080Dng31LlcIf+6VP88fIPkW7uKx1uW+YgeXvw9TyBLYOk7BSfuRgV/Y1R21J5CoREK/tWtQyqeXJWjv0QDoeFt+2uEoT/PArgWCA8I8+nwcK6/RslqBv2N4N7tr5jvsFD5t3xoPxz26eR4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 4/11/25 1:22 PM, Michal Koutný wrote: > On Mon, Apr 07, 2025 at 12:23:16PM -0400, Waiman Long wrote: >> Child Actual usage Expected usage %err >> ----- ------------ -------------- ---- >> 1 16990208 22020096 -12.9% >> 1 17252352 22020096 -12.1% >> 0 37699584 30408704 +10.7% >> 1 14368768 22020096 -21.0% >> 1 16871424 22020096 -13.2% >> >> The current 10% error tolerenace might be right at the time >> test_memcontrol.c was first introduced in v4.18 kernel, but memory >> reclaim have certainly evolved quite a bit since then which may result >> in a bit more run-to-run variation than previously expected. > I like Roman's suggestion of nr_cpus dependence but I assume your > variations were still on the same system, weren't they? > Is it fair to say that reclaim is chaotic [1]? I wonder what may cause > variations between separate runs of the test. Yes, the variation I saw was on the same system with multiple runs. The memory.current values are read by the time the parent cgroup memory usage reaches near the target 50M, but how much memory are remaining in each child varies from run-to-run. You can say that it is somewhat chaotic. > > Would it help to `echo 3 >drop_caches` before each run to have more > stable initial conditions? (Not sure if it's OK in selftests.) I don't know, we may have to try it out. However, I doubt it will have an effect. > > Or sleep 0.5s to settle rstat flushing? No, page_counter's > don't suffer that but stock MEMCG_CHARGE_BATCH in percpu stocks. > So maybe drain the stock so that counters are precise after the test? > (Either by executing a dummy memcg on each CPU or via some debugging > API.) The test itself is already sleeping up to 5 times in 1s interval to wait until the parent memory usage is settled down. Cheers, Longman