From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CED96C6FD35 for ; Thu, 29 Aug 2024 07:56:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 52CE36B0089; Thu, 29 Aug 2024 03:56:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4DC9E6B00B8; Thu, 29 Aug 2024 03:56:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3A40C6B008C; Thu, 29 Aug 2024 03:56:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 1ADBB6B00B8 for ; Thu, 29 Aug 2024 03:56:03 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id C60001C0580 for ; Thu, 29 Aug 2024 07:56:02 +0000 (UTC) X-FDA: 82504524564.16.6217184 Received: from mout.web.de (mout.web.de [212.227.17.12]) by imf12.hostedemail.com (Postfix) with ESMTP id ABD574000A for ; Thu, 29 Aug 2024 07:56:00 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=web.de header.s=s29768273 header.b=AcBvC2sW; dmarc=pass (policy=quarantine) header.from=web.de; spf=pass (imf12.hostedemail.com: domain of Markus.Elfring@web.de designates 212.227.17.12 as permitted sender) smtp.mailfrom=Markus.Elfring@web.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724918095; a=rsa-sha256; cv=none; b=2iCZtSefyMOsEoRC4ri0PetrnfNZ1h7kpzqxVdVtEqQV14Swf+4KKRW2Tii8KEvYSrw1AD 4PrnawkJB9HnFtYxiRAj0qOTmX3KFDJTO9rgjh8uJQdOoOXIUWLfDdeFwrFU7keAn5/opt bGfkj85iR+O+zMUZPWNyN1eY8Wm1y6c= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=web.de header.s=s29768273 header.b=AcBvC2sW; dmarc=pass (policy=quarantine) header.from=web.de; spf=pass (imf12.hostedemail.com: domain of Markus.Elfring@web.de designates 212.227.17.12 as permitted sender) smtp.mailfrom=Markus.Elfring@web.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724918095; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9xpPAV//CdEZt3ddIwqbRUwBwI+AzwP3oDC51Ky0oQg=; b=zH2IyLEtog7VH07yDGxyMfsKYAUK0ZEZ9Drj0+B/MwaUlj4rPMKBhQ/RXf9IYyrHkS324w c4io1SbcGzn3UbGhumNC1hbB6uxBVmvcg8rzZ6v4mdiom3/YqzGEQ7tRMkUDkFlLbMGFwI g6G0ux0DhM1jxl9N+OCj7pJV0ALLrK0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=web.de; s=s29768273; t=1724918153; x=1725522953; i=markus.elfring@web.de; bh=9xpPAV//CdEZt3ddIwqbRUwBwI+AzwP3oDC51Ky0oQg=; h=X-UI-Sender-Class:Message-ID:Date:MIME-Version:Subject:To:Cc: References:From:In-Reply-To:Content-Type: Content-Transfer-Encoding:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=AcBvC2sWO88Lymuu8EKRtp++ox/Kwt1xMnkv4g1BPKdYrZelPP6xodp03sZV3J8c UbNKYaR47ZiE9+SyG6kxjB6+kNeroiZpI/HZ80Uxl/k9Vu73ujSdh7z8ee5G2s5pO GpZSmQ1zPqBNaERefCCeVn8cJdBCbHECETljeItaHPjrVi/dcH9BTEidaBjdvWKon Xh/jl/lLgbWWiV6PIqEx5XmpvFAWXiywQKsTKRNRmj2XvitnH+vOd2f3yAZcJhUUE yL/ve348Pk9D4llz2CdhFGoSGp+i5Hhpr8vXf1Q512R3vnESo17XO+keW0D7ooGf0 RtNjO8IXXba387GxOw== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from [192.168.178.21] ([94.31.84.95]) by smtp.web.de (mrweb105 [213.165.67.124]) with ESMTPSA (Nemesis) id 1MKuON-1sVcSS088z-00MbMP; Thu, 29 Aug 2024 09:55:53 +0200 Message-ID: <22213ddd-90b3-4d33-aa80-4b3500a21a2e@web.de> Date: Thu, 29 Aug 2024 09:55:49 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: tools/mm: Use calloc and check the potential memory allocation failure To: Dev Jain , Zhu Jun , linux-mm@kvack.org, kernel-janitors@vger.kernel.org, Andrew Morton Cc: LKML References: <20240829055621.3890-1-zhujun2@cmss.chinamobile.com> <716f7466-562d-4bbe-a8ec-851a0b289db5@web.de> <37577635-89c9-4afe-a30d-add02c0eb896@arm.com> Content-Language: en-GB From: Markus Elfring In-Reply-To: <37577635-89c9-4afe-a30d-add02c0eb896@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:NfFVen4h15z9+e5jTgazkR7xfYakyPD/MaT4846uLXYRjS0xRek mAwqEzhUL2u/f4CzwQuB1AMxFrIzoPdiwUuZdrRqf0b/TgrNKdRNHp0J+DVBFhengwMhtt2 e+FP8iuAFOCwBeDDtUiDFT10ZsIyCuxjN8rCDIBgWdw+NRxN33jm4VdZNqT/SoW/m2TFmmh cxszndiHq/XYEZENS2L1Q== UI-OutboundReport: notjunk:1;M01:P0:f8YdmMQ47M8=;rnL2sXkMbq0C89SYZmNo8H0ukUG 7u/6IhOzXQErvznNaLFz5NKs4iixAkmR+r8w+CID2gJXICepxW6nt8eyImBr6C6p3aNHFlDAH iTUat3X9KR0bpqFxA6OtV9PJx9E6OKprRDSGVsnh7RVFBy1G3xLEF+bPOIUnmciTrjbCb0v22 0jw7OMchNIFufhkPBFb6ubMuZ6/YN2giHYYIZuje6ERfQdFxBFjHFY3QnUPJ+9iNucB8MPIr0 p31SfplFCaDZ5r+BBkG+CGtWCkpEY93N5Y3Gu/LaXGXDgxsc7e4tN56TW4Wu8sEWWvvmBFutI EKcFHFkPeTjGep1iJLkAEYa3/4DihvnclYWdcG2EPn8l9JfhQQMSJJREsgyYw1KSU0bvq/S4X YBK91Ep1D8DdSmtsxg13idb6Gv7AIni8zquOHRuQRW1fsMCkAjiAmYgM9kz0kse0XYXF9nrOS FXA/9djM/qOVsNw7OLMEdpuXa+NoOdDYFkc5DAxbL65mzI+s41P3OTLmP8aDEldP3RV5zP3CZ FXqW8nee5NhuXcvB/24CNdBI0pYoB8UkDp9QRSRiNw7rt0nmdl6UzcjuteuCZROG4bnulE6Us cBwpHEVrgRii5xwK0AluNn5CFJ2Qy12K86OADn59SNv4+Ggs32ybGKfNs0YLDXBE2ArsYPvNR CLNKUlCTHGv8EbhT4+hgEk6GMgWixI/uMiZL5ZjiIaExHcTD6qqS2Q0o1n4obC5KBMUOtVhke LkSx7PXGzXmfpjGL/XEPPuzXQ9D9MOG8VIh+LKCiHIUfuEDzoNHNXG3MBH+IP6ksJwXYs7aon 9K8tecc8Zp/0B/IF8QzQpQNw== X-Rspamd-Queue-Id: ABD574000A X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: unry9oiote6gmq7qap9tyu3zfy9uzwto X-HE-Tag: 1724918160-218760 X-HE-Meta: U2FsdGVkX19V9Yn5IQ/mSoNTsnFY4tQp/PcUR+MyYJPn5rbAxJ8TdshTTwk4XVWneHcDnhiBUiYf+KoLuqjDU+Wz3CoVP2nmRYEIMdbpq+kGyv1eKZ6gYlAXIJRamt5M5ppuPxb3LZZCNN2HlK/eEim444vqsMheceiWUpwRRcNi4kOMn1vKspjOISupDGSgOZmGdZVuom9jzRMriwn4xv2SzlLDDCcRaeLtMvfg/V4kI/wk8FBdAUDOL/ZdzM2AnEJitTMB9uZ6AHbbVf7xi2ccZYj9D87J1eBtuxrowN6LKURJ+toq5eKKaCeh27VGm6YG4Yp06ODMSCUlX3raPpfCTHTQBqbJVr+m/i2+LBckd3auhP5qXkm3mH0ow29U30p2O36qxoG6giERfCAue7Ehbr3WvPqnwdVxv0qE6Q9paL6j02nTfVM6F6hwfSy1RBTWyHim3dF8lL/rL83l8uHob9gQk7R/EMEuaeeneGryQ1BBJUQ9xFdDEIqe2qDLh2VWalJLro+3nRoernXuE27fBxasEaAOjBsluS4j9Dac8yd2cMplvDUQQbsrnSeBbIixmMzbptNWuJOXIQezpJvHVBhrJfPRIcpageOlSRzKk3v99k6SN7UhtLO50yPdyHgv0FPILrbBfwFAdVQELR8JMcMjVyrA0wtwaIxlYZbONwmQxB0sXsnyPI2i82cEnUtp8N7JbTVOL72dL+Ukrkv22tZSWdcnBGLiWj4ZtOYgR5gOMpazbTXyFk0nH1Cb431XubCeGp/sHkabhbCY8tyIqw82GmU6H7gCV/0kHC76FKAuH7EefjvZXQvJHSXpd8fByKxWe+U5GPUL+0UD7zQLUWWhITpYlEXRCpFoVdkRAN6wMuamLQRRxOLEjdUNKxZQFUFEJhMByuPdEagixJULF7L4b/wLLZbg/Be3yOxv3wZzHvsWwEvghybZ+zny4fWoGHTuHTYC2YbUG1T mlPBUAbF ecSKNjr0Ke/Glt5NsuuD0wV/IAa6F4FaBhYotCXosuJzGRK7NzvZU12A0EUxGqdAojZnjwn2vbnOR3CtafNoV0Go2SkcKqIUD7OeYBH3QvZYCOlPY6iu29En+ro8a4iTxfhrKfAIeACiO51wdEwfMWXPtEcbQAeilD+s7gxJSMaml5Ikm4uBz3EvOm23TgBn6Q+NIH/j2oEs7/TYWqhYw42UMIsRAY973cn8pZ9mhIhKCInd2IsQj2nxx0AWp6M4rdtGPcoSyCeNjH80mXd/O6C01Nh5w+NAFMokSSCiQuuuhAKylHXXMtQhXToG5SH5OgFoI X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: >>> Replace malloc with calloc and add memory allocating check >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 memset(=E2= =80=A6, 0, =E2=80=A6) call by calloc()? > > Calloc returns zeroed-out memory. I propose to improve the change description considerably. >>> of comm_str before used. >> * Add also a null pointer check for the detection of a memory allocatio= n failure. > > Which is exactly what Zhu has done? Can the commit message become nicer anyhow? =E2=80=A6 >> * How do you think about to omit the statement =E2=80=9Cfprintf(stderr,= "Out of memory\n");=E2=80=9D? > > Why? I imagine that a returned null pointer can eventually be sufficient alread= y. Would you get helpful background information from the variable =E2=80=9Cer= rno=E2=80=9D? Regards, Markus