From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F4DBC433FE for ; Thu, 6 Oct 2022 01:28:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1EF1F6B0071; Wed, 5 Oct 2022 21:28:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 19E456B0073; Wed, 5 Oct 2022 21:28:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 066528E0001; Wed, 5 Oct 2022 21:28:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id E683E6B0071 for ; Wed, 5 Oct 2022 21:28:31 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id B79388053D for ; Thu, 6 Oct 2022 01:28:31 +0000 (UTC) X-FDA: 79988789622.16.ED0D4FA Received: from mail-ej1-f53.google.com (mail-ej1-f53.google.com [209.85.218.53]) by imf19.hostedemail.com (Postfix) with ESMTP id 4BAF51A001A for ; Thu, 6 Oct 2022 01:28:31 +0000 (UTC) Received: by mail-ej1-f53.google.com with SMTP id qn17so1470422ejb.0 for ; Wed, 05 Oct 2022 18:28:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=+jrS/QGH/pUVD9k6D6POGlMEiPy+3PwsTWkAJC84zJc=; b=YnmENS4blqGG1H+IVlsRScbhASYZ8vpVFvHhzhSuZkfd4YHTmCSxcV0O+Seik0uEzY GFxsnVJ/aLD6O5dA46HLCraVIJlq+Taq/SJOb0D+9fqgstEqKQ0ZcZYrf7lZABroHc6j tXUfBrfOwHMnxO4g4h/9SZv7WoucjxSjXhekU6q/lf0l0VISdj+KQJH7RwXlurxhMmiC jF+6hL4mI7URFHZjBRZjq97vFs3ovzqbg5oE0OiFG8AHpOvRhDKzcS8unDXptdYLWe07 4MZGLy1uWvOQSX1tb1hINve1CKkdUXProaEw1WCwohpn+240rN38lEYpODiVxBohleVQ Js6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=+jrS/QGH/pUVD9k6D6POGlMEiPy+3PwsTWkAJC84zJc=; b=TTSDBu/y02g5zeh9Gl28JQisgKkK+Qvsb23StKv94soUtf5kSiyXk0mLWAlKra7vNT dVjyb9i60bJP9hpnZPj2yeQG1MhCZLFwNTtityzOEQCOD82sCDFnLX1jYPuy2toFKFwA yVWJOrloP4ZddiBQAIscYUS31unmE/Cv28AaHa8MFR4tY24/laI9H8JfJFX8eZ1UO13q +0PVzA6L6kt6k6OCmjnDM+goiEcigAIXYdj4NCuX7EpUy6GH/fPIcV9rQ5Z3jz+y1tLY oMls+KQyus8R8rFMEmNm9xePwEKiR1U/I6+/9qBJv2NuMmTY6Hhzbi737m+fASpXwWiO lv9w== X-Gm-Message-State: ACrzQf2ekSi/FdkwVjYROXEecBJeEFrw7tW8iH3ZCvQu/wpeK9GSbCL2 9uRs8iAJtZBwMJHqLO5gRyk= X-Google-Smtp-Source: AMsMyM4rd6yzHhcY2DSt1VxrZbYMurpraVq0PQYgpYGGyPpsiY4FCfhY9qGRuH9z8n8JQqvPXkX0Ag== X-Received: by 2002:a17:907:9727:b0:78a:e09c:f2f9 with SMTP id jg39-20020a170907972700b0078ae09cf2f9mr1890447ejc.455.1665019710164; Wed, 05 Oct 2022 18:28:30 -0700 (PDT) Received: from mypc.localnet (host-79-17-38-224.retail.telecomitalia.it. [79.17.38.224]) by smtp.gmail.com with ESMTPSA id b15-20020a17090630cf00b0078d01a38cc8sm3926557ejb.35.2022.10.05.18.28.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Oct 2022 18:28:29 -0700 (PDT) From: "Fabio M. De Francesco" To: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, syzkaller-bugs@googlegroups.com Cc: syzbot Subject: Re: [syzbot] memory leak in __get_metapage Date: Thu, 06 Oct 2022 03:28:29 +0200 Message-ID: <2217443.iZASKD2KPV@mypc> In-Reply-To: <0000000000008a5a2e05ea318aa9@google.com> References: <0000000000008a5a2e05ea318aa9@google.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="nextPart1925904.PYKUYFuaPT" Content-Transfer-Encoding: 7Bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1665019711; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+jrS/QGH/pUVD9k6D6POGlMEiPy+3PwsTWkAJC84zJc=; b=p3/sA7i9zSnCsy1HPxSWojbRMgKIMMWnZjG2bV/QyB1JY0UCx9YuDGrUkeOWDgOHyYpaFp +oagwZm+XZrMw+PqRMJ+vdjAa9eR2Zjd94ujhGuZgVh5878IcPLJj5FryektOneGsS7pt0 XE3iWPtbnfMh69INY48psOyQmeaLeqI= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=YnmENS4b; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf19.hostedemail.com: domain of fmdefrancesco@gmail.com designates 209.85.218.53 as permitted sender) smtp.mailfrom=fmdefrancesco@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1665019711; a=rsa-sha256; cv=none; b=IPNt/yKpaA+8qtq7xDKYEwXC9eR0EtvUHH6KT2dqZhMzVNGgZb3nxJK3dkvbuShUW2T8qw FuARUCtHHXlfNP7TY0lgWHyZaVO4bdwegk5Wq5r5cO/GYy4ffap5eHqAJwhxB6Q94dUTry N6Y5GcIFsVmKExrzw3KQVoqyvYQxTcQ= X-Rspamd-Queue-Id: 4BAF51A001A Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=YnmENS4b; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf19.hostedemail.com: domain of fmdefrancesco@gmail.com designates 209.85.218.53 as permitted sender) smtp.mailfrom=fmdefrancesco@gmail.com X-Rspam-User: X-Rspamd-Server: rspam10 X-Stat-Signature: swp5j9ci9ic71ft61jsim6esid4okenc X-HE-Tag: 1665019711-55695 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: This is a multi-part message in MIME format. --nextPart1925904.PYKUYFuaPT Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8" On Tuesday, October 4, 2022 10:49:42 AM CEST syzbot wrote: > Hello, > > syzbot found the following issue on: > > HEAD commit: 4fe89d07dcc2 Linux 6.0 > git tree: upstream > console output: https://syzkaller.appspot.com/x/log.txt?x=169a7924880000 > kernel config: https://syzkaller.appspot.com/x/.config?x=21254cf9c7c084e0 > dashboard link: https://syzkaller.appspot.com/bug?extid=389b82b29093b3e2640a > compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 > syz repro: https://syzkaller.appspot.com/x/repro.syz?x=10bdd7ec880000 > > Downloadable assets: > disk image: https://storage.googleapis.com/syzbot-assets/651a252f7035/ disk-4fe89d07.raw.xz > vmlinux: https://storage.googleapis.com/syzbot-assets/776feb8e0e5b/ vmlinux-4fe89d07.xz > > IMPORTANT: if you fix the issue, please add the following tag to the commit: > Reported-by: syzbot+389b82b29093b3e2640a@syzkaller.appspotmail.com > > BUG: memory leak > unreferenced object 0xffff888114339e80 (size 128): > comm "syz-executor.0", pid 3673, jiffies 4295017005 (age 12.610s) > hex dump (first 32 bytes): > 00 10 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ > 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ > backtrace: > [] mempool_alloc+0x73/0x230 mm/mempool.c:392 > [] alloc_metapage fs/jfs/jfs_metapage.c:176 [inline] > [] __get_metapage+0x38a/0x9b0 fs/jfs/jfs_metapage.c:651 > [] diNewExt+0x3f2/0x9d0 fs/jfs/jfs_imap.c:2265 > [] diAllocExt fs/jfs/jfs_imap.c:1945 [inline] > [] diAllocAG+0x9a4/0xd50 fs/jfs/jfs_imap.c:1662 > [] diAlloc+0x31f/0x900 fs/jfs/jfs_imap.c:1583 > [] ialloc+0x6a/0x3a0 fs/jfs/jfs_inode.c:56 > [] jfs_mkdir+0xf7/0x480 fs/jfs/namei.c:225 > [] vfs_mkdir+0x223/0x340 fs/namei.c:4013 > [] do_mkdirat+0x1a5/0x1e0 fs/namei.c:4038 > [] __do_sys_mkdir fs/namei.c:4058 [inline] > [] __se_sys_mkdir fs/namei.c:4056 [inline] > [] __x64_sys_mkdir+0x69/0x90 fs/namei.c:4056 > [] do_syscall_x64 arch/x86/entry/common.c:50 [inline] > [] do_syscall_64+0x35/0xb0 arch/x86/entry/common.c:80 > [] entry_SYSCALL_64_after_hwframe+0x63/0xcd > > BUG: memory leak > unreferenced object 0xffff888114339e00 (size 128): > comm "syz-executor.0", pid 3673, jiffies 4295017005 (age 12.610s) > hex dump (first 32 bytes): > 00 10 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ > 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ > backtrace: > [] mempool_alloc+0x73/0x230 mm/mempool.c:392 > [] alloc_metapage fs/jfs/jfs_metapage.c:176 [inline] > [] __get_metapage+0x38a/0x9b0 fs/jfs/jfs_metapage.c:651 > [] diNewExt+0x3f2/0x9d0 fs/jfs/jfs_imap.c:2265 > [] diAllocExt fs/jfs/jfs_imap.c:1945 [inline] > [] diAllocAG+0x9a4/0xd50 fs/jfs/jfs_imap.c:1662 > [] diAlloc+0x31f/0x900 fs/jfs/jfs_imap.c:1583 > [] ialloc+0x6a/0x3a0 fs/jfs/jfs_inode.c:56 > [] jfs_mkdir+0xf7/0x480 fs/jfs/namei.c:225 > [] vfs_mkdir+0x223/0x340 fs/namei.c:4013 > [] do_mkdirat+0x1a5/0x1e0 fs/namei.c:4038 > [] __do_sys_mkdir fs/namei.c:4058 [inline] > [] __se_sys_mkdir fs/namei.c:4056 [inline] > [] __x64_sys_mkdir+0x69/0x90 fs/namei.c:4056 > [] do_syscall_x64 arch/x86/entry/common.c:50 [inline] > [] do_syscall_64+0x35/0xb0 arch/x86/entry/common.c:80 > [] entry_SYSCALL_64_after_hwframe+0x63/0xcd > > BUG: memory leak > unreferenced object 0xffff888114339d80 (size 128): > comm "syz-executor.0", pid 3673, jiffies 4295017005 (age 12.610s) > hex dump (first 32 bytes): > 00 10 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ > 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ > backtrace: > [] mempool_alloc+0x73/0x230 mm/mempool.c:392 > [] alloc_metapage fs/jfs/jfs_metapage.c:176 [inline] > [] __get_metapage+0x38a/0x9b0 fs/jfs/jfs_metapage.c:651 > [] diNewExt+0x3f2/0x9d0 fs/jfs/jfs_imap.c:2265 > [] diAllocExt fs/jfs/jfs_imap.c:1945 [inline] > [] diAllocAG+0x9a4/0xd50 fs/jfs/jfs_imap.c:1662 > [] diAlloc+0x31f/0x900 fs/jfs/jfs_imap.c:1583 > [] ialloc+0x6a/0x3a0 fs/jfs/jfs_inode.c:56 > [] jfs_mkdir+0xf7/0x480 fs/jfs/namei.c:225 > [] vfs_mkdir+0x223/0x340 fs/namei.c:4013 > [] do_mkdirat+0x1a5/0x1e0 fs/namei.c:4038 > [] __do_sys_mkdir fs/namei.c:4058 [inline] > [] __se_sys_mkdir fs/namei.c:4056 [inline] > [] __x64_sys_mkdir+0x69/0x90 fs/namei.c:4056 > [] do_syscall_x64 arch/x86/entry/common.c:50 [inline] > [] do_syscall_64+0x35/0xb0 arch/x86/entry/common.c:80 > [] entry_SYSCALL_64_after_hwframe+0x63/0xcd > > BUG: memory leak > unreferenced object 0xffff8881142f0300 (size 128): > comm "syz-executor.0", pid 3676, jiffies 4295017533 (age 7.330s) > hex dump (first 32 bytes): > 00 10 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ > 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ > backtrace: > [] mempool_alloc+0x73/0x230 mm/mempool.c:392 > [] alloc_metapage fs/jfs/jfs_metapage.c:176 [inline] > [] __get_metapage+0x38a/0x9b0 fs/jfs/jfs_metapage.c:651 > [] diNewExt+0x3f2/0x9d0 fs/jfs/jfs_imap.c:2265 > [] diAllocExt fs/jfs/jfs_imap.c:1945 [inline] > [] diAllocAG+0x9a4/0xd50 fs/jfs/jfs_imap.c:1662 > [] diAlloc+0x31f/0x900 fs/jfs/jfs_imap.c:1583 > [] ialloc+0x6a/0x3a0 fs/jfs/jfs_inode.c:56 > [] jfs_mkdir+0xf7/0x480 fs/jfs/namei.c:225 > [] vfs_mkdir+0x223/0x340 fs/namei.c:4013 > [] do_mkdirat+0x1a5/0x1e0 fs/namei.c:4038 > [] __do_sys_mkdir fs/namei.c:4058 [inline] > [] __se_sys_mkdir fs/namei.c:4056 [inline] > [] __x64_sys_mkdir+0x69/0x90 fs/namei.c:4056 > [] do_syscall_x64 arch/x86/entry/common.c:50 [inline] > [] do_syscall_64+0x35/0xb0 arch/x86/entry/common.c:80 > [] entry_SYSCALL_64_after_hwframe+0x63/0xcd > #syz test git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 6.0 --nextPart1925904.PYKUYFuaPT Content-Disposition: attachment; filename="jfs.diff" Content-Transfer-Encoding: 7Bit Content-Type: text/x-patch; charset="UTF-8"; name="jfs.diff" diff --git a/fs/jfs/jfs_metapage.c b/fs/jfs/jfs_metapage.c index 2e8461ce74de..b3ba1cefc230 100644 --- a/fs/jfs/jfs_metapage.c +++ b/fs/jfs/jfs_metapage.c @@ -678,6 +678,7 @@ struct metapage *__get_metapage(struct inode *inode, unsigned long lblock, unlock: unlock_page(page); + put_page(page); return NULL; } --nextPart1925904.PYKUYFuaPT--