From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C048AC02183 for ; Tue, 14 Jan 2025 02:56:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4FF70280004; Mon, 13 Jan 2025 21:56:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4AF0F280001; Mon, 13 Jan 2025 21:56:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 39DF9280004; Mon, 13 Jan 2025 21:56:03 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 1B7C7280001 for ; Mon, 13 Jan 2025 21:56:03 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id C566A43735 for ; Tue, 14 Jan 2025 02:56:02 +0000 (UTC) X-FDA: 83004542964.16.7F1ED27 Received: from out30-112.freemail.mail.aliyun.com (out30-112.freemail.mail.aliyun.com [115.124.30.112]) by imf21.hostedemail.com (Postfix) with ESMTP id 168E01C0014 for ; Tue, 14 Jan 2025 02:55:59 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=xKc43jpS; dmarc=pass (policy=none) header.from=linux.alibaba.com; spf=pass (imf21.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.112 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736823361; a=rsa-sha256; cv=none; b=eAJNw6ED1TxnJRvyf7qOcqsxYVKG4BWlLQWLiam/Wirq80vFwltNxHLO51vfdigHMnORF2 P4ZEIMgxaGuXWApo6CPaGBhnKkt46Q/l9JrmU8HXQvt58jQ9WcTgAB2HT/C8udmP4r2yaR XPk7/aHr4uQPbZgnYm8wPbJh70litaM= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=xKc43jpS; dmarc=pass (policy=none) header.from=linux.alibaba.com; spf=pass (imf21.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.112 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736823361; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=IjVJp/Tn6fX3LEf8wmhADih2F2lTUv2YGcfXrVdHbPI=; b=Q2+A66qUyvsuigymdljBPruXhBnG+6eh2t6wfYCAc1/MSr2hHh7W6dsmBfTL6YLsdd6l8P zdO3MY9mkgLXcvGbeMIJkfVp9tjj2Q0QRxxoz+Fb8RaiDINB4WjM1jzoOMYRgU0x/AHQFc AcQpeaDJ8LCQg+hJqWcB8F9UC/Y+Bjw= DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1736823357; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=IjVJp/Tn6fX3LEf8wmhADih2F2lTUv2YGcfXrVdHbPI=; b=xKc43jpSjQOY23+BGlHhUxgLxTSgC1hpJYQ7V22o6AkwzILClGNJVlTUP7YQcLSNmFO2vSgU/Dpgu1/l0y/52ZGAedhdFlsOC0QbWipJj2sX00KoNrEV3rrnGOlz+j2EPoM68Q3bIQldl4FlaCLqt+ak8ZnzxT3lt/2TVm1FmQk= Received: from 30.74.144.113(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0WNd8Wfg_1736823354 cluster:ay36) by smtp.aliyun-inc.com; Tue, 14 Jan 2025 10:55:55 +0800 Message-ID: <21fa516b-8828-40c5-b5cb-d97cdf01f0f2@linux.alibaba.com> Date: Tue, 14 Jan 2025 10:55:53 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/4] mm: Set folio swapbacked iff folios are dirty in try_to_unmap_one To: Barry Song <21cnbao@gmail.com>, akpm@linux-foundation.org, linux-mm@kvack.org Cc: chrisl@kernel.org, david@redhat.com, ioworker0@gmail.com, kasong@tencent.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, ryan.roberts@arm.com, v-songbaohua@oppo.com, x86@kernel.org, linux-riscv@lists.infradead.org, ying.huang@intel.com, zhengtangquan@oppo.com, lorenzo.stoakes@oracle.com References: <20250113033901.68951-1-21cnbao@gmail.com> <20250113033901.68951-2-21cnbao@gmail.com> From: Baolin Wang In-Reply-To: <20250113033901.68951-2-21cnbao@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 168E01C0014 X-Stat-Signature: opa1agujj7txp75j8bryph8oiurssr1j X-Rspam-User: X-HE-Tag: 1736823359-624244 X-HE-Meta: U2FsdGVkX193gnyMs5Z7CNm7F+3g7FbPkP9FJyuj/vWUVEzMk2qlIEAko8gTPD4B3/BRK8oHsT/Vkh/B64pOWFriDsHvVH/79QgDElt5lPN5a12hUO28CV7+B976+aVxbnETpR27jp/Tk6gqc9zAQfDlPAVu4qWiAsFCb9qvBDQAN7QiCpLFfjnyyMise+inLEW9WMNfhMqbHCJyfQqpR4SEwlp2ThyTHnUNIXGP2yUYEAVuKah6/FnCJiwEI6lXxJp5Na854NZS4FqNsUYJWt9SWSV7snEmLVmLX7zMQklpnJyHYsz9Pi5jqCzUcsN9zDEROhpUmhb4mak+H5HeK4r7tI5kfNN+aMxMcyPQzoRFQTuPu8ywm01bGD/W2/qluzwjbDu1S+kYsOQt0Oc1EZNMqfAdHkcIgcWhli7/eLDqIPoqCaiwBoUyiB9EGu/SeyG7lumHtK/w6D8JgXPheWv9h37j+yIFm7V0mt0+jVN3WVxGBQ+XeY7lmotsUAJl7fFRLKli5m+bmmdkpCal2wz7g/ftEzzXy+YaGZa7S2IsDOMmmunYH68H/4/Ubjw4i6BmbDL94EfAcNMFw0c8vPEoxSL5M6KynGY96jnZ3NL30aAdtVz7MW5FS1RSsFppVqe11/k3UCfevIrWur68pj5GosU8omVhpAzpsS86eeygFbudNYSQMjbD6Vqww55jmbhKZgvqpjXyKlAvrkKqRB8TviqFsFGgEs6lKHwndKPTSbJkguvHZM73zrOitjSnHMavtrUZOqw+/loXi0jwugtyqzp+kpOhqahGYQdjbhyjOGDkplq47KbMnQC7PxTmAW1BPjTLGf/2AfxYOOutGZHJYlDBqR8M54UyGvzjqSDaAy7zd7Rpo5PN1dhj7YHpzC3taO8dsqK5ZiRLk5/hJ4DP5AEbadMpwkVMNHXiw6l6sApGR4wiNKXucyFAqZaGkIEmewHYS+Gco7/PHAz wFmnTTBC M4+XF670HAembfAjKf3Zv0GTOjgm6aYAv5WyDuP+DC99ZBLEF7dCpi67poEfQL6l2XF9pcqnXcaihp0FLg2lOBVX9FzEgCX87TZkoyGSHEdbidq84RNgZ75REQzUO5PfyXBM+rmZUky/cuRx8DYVFV2aT/KqOQDqsowBELEggmTvCynuSgunP+r4g01drZ+1ijIoRDklIxkqFr7K0VoztzL604aCsv8Bsd4AlBogPsEnI2bGO+or7ikeMcZ4EDTyBXLReA6QHlo8lYz2H83zoXcmstgrFm3aSP8Kguh405U6d92YuZVOePnvhQPhjf2xwm+DZGMnTJHeIfetgkltIGPsrCDZAND3zf5vPgT5yesn+aRAcaW/UMRqNdZIDmjdAt/sbifYMXaBP2VgqpADFlrCfAEwSnDG1Zm+xHSUqY16TIZgPxnj7WpLQeg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.271889, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2025/1/13 11:38, Barry Song wrote: > From: Barry Song > > The refcount may be temporarily or long-term increased, but this does > not change the fundamental nature of the folio already being lazy- > freed. Therefore, we only reset 'swapbacked' when we are certain the > folio is dirty and not droppable. > > Suggested-by: David Hildenbrand > Signed-off-by: Barry Song LGTM. Feel free to add: Reviewed-by: Baolin Wang