From: andrey.konovalov@linux.dev
To: Marco Elver <elver@google.com>,
Alexander Potapenko <glider@google.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Cc: Andrey Konovalov <andreyknvl@gmail.com>,
Dmitry Vyukov <dvyukov@google.com>,
Andrey Ryabinin <ryabinin.a.a@gmail.com>,
kasan-dev@googlegroups.com, Mark Rutland <mark.rutland@arm.com>,
Vincenzo Frascino <vincenzo.frascino@arm.com>,
Sami Tolvanen <samitolvanen@google.com>,
Peter Collingbourne <pcc@google.com>,
Evgenii Stepanov <eugenis@google.com>,
Florian Mayer <fmayer@google.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Andrey Konovalov <andreyknvl@google.com>
Subject: [PATCH v2 1/4] stacktrace: add interface based on shadow call stack
Date: Wed, 23 Mar 2022 16:32:52 +0100 [thread overview]
Message-ID: <21e3e20ea58e242e3c82c19abbfe65b579e0e4b8.1648049113.git.andreyknvl@google.com> (raw)
In-Reply-To: <cover.1648049113.git.andreyknvl@google.com>
From: Andrey Konovalov <andreyknvl@google.com>
Add a new interface stack_trace_save_shadow() for collecting stack traces
by copying frames from the Shadow Call Stack.
Collecting stack traces this way is significantly faster: boot time
of a defconfig build with KASAN enabled gets descreased by ~30%.
The few patches following this one add an implementation of
stack_trace_save_shadow() for arm64.
The implementation of the added interface is not meant to use
stack_trace_consume_fn to avoid making a function call for each
collected frame to further improve performance.
Signed-off-by: Andrey Konovalov <andreyknvl@google.com>
---
arch/Kconfig | 6 ++++++
include/linux/stacktrace.h | 15 +++++++++++++++
kernel/stacktrace.c | 21 +++++++++++++++++++++
3 files changed, 42 insertions(+)
diff --git a/arch/Kconfig b/arch/Kconfig
index e12a4268c01d..207c1679c53a 100644
--- a/arch/Kconfig
+++ b/arch/Kconfig
@@ -1041,6 +1041,12 @@ config HAVE_RELIABLE_STACKTRACE
arch_stack_walk_reliable() function which only returns a stack trace
if it can guarantee the trace is reliable.
+config HAVE_SHADOW_STACKTRACE
+ bool
+ help
+ If this is set, the architecture provides the arch_stack_walk_shadow()
+ function, which collects the stack trace from the shadow call stack.
+
config HAVE_ARCH_HASH
bool
default n
diff --git a/include/linux/stacktrace.h b/include/linux/stacktrace.h
index 97455880ac41..b74d1e42e157 100644
--- a/include/linux/stacktrace.h
+++ b/include/linux/stacktrace.h
@@ -60,6 +60,9 @@ int arch_stack_walk_reliable(stack_trace_consume_fn consume_entry, void *cookie,
void arch_stack_walk_user(stack_trace_consume_fn consume_entry, void *cookie,
const struct pt_regs *regs);
+
+int arch_stack_walk_shadow(unsigned long *store, unsigned int size,
+ unsigned int skipnr);
#endif /* CONFIG_ARCH_STACKWALK */
#ifdef CONFIG_STACKTRACE
@@ -108,4 +111,16 @@ static inline int stack_trace_save_tsk_reliable(struct task_struct *tsk,
}
#endif
+#if defined(CONFIG_STACKTRACE) && defined(CONFIG_HAVE_SHADOW_STACKTRACE)
+int stack_trace_save_shadow(unsigned long *store, unsigned int size,
+ unsigned int skipnr);
+#else
+static inline int stack_trace_save_shadow(unsigned long *store,
+ unsigned int size,
+ unsigned int skipnr)
+{
+ return -ENOSYS;
+}
+#endif
+
#endif /* __LINUX_STACKTRACE_H */
diff --git a/kernel/stacktrace.c b/kernel/stacktrace.c
index 9ed5ce989415..fe305861fd55 100644
--- a/kernel/stacktrace.c
+++ b/kernel/stacktrace.c
@@ -237,6 +237,27 @@ unsigned int stack_trace_save_user(unsigned long *store, unsigned int size)
}
#endif
+#ifdef CONFIG_HAVE_SHADOW_STACKTRACE
+/**
+ * stack_trace_save_shadow - Save a stack trace based on shadow call stack
+ * @store: Pointer to the storage array
+ * @size: Size of the storage array
+ * @skipnr: Number of entries to skip at the start of the stack trace
+ *
+ * Return: Number of trace entries stored.
+ */
+int stack_trace_save_shadow(unsigned long *store, unsigned int size,
+ unsigned int skipnr)
+{
+ /*
+ * Do not use stack_trace_consume_fn to avoid making a function
+ * call for each collected frame to improve performance.
+ * Skip + 1 frame to skip stack_trace_save_shadow.
+ */
+ return arch_stack_walk_shadow(store, size, skipnr + 1);
+}
+#endif
+
#else /* CONFIG_ARCH_STACKWALK */
/*
--
2.25.1
next prev parent reply other threads:[~2022-03-23 15:33 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-23 15:32 [PATCH v2 0/4] kasan, arm64, scs, stacktrace: collect stack traces from Shadow Call Stack andrey.konovalov
2022-03-23 15:32 ` andrey.konovalov [this message]
2022-03-25 20:46 ` [PATCH v2 1/4] stacktrace: add interface based on shadow call stack Andrew Morton
2022-03-29 18:36 ` Andrey Konovalov
2022-03-31 9:19 ` Mark Rutland
2022-04-05 15:37 ` Andrey Konovalov
2022-03-23 15:32 ` [PATCH v2 2/4] arm64, scs: save scs_sp values per-cpu when switching stacks andrey.konovalov
2022-03-24 11:08 ` kernel test robot
2022-03-24 21:39 ` kernel test robot
2022-03-31 9:24 ` Mark Rutland
2022-04-05 15:22 ` Andrey Konovalov
2022-03-23 15:32 ` [PATCH v2 3/4] arm64: implement stack_trace_save_shadow andrey.konovalov
2022-03-24 8:35 ` kernel test robot
2022-03-31 9:32 ` Mark Rutland
2022-04-05 15:38 ` Andrey Konovalov
2022-03-23 15:32 ` [PATCH v2 4/4] kasan: use stack_trace_save_shadow andrey.konovalov
2022-03-28 12:49 ` Marco Elver
2022-03-29 18:36 ` Andrey Konovalov
2022-03-28 12:36 ` [PATCH v2 0/4] kasan, arm64, scs, stacktrace: collect stack traces from Shadow Call Stack Marco Elver
2022-03-29 18:36 ` Andrey Konovalov
2022-03-29 20:11 ` Andrey Konovalov
2022-03-31 9:54 ` Mark Rutland
2022-03-31 12:39 ` Mark Rutland
2022-04-05 15:10 ` Andrey Konovalov
2022-04-07 18:41 ` Mark Rutland
2022-04-13 19:28 ` Andrey Konovalov
2022-04-14 7:02 ` Mark Rutland
2022-04-05 15:09 ` Andrey Konovalov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21e3e20ea58e242e3c82c19abbfe65b579e0e4b8.1648049113.git.andreyknvl@google.com \
--to=andrey.konovalov@linux.dev \
--cc=akpm@linux-foundation.org \
--cc=andreyknvl@gmail.com \
--cc=andreyknvl@google.com \
--cc=catalin.marinas@arm.com \
--cc=dvyukov@google.com \
--cc=elver@google.com \
--cc=eugenis@google.com \
--cc=fmayer@google.com \
--cc=glider@google.com \
--cc=kasan-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mark.rutland@arm.com \
--cc=pcc@google.com \
--cc=ryabinin.a.a@gmail.com \
--cc=samitolvanen@google.com \
--cc=vincenzo.frascino@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox