From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79768C4345F for ; Mon, 29 Apr 2024 11:36:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D00E36B0092; Mon, 29 Apr 2024 07:36:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CB16B6B0093; Mon, 29 Apr 2024 07:36:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BC6FF6B0095; Mon, 29 Apr 2024 07:36:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id A05206B0092 for ; Mon, 29 Apr 2024 07:36:33 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id F2506A1A10 for ; Mon, 29 Apr 2024 11:36:31 +0000 (UTC) X-FDA: 82062366582.03.30097AD Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf30.hostedemail.com (Postfix) with ESMTP id CFF2C8003A for ; Mon, 29 Apr 2024 11:36:29 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=GoteHLpo; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf30.hostedemail.com: domain of hawk@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=hawk@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714390590; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SSAXz/i7SXl7+jGpVQKDnMdU2vCosD/01yeGZ7zoV6Y=; b=vuj6aVJ+wP86GRle7WpTSyNc2qEohe6ks28sxEMaBK9BMAdqwIdBYDnFQ10yXrkEaKbZLe 4RN24JwVTF6oo0KEitxrUFjFXbI6WJz5jAAMM6rNSYsnVR2HawEx2wyM1izUPxaUFcY7/a mlC75eZc/pZit/5jYORcHSxb/XBTpXE= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=GoteHLpo; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf30.hostedemail.com: domain of hawk@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=hawk@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714390590; a=rsa-sha256; cv=none; b=CHPWsWulCrXebaY7m/VuQyhEMioYQFewMFoOH8pgthOmBYq1PSEXEk4u8N0Uo0oGnOYbg3 h0VrvOXdMw2KOWnlX44qwe5SVRe//vs2qEALxTGn0hAKRuwpf66gZ9HTKAw4h3Xlc7fGE6 y91IGuxqSOH0UdDNuEKGPT+rROT7I/Q= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 9029BCE0B25; Mon, 29 Apr 2024 11:36:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 239D8C113CD; Mon, 29 Apr 2024 11:36:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1714390584; bh=pW4q+Ms5JJAaPWrYlwZ6qTOWYSfW5QeO9KUHreTbyqM=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=GoteHLpouWGXccfFDzZzPcBUmPUzUVAXMSfKJKNFdwI6id8I5FzWv1rQGs92sLr6S Gr0EblQ1T0ZRDfwhVK1vNhXEQcam5PTiqv9pDQ2ttckwwnF1H2Z3IFVzWR1klYA1zA ohGQxHanHXjfv4+bUPubnhamjczy8Z+OWpl7yNl98kYNrLupoBcGIiyxs/P2baox3C BfnR19jJiNLJDWybIjRToqNIK3RzVRX2Ji0ssMjEkChMl5j4IoGCZWKNGUvdNX/Y+T UGNk7IT8PFg89scGqxLNk4tBj38/GHGl9lImI7KXRbKa/d0VcjjVKPP3YK86qtLYP0 TDANw2Q4wWMUQ== Message-ID: <21dd3b6e-6e7b-4dcb-9050-4d63fc810749@kernel.org> Date: Mon, 29 Apr 2024 13:36:20 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 1/3] cgroup/rstat: add cgroup_rstat_lock helpers and tracepoints To: Simon Horman Cc: tj@kernel.org, hannes@cmpxchg.org, lizefan.x@bytedance.com, cgroups@vger.kernel.org, yosryahmed@google.com, longman@redhat.com, netdev@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, shakeel.butt@linux.dev, kernel-team@cloudflare.com, Arnaldo Carvalho de Melo , Sebastian Andrzej Siewior , mhocko@kernel.org References: <171328983017.3930751.9484082608778623495.stgit@firesoul> <171328988660.3930751.17537768209042139758.stgit@firesoul> <20240423165350.GY42092@kernel.org> Content-Language: en-US From: Jesper Dangaard Brouer In-Reply-To: <20240423165350.GY42092@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: CFF2C8003A X-Stat-Signature: oftsa1ibdrog71nkhm8ha717whiasa93 X-Rspam-User: X-HE-Tag: 1714390589-42270 X-HE-Meta: U2FsdGVkX1+RhegEiHYnvuAQEvQrooKqS1GLp5/1dwNACMSPrkE/N0m1q6cqqRhZdqDIamQTAuiWAGWY46yEkFfa6xwpyWqKZMjxwvOY2i09lTugOGLSVt+IQXjbCqXGcEpYqom18G/5QoDvyfA35+ZRh1os6hfaHi4GhbDVLvo4b8AqIULiNN+og8GNYRf23h/jQdPRI+B/LQGhQ6yX1Z+h7jM8aSz1oY7Erk3seXJTvuRbdwZSKjKwWGB0AcLhnHGqXS58pFIrmWQe2p8j4vGHIWgUCVoa4KO9HFgJUweRAyRqPbntoPCO0wDuTd1LIdTQggXm2L41s1sVdL8z7uFM/Sp5SrWVTf8QOx2r5PENAdit2xekW3c3UEI25ACjPYBDiQ2Du0VE88hEcTv8Qo0rCQW+O46UArdALRUqtRAqO96lif5MtzaWCxf+5KkKE0ya6iWV/yxuqRfQaz/EW/xXN+/wPufE47GkWb9+lAyc3AGNA6ZR22sS5sQbUSofuf7IMWDvjPl18/JWjdnmCmdOKBMbTBMZCuPfDeLnjZ0jS8hJdp/9gmtyNBdY7okLAoZjazYfG7nBX456zMAnmBr39MQz3HgWHJEDCrWgI18plQQZNoCIURx9CKzDr5x2ITRmgH40J2kasSlyiN5yVliwg/4DjocXN59eLUaZvaTmhBeLffsndX7avA7W0iRUWqSyrxMYsq8VNHBLpGdJSwRfY5HuWwESplcO9oz7jHUEG+KVYgavUKzbcDogfDAMQhZenGoJfK4XFt/M63BXbZN4noe2o5mZ9NV3K2V2cqqYx/2PUf3MzXqlyEtCi8Wzia+HJg9RD2kpJdt3RGETxZYnob6EaHwbTf2V0fS7/fgEon+lhDKTEKdsfKq8JromP7Go+GiMbJO3AahrZuiXS712z5ChRU/S+cDT8hmuAVRqsJDUN2obVHhR+swwkZNrI/yyXxwzEsfFd3/cS/5 0PL7zRIL IFfuwMXLQVORU7nKZH3K60ddJInC+H9m7odUIlHuIJsuqmrdiFsxTkI0KfxIRCZMGFxofFxaCtZaw8zc0R4YUXkybG1Xw+4MGjtVvrVKCcNbey7juAWDt+Y78uId/NA/MSQTqsdKvCk/gAbK6wzw5wiiiOpsYm4aVdmzddYMwxkiYvMUZAcruIjTHDiVrWJZxXV+DwNl4WrRtKO1Jgc/WUFgFFlwZdIMbdz3C4UAZstYs8i9i8SmeqZVu4OpZQqOwxK2Vp4RMF5YhivfTxSATYfcBpoDov9bFAy+NsGowLiQmGviHWTDMxo4PXAms5oMdfcUi8CtwaZwtA1K5qAF2U2CfM1MpErBv6ATjAcOSn82DnIlhUAtstMsWAq/bdSpULVdMDSirUmhvPyQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 23/04/2024 18.53, Simon Horman wrote: > On Tue, Apr 16, 2024 at 07:51:26PM +0200, Jesper Dangaard Brouer wrote: > > ... > >> /** >> * cgroup_rstat_flush_release - release cgroup_rstat_flush_hold() >> */ > > Hi Jesper, > > as a follow-up could you add an entry for cgrp to the kernel doc above? > Already fixed in TJ's tree for-6.10 - https://lore.kernel.org/cgroups/ZiB97v73Fr-wq14f@slm.duckdns.org/ - https://git.kernel.org/pub/scm/linux/kernel/git/tj/cgroup.git/commit/?h=for-6.10&id=97a46a66ad7d9126 But thanks Simon for your vigilance in noticing these things :-) --Jesper