From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C45AC77B61 for ; Mon, 24 Apr 2023 17:43:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B074C6B0071; Mon, 24 Apr 2023 13:43:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AB7136B0074; Mon, 24 Apr 2023 13:43:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 97ED06B0075; Mon, 24 Apr 2023 13:43:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 8897C6B0071 for ; Mon, 24 Apr 2023 13:43:44 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 437A6802C0 for ; Mon, 24 Apr 2023 17:43:44 +0000 (UTC) X-FDA: 80717007168.08.6A8F2D9 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf06.hostedemail.com (Postfix) with ESMTP id 61EAA180009 for ; Mon, 24 Apr 2023 17:43:41 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="qM9uTmL/"; spf=pass (imf06.hostedemail.com: domain of paulmck@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=paulmck@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1682358221; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UO3BV5gcnASAX3gvx0ejaehdz66TXaQD09BZpoilSnI=; b=4gr+VumwE/vd/T17u6Qc1zJ9YvKAtjxX5fS7V0ik5Zn12ef5v3crF3gZOUDFdjiMkiE7FV 3Ftvvj5ZPs1NOge4ghWHFYjaSnAPLDj9fAOXUNCYfwn62xDPzNi+vs2UhN2DbdTmfUQCSP a7bWkdjt/KWY/9u3rW654K9H4ZTKzEg= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="qM9uTmL/"; spf=pass (imf06.hostedemail.com: domain of paulmck@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=paulmck@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1682358221; a=rsa-sha256; cv=none; b=8WDYfgR9FZC4ymWEkWUz229byoQGjdbP136yEPQVa86TAF38wc7FluznlCqkoiviEglDED rTQskZzOePwyqcnFCura0K0Zu/9hE4IfFRaG4o/AbdHAIhHmFVWbH5b2Xai11d1XRqRsJt UQnVGxCHBcTwoTeBmcv3bSKzoFnybEA= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 403C360EDE; Mon, 24 Apr 2023 17:43:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A4097C433EF; Mon, 24 Apr 2023 17:43:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1682358219; bh=LCu1z2foNofLVVx12LIuTMFiH/53gIBxbTwTF1jRmwc=; h=Date:From:To:Cc:Subject:Reply-To:References:In-Reply-To:From; b=qM9uTmL/8n1DrwVgKgxtv1jCdG9D3f8UbQ3B6Jtikwk+M8gji1dBZNjBd+e3j1Pjl p1BQUC4mmoQlMC0EKyomwvIND6uuio1MxN7cEphezmkjHjqKdmaNO3wZ+ayQaiuzfC /hbaV6fATpJ0X6yTnf63sLKiGU1WUmfTiuMKQQTXZjhRDQchXlefkkQ9mdH2PCEa66 dlVkF0A3a4SW1LGxMaPGQYFmSjZ1eKSFXNWxkI2LkEBeknnuLNfUMkEH+TS81b1JZX tRRHFtr5m3MtGUx2s/tGVs6UISAVi888kMsDCGlWUshAULIFIRSiDkbUeoeUS8TVqV 8st4MhSOJJpww== Received: by paulmck-ThinkPad-P72.home (Postfix, from userid 1000) id 323C615404E7; Mon, 24 Apr 2023 10:43:39 -0700 (PDT) Date: Mon, 24 Apr 2023 10:43:39 -0700 From: "Paul E. McKenney" To: SeongJae Park Cc: akpm@linux-foundation.org, vbabka@suse.cz, willy@infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] mm/slab: add a missing semicolon on SLAB_TYPESAFE_BY_RCU example code Message-ID: <21cd0c00-4738-49f7-899f-ec3792520bfb@paulmck-laptop> Reply-To: paulmck@kernel.org References: <20230415033159.4249-1-sj@kernel.org> <20230415033159.4249-2-sj@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230415033159.4249-2-sj@kernel.org> X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 61EAA180009 X-Rspam-User: X-Stat-Signature: zjgn598d5okdi6z7iskuazjbzwngeho1 X-HE-Tag: 1682358221-808335 X-HE-Meta: U2FsdGVkX1/mbTjSio0LNe4U6qARCJJOO+9QBQ609sMYiaob3f02URL5RGBeRVVktRqCcaWF7A2x+kbYGqvbxLNvfOCIu7hrUmk58/4LpKduYn4h6x6COQgsC1TON6EU2bDh0NLoTSdxBayDIVBWqoXfOp+dFYbgF9o19d1OJ9i+LyQSTPnbkvPcojhN6GLXeZfHkNdO3/ThTgBzPkJjd4v1bnaFpcmwZ7UtjGs/dFv3iAM+IUJEvv37SMelXNNqTsovdThh7iHhiG0K9TO657Gy4aVZQce6n/1/In6SaojYqXzTnm31ikDmsGOUp7IuIZsOp7NPSN2WeWoR0p6xDj7J4nESKCy2Jvmzxf/X07KfrtKfbNVeLv4tgx8TmJKrG+pWjZ5nlwFTjcMm9JVLkSrhDHzdbYsannJ50Xjfq1NtNDD6rh1OGyrCcWaT9rI+iLXBqLjvRxBicI+KpF0G8XgyebDzbdgj5IR2WfMFyzutjc0W4CrUQkFiAV4jV/1MceHbzr/EtlVWsrPCu1C1vm1ofIyKR37JK9Iq5lMrxzFZDWV+xnz0SZaBAv6rDiKrwktOFVbxawWobvaJfqXgaRrnggdqDdORZNq3EHD73J1W/CAZX5moUI624wARgjex5tjVPkI9pph+DouoZbhndvZdLedsjyVCvKVXIy3ioFzoLA7rTYr1Xk5a7ScXFIeNbbCfliFq1lmnyNEUTyWAfCp4LJ+wb9EctMh+I4KnSBo0KvvB0ux8qFW/BPZKs2ukKv77S4Yn9/i0Dzp+BhLUoK9LazfXMTmKTSEL32AbzZ3t83wfDoc/zrzYkjVmuutE5GmtbX1BgnajLDyEDYKDd1UdeZLNEhCTnM/8R0yB2vUq/QLO4dzK3ZXQMzp8moslqtbSCghKfNfaSrgncoRitAFmmdQynWzpT9By92YRAjPjXtkV8GZVpH7z6FJjHJkqH3bVsE60s7CgFTpYrb0 9rbbEB// ZfqSWjFOC4BWmqoJGXyG4gsa04sHSnfMnbZuYjzwAMbyKOa+9RPY9EI3Xq82ln1zrjDrsUurIfATIRRh8FSLiWOJuCDjCfywmDkaGs9GDWkXYdmGEWFlybqug06WiDoxsjDEz8OPg/FG9xjqPYBlsBk6RSsLexex0Kvuos0YVGfcg4nyr3K4d7MhBnnXKm+4jjVR3iBdtEXgv7bzA8Ihdq8oniKmUfolYyW/ZCNo1yGZgleWvlZbuWopOAFSS/uLytPMlcvUBNrlC0OgD/3FdXcXKE/jRQnp2QTAG7+4WnoeyK5vqjPf2ayjR1I0+D5OiBz+sPMN/fbZIiPqoS+1YRUfz1EWob7JXL82rBzLDX7wg1PegGDBxiHwOzzF8WsdcQYV7w7egrrC950CUwdrMqXjHfsJRDccvVaq/R3DFyvev2KRcDU1oK0hR2vUU+w+pdX3AqeKBMgG3ekIveGyVvqVT+pqf5ORwBWWUSYpFwsrGI3o= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Apr 15, 2023 at 03:31:58AM +0000, SeongJae Park wrote: > An example code snippet for SLAB_TYPESAFE_BY_RCU is missing a semicolon. > Add it. > > Signed-off-by: SeongJae Park Reviewed-by: Paul E. McKenney Or please let me know if you would like me to take it. (Probably better going up through the usual slab route, though.) Thanx, Paul > --- > include/linux/slab.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/slab.h b/include/linux/slab.h > index f8b1d63c63a3..b18e56c6f06c 100644 > --- a/include/linux/slab.h > +++ b/include/linux/slab.h > @@ -53,7 +53,7 @@ > * stays valid, the trick to using this is relying on an independent > * object validation pass. Something like: > * > - * rcu_read_lock() > + * rcu_read_lock(); > * again: > * obj = lockless_lookup(key); > * if (obj) { > -- > 2.25.1 >