From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 916B0C2BD09 for ; Mon, 1 Jul 2024 08:24:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 276AD6B0082; Mon, 1 Jul 2024 04:24:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2578B6B0092; Mon, 1 Jul 2024 04:24:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 115CE6B0095; Mon, 1 Jul 2024 04:24:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id E469B6B0082 for ; Mon, 1 Jul 2024 04:24:30 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 6BB3A161A21 for ; Mon, 1 Jul 2024 08:24:30 +0000 (UTC) X-FDA: 82290497100.22.E7D877E Received: from out0-215.mail.aliyun.com (out0-215.mail.aliyun.com [140.205.0.215]) by imf14.hostedemail.com (Postfix) with ESMTP id DCF1D100013 for ; Mon, 1 Jul 2024 08:24:27 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=antgroup.com header.s=default header.b="B7k/XCZv"; dmarc=pass (policy=quarantine) header.from=antgroup.com; spf=pass (imf14.hostedemail.com: domain of libang.li@antgroup.com designates 140.205.0.215 as permitted sender) smtp.mailfrom=libang.li@antgroup.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719822252; a=rsa-sha256; cv=none; b=ZgcP1G036fJODcnee+GwS24+t0fSbRhhQMR4MkCy+QE4XjEFjOn9w3sQa70nabIttNLHI4 zNvLNZk6XjnQiPAEI3le936MEmwJWoCtui1Y5ooUIfnemK5C3lLN6Tqe0cG+SOtDFPJZKo O5fVEBHk9G5bFOxugW6ZaegkZZcnA+M= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=antgroup.com header.s=default header.b="B7k/XCZv"; dmarc=pass (policy=quarantine) header.from=antgroup.com; spf=pass (imf14.hostedemail.com: domain of libang.li@antgroup.com designates 140.205.0.215 as permitted sender) smtp.mailfrom=libang.li@antgroup.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719822252; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DDMQAn41L6SWm47GL1Pl/XtVoTBg9GDb/pxF+UO/8oc=; b=v/LjAfARYUuRyzQlAJ/XE+eagu2bIoRvJq1gwc4CMInGPogN+8G7bi82dWtUmjv60mDiHf oUiN7TnZaa6yil/rfEB8Ki4+eVAbroaK2Xum/G1tF2Kkhx198MRhQymWAkIxd6nqYZUu1o M/Sy9qY3ENgmUqCuMxlxEdVa5obuICw= DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=antgroup.com; s=default; t=1719822264; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=DDMQAn41L6SWm47GL1Pl/XtVoTBg9GDb/pxF+UO/8oc=; b=B7k/XCZv2Bgko6+2duBPdHDW+DhG805cKcdlmTrzOm8TIvrnSvRLRGLyKE/KHsTki7VzD7mhGOik07Rmy87us/J118cKfTGe0yGkQbAcbtTtTONBtvpHXa7DoZbzOOT6/B45g7M6Syniqebj50oy2EC7GpnMOI5/MwNrVzxpWRY= X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R101e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=maildocker-contentspam033068194251;MF=libang.li@antgroup.com;NM=1;PH=DS;RN=9;SR=0;TI=SMTPD_---.YE7WgG6_1719822263; Received: from 30.13.185.168(mailfrom:libang.li@antgroup.com fp:SMTPD_---.YE7WgG6_1719822263) by smtp.aliyun-inc.com; Mon, 01 Jul 2024 16:24:24 +0800 Message-ID: <21c698a4-f6b5-4afd-9f6c-72de08adad10@antgroup.com> Date: Mon, 01 Jul 2024 16:24:22 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] support "THPeligible" semantics for mTHP with anonymous shmem To: David Hildenbrand , hughd@google.com, akpm@linux-foundation.org Cc: ryan.roberts@arm.com, wangkefeng.wang@huawei.com, baolin.wang@linux.alibaba.com, ziy@nvidia.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <20240628104926.34209-1-libang.li@antgroup.com> <1bf214bb-86a7-4f73-a839-39a4b37bc04a@redhat.com> Content-Language: en-US From: "Bang Li" In-Reply-To: <1bf214bb-86a7-4f73-a839-39a4b37bc04a@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: DCF1D100013 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 5nyk8wquek1xrpa1g7bzswd79waa73s3 X-HE-Tag: 1719822267-530970 X-HE-Meta: U2FsdGVkX19+7FrBhic7ao9+Uh9Op3J07RMB7CW6VnATnbiYEFvHKNcYlwS3YTDcSIle5EdUA1hRRYZ4sSp1IMHAmU4yh9MU/gxLD36TmAwSR5U+ECwRPb1N4WQZAJH+MlxxRpsYoemOrfE5wAFqvoj6hewBy6aHRs4cGJamm2Vim+a0nkrbmwkvaLLfRrQW9+yXBsPojnoraxIh2kIqRIDNhhMMCutNwpP23rv0wtdSJjV/BBTIuuiRj1mm2bKMjjCoo0km4iLmlR2MuADoMlT5dLrZb14Z3QU/esDcPB1QD1XaRNpCGEhHQ/JHaw/V/q7uVkxzs1siCvf7t5pAbWsHMe/4QWM2uCz73oBW37P5YQbiuNhXLndbgLbSa1rWRatJT7Fm442CxLncjwMmpYcmo9/dVxo9G4yHnTmYnDYg+wRw1Ug/uCfhY97ABx82niWwvjGOO5Lde9o8IQSyz644mLmYQpImEn8PYq8hMzxc7LJ8BLBKu7e+A/2fs2NVF1t0Uo4x0Krn8BfnoWuOr2uR0HwxufRSxsXhAcOA+4HcL7Ts21YrKXPmCgmBMRHsag4wp520lmPQHOP5E+irc9mxG+133whfecOIb3RXrgwWRx49Ks3A0M8jY7u3l7rrX2rJeGgH2fkcp1m1WxCbj3Udk/bxFaYIpvjsDFi1BduyW91x4ciJm0SJnbK5dO5Nu+v8cb4t7tegNod71cLhHUP+5JDIAO21XxRrXfNZEOw+XQeKHlhL9u7SHwcv4UE+UxWHr05Vch+m3+4jLa6hozoK2FPo4DckeGNSA9DzGMdJPSzE2aEZqIhfbLy5DsclgZiygzRpvPnpOWrXrSl/OM4O8pUEFk/VMYTA27lH4ZmW/mlpRV8Ywd4XePaNVVMTVBpYAnQvbFjTmkA5uQ0wl9b52ODijNFPXgZz1wcWPi/Y+Tvea5DJje8YNP/ZMxbxYtYATODWvL2pYpX17w9 mGklnbBw I3lz9wm2b2iPYKiQm8JSbG6kr6rw5/r0tul+A7sPYeJ/vbqixmSyJnE9xIRSMaq1mMDGXYTDh88X46FAlsTQikQEl6cUy7X2/nu0vAoNHUjBrhxsFWfpJMH2GEgfF5x1kiOxA6wwwoVZmGaxPPXSwsm043g3YmJ2Y7zIPNhfd2O2G9bXz3eSD7teJUm7dVwAWv7KGcDFDsObTjyjkHfeYNCLqyU2U4dMr66ooTSvNgzsYKDvH6/UgnjLD8+usYZSzBPqav1JsBMy9+Mk23tViRdORK+oL98rw3r6TKMKvsT4o1mJjPgpjwb36Y4akv9YQfFxgxYY2WQ5QmeQo2ZwL8mh+qKyTkkv87dtVGpCEH5SyFZc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi David, Thanks for you review! On 2024/7/1 14:57, David Hildenbrand wrote: > On 28.06.24 12:49, Bang Li wrote: >> After the commit 7fb1b252afb5 ("mm: shmem: add mTHP support for >> anonymous shmem"), we can configure different policies through >> the multi-size THP sysfs interface for anonymous shmem. But >> currently "THPeligible" indicates only whether the mapping is >> eligible for allocating THP-pages as well as the THP is PMD >> mappable or not for anonymous shmem, we need to support semantics >> for mTHP with anonymous shmem similar to those for mTHP with >> anonymous memory. >> >> Signed-off-by: Bang Li >> --- >>   fs/proc/task_mmu.c      | 10 +++++++--- >>   include/linux/huge_mm.h | 11 +++++++++++ >>   mm/shmem.c              |  9 +-------- >>   3 files changed, 19 insertions(+), 11 deletions(-) >> >> diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c >> index 93fb2c61b154..09b5db356886 100644 >> --- a/fs/proc/task_mmu.c >> +++ b/fs/proc/task_mmu.c >> @@ -870,6 +870,7 @@ static int show_smap(struct seq_file *m, void *v) >>   { >>       struct vm_area_struct *vma = v; >>       struct mem_size_stats mss = {}; >> +    bool thp_eligible; >>       smap_gather_stats(vma, &mss, 0); >> @@ -882,9 +883,12 @@ static int show_smap(struct seq_file *m, void *v) >>       __show_smap(m, &mss, false); >> -    seq_printf(m, "THPeligible:    %8u\n", >> -           !!thp_vma_allowable_orders(vma, vma->vm_flags, >> -               TVA_SMAPS | TVA_ENFORCE_SYSFS, THP_ORDERS_ALL)); >> +    thp_eligible = !!thp_vma_allowable_orders(vma, vma->vm_flags, >> +                        TVA_SMAPS | TVA_ENFORCE_SYSFS, THP_ORDERS_ALL); >> +    if (vma_is_anon_shmem(vma)) >> +        thp_eligible = >> !!shmem_allowable_huge_orders(file_inode(vma->vm_file), >> +                            vma, vma->vm_pgoff, thp_eligible); > > I would have thought the correct fix is to return the correct result > from thp_vma_allowable_orders(). > Agreed. I'll try to reimplement this in thp_vma_allowable_orders(). Thanks again for the review! Bang