From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D1B9EC873A for ; Thu, 7 Sep 2023 15:39:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D99518D0001; Thu, 7 Sep 2023 11:39:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D1D148E0003; Thu, 7 Sep 2023 11:39:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B98518D0001; Thu, 7 Sep 2023 11:39:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id A3B406B0074 for ; Thu, 7 Sep 2023 11:39:20 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 6CEDE1602DE for ; Thu, 7 Sep 2023 15:39:20 +0000 (UTC) X-FDA: 81210210480.13.C149639 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.43]) by imf17.hostedemail.com (Postfix) with ESMTP id 4D40840026 for ; Thu, 7 Sep 2023 15:39:18 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=R8vgaa5l; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf17.hostedemail.com: domain of dave.hansen@intel.com designates 192.55.52.43 as permitted sender) smtp.mailfrom=dave.hansen@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694101158; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=X8mjSm9BJyHONekpxudc+A3dvY2gIZ8JwrWN+aJDlk8=; b=lyEkNMGOtdECTnpMv47xDjbGH46qPO1Qx8COjZ2L52G9cHyTa58Kt9Kh3TFtuzKWRyH0zb 5Yjw2OcawKR4h0sE0Ma+tT5AOdBHUBo3SZ2xum/zcBrbgHDIHF+WMYI5PLfdNCd1DISoTV JeVMmdyNvU+qc+hEBMFfB4JfSrdkRNU= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=R8vgaa5l; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf17.hostedemail.com: domain of dave.hansen@intel.com designates 192.55.52.43 as permitted sender) smtp.mailfrom=dave.hansen@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694101158; a=rsa-sha256; cv=none; b=xKKAAckkV26xvelTR+dARE7z2GJhD5rLNPyRI9E12G3bFxeLBtGTShah05tgOQOTC1L8zw lyTONQb0gCuSjB6DusS6QQh17e9n7s/ptgn+J+xvVr3yTzuZmj8brBg9e5gyU01kzFZwcF rZbE7E39cFDREpl2LQXLUMmKMbL9/fI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1694101158; x=1725637158; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=Gc47Wmv9yvPizcQSt3RG5ZLyHOAm3FccQUQk5XxXERw=; b=R8vgaa5lmu/qg0mkyhhXzNOdxcJHQIQdg6VtaONgQlfCWgwlUn0Fpg0V FrwxJx+nCXNNG5jb0ST9I45+Ni9CRKGyDhR8M/nHNThn/6HAPlPR16X+0 BiMUZBeZJiPGfKmBi9EX4l33o07KTciujQ4GLA+hxX/opvxYiiP8zXRa3 eqfNb4ESXlzcRfzccADYshebw6FS9MD8g+ZAlepZoxGIYGL70Ug0x1TLB FtI1PjPV6w0G7gy7liC1pmmIM4+3URUeoj3p6opW5DPiDLdwjHRcaVCba 6qTbXcbYrqr8SX1SR8K86lw60vWkRcXMKY1712A5Ontnq9RaZIlnQg3sK g==; X-IronPort-AV: E=McAfee;i="6600,9927,10826"; a="463768160" X-IronPort-AV: E=Sophos;i="6.02,235,1688454000"; d="scan'208";a="463768160" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Sep 2023 08:39:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10826"; a="865686230" X-IronPort-AV: E=Sophos;i="6.02,235,1688454000"; d="scan'208";a="865686230" Received: from ningle-mobl2.amr.corp.intel.com (HELO [10.209.13.77]) ([10.209.13.77]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Sep 2023 08:39:13 -0700 Message-ID: <21bf2e44-3316-2372-44cb-1488f88650f5@intel.com> Date: Thu, 7 Sep 2023 08:39:13 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Subject: Re: [PATCH 1/3] proc/vmcore: Do not map unaccepted memory Content-Language: en-US To: Adrian Hunter , "Kirill A. Shutemov" , Borislav Petkov , Andrew Morton Cc: Vlastimil Babka , Mike Rapoport , Lorenzo Stoakes , Tom Lendacky , Baoquan He , Vivek Goyal , Dave Young , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-coco@lists.linux.dev, linux-efi@vger.kernel.org, kexec@lists.infradead.org References: <20230906073902.4229-1-adrian.hunter@intel.com> <20230906073902.4229-2-adrian.hunter@intel.com> From: Dave Hansen In-Reply-To: <20230906073902.4229-2-adrian.hunter@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: ejx1irr8i13zfgdbbibfhk1a56x3cqdt X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 4D40840026 X-HE-Tag: 1694101158-652763 X-HE-Meta: U2FsdGVkX1/Xt9dB3RrqIG7lGWPtn7Vuoosw09mUU/3Y/a1WXoMIYuGQUfAiYPMpeA/rPaanVI9eEcbr9LuIkXOW4tsSjH7avJEvG3bqqrMpVqEyp4dD18/uHBWyGMQa9qPwyAZqS5UXX91bqE4o3taE1ejyp38fR5tQ+oAnhA/VacH6d5TTact8giduhz2/ptdb5nlBUr4wcnjWMPCnzvJQwuHeeRFAH7Bn/mukz7FVfve5xsTJLiDMUbBCvHkbVh05x7b7SGW+9uUw8FHf7N2/gHPhBZsTiqlsk2pkdzVUj4BqJqMpklLMRZsFDCJ/JQeej41VigbmusYI9r8Sxo1zbwXwqKEsh7tWek4kmzRo7mg6dH/wanUXvt8Nusx2xw+cCMbKliIjg6NSMbKeTOxIJfTGeTTQAwORS1rYtjnUgnyw7E0ekdf1NWS8T+HCktBjV9YLRfxgNaX3BJyRPOUz/fi51gU9daEPEWXh7U9/WJNY5pZiWICNhaIA7/X4w4HTlynRPRb+UcTTjtwxSVUTP6mToQf1tU8gBdy9CJOgjsrzuavMjt2n9yTZ8Fp0Ub+MKX2551b4viQ3bFxzkM/7Lm3uzFlCMSu+c/mjca+WwDTEpxDmm/Y0uqnBQDgXpIFK/JOfds2384RlJPKotBKWa3pbO7RSrM7dA0hZrrv/sXQ1swh3UftwANhk1DlhcxsxC5vb1KjKwghGA0L6IQV/+4kNj8WeFU21q+3Cma7E4wrwEBumgyK753fsMU3c3MD1GFa2F1zcBPIAdskai4+UgKFJ3sSxlNc9+KJcO5z9GRnE6hqgqk9CC/5DLy3YzCMNZLey85Z1Z9hZigHKqaCoNP4LsS1GXoEhnyTfkjr/N+y8FQZqim46++be1XvuR5mzlr6zBqwLQ1CMlp4HPd6Uzyl8V8jy7M/gFfkMoebSSCRouGnEuu4fG1+iIDdvPI9BjW8FD3iEl511w9M kGdMST2g WHTOzTALwTJ8MT2RWeuhu4ZO3BUKcJr9FtDkfIrER6SUutHKpr0AQBVxnV96EupFNqk4PzwUmkdb4T8p6lWZw+Q2Tsyi2RclHHOy0QZWtRuwerPgEpCDzN9HIhboZHH9KO10bYUKDLqo4jaE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 9/6/23 00:39, Adrian Hunter wrote: > @@ -559,7 +567,8 @@ static int vmcore_remap_oldmem_pfn(struct vm_area_struct *vma, > * pages without a reason. > */ > idx = srcu_read_lock(&vmcore_cb_srcu); > - if (!list_empty(&vmcore_cb_list)) > + if (!list_empty(&vmcore_cb_list) || > + range_contains_unaccepted_memory(paddr, paddr + size)) > ret = remap_oldmem_pfn_checked(vma, from, pfn, size, prot); > else > ret = remap_oldmem_pfn_range(vma, from, pfn, size, prot); The whole callback mechanism which fs/proc/vmcore.c::pfn_is_ram() implements seems to be in place to ensure that there aren't a billion different "ram" checks in here. Is there a reason you can't register_vmcore_cb() a callback to check for unaccepted memory?