From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4FC82C6FD18 for ; Tue, 18 Apr 2023 15:56:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E123E8E0002; Tue, 18 Apr 2023 11:56:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DC1EB8E0001; Tue, 18 Apr 2023 11:56:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C63268E0002; Tue, 18 Apr 2023 11:56:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id B6D298E0001 for ; Tue, 18 Apr 2023 11:56:49 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 8351EAC0F3 for ; Tue, 18 Apr 2023 15:56:49 +0000 (UTC) X-FDA: 80694964938.10.D555268 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf07.hostedemail.com (Postfix) with ESMTP id 3B4F940020 for ; Tue, 18 Apr 2023 15:56:47 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=iLO1Uuv7; spf=pass (imf07.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681833407; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Juss3UIfNZnJDgajqfUY7HSWywG2tSbHHgh51Zf9/Ao=; b=FJYufYDvOyphdJVPiVntShzngr5LYifJaO19ypaPKTp6aDh/33iaoaSr05BDpx7W895Fhq Xleok81r35zWFopgCV3VC4jx/G963cDuOLbxKB2SKemkeCWhn5l/K56xyURmp3VSj8QYSx Dl62n/wIecW5rixQXD2ss0Lracm3PkI= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=iLO1Uuv7; spf=pass (imf07.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681833407; a=rsa-sha256; cv=none; b=Vx7tTKiIfoTkaZuyYy51845eVDm3IzwihGJEFD5OURUgzYseORWWD6m4Lvh9CzkJ0Xhm7N JYnJVm3o3KjOuC6xCj1Il3wkhJX8lEQfYizIH/qWDU5+0o/i7zoj1gyrBwxF8vr5vbX13S W8fcPhkpjfDZb0WzomyKqqXXOKfBulY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1681833406; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Juss3UIfNZnJDgajqfUY7HSWywG2tSbHHgh51Zf9/Ao=; b=iLO1Uuv7OwnIQ7hrBCbE7hDLaj/un6e1edq6u/gZ0TKP3MFMgqTp209U9H9bWbj34Km1c+ qpUobnrUVnN15hLwmSCCDE55BW3Wdwsl8Sk85EJto903plWkOkYy+hBctYKHkUVgwE0bwF Lp/V6Mlk5YSGkBhGVZdsk1CsWCbbBRc= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-609-VLOpX1SRMfijWK78u3tgog-1; Tue, 18 Apr 2023 11:56:43 -0400 X-MC-Unique: VLOpX1SRMfijWK78u3tgog-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-3f08ed462c0so42669225e9.1 for ; Tue, 18 Apr 2023 08:56:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681833402; x=1684425402; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :from:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Juss3UIfNZnJDgajqfUY7HSWywG2tSbHHgh51Zf9/Ao=; b=RhHAm+G5pFq9apR4S/HTJBCyUuyuB4V4tYn3gOiGbPBwtrjZIJzdvgC+M2uZvRp36t HuMy6xa6AXQKNqSjyUtDe1k2T9XaHlZmHFADl6bu7vNOuTuQl21DxmUoHXOmnpKsJNn8 M4HAtzUMIvntBbCjO8SXvcCfRs4mRKTFqiqkP11TJDxQpjWHnLPPrmAs/2EptJt1RG9w FtQAnp0FAVJC0u6t5OkJ5vjzQ6k3gryJxlT0p+/rM5ka3EcNkAv8pDsCktQjFIqhah4u BkDIZYRegbkcHBqH3+ufzT6IY7TZCwJRjkxmGfy/ykVfD69wsMZymyn1EPr7HVfvd2iy VxQg== X-Gm-Message-State: AAQBX9dMqBMW/RhFbPN7h7IRcCXUzzn3ak26vfXs0RHWg9zVPNpgK01u BlD1Clbto/ypulA9qbZcsRMoe4AiuvAJoirB6iU2S5tRUflXkxwE54KuEl7usO6yXhErtP/Uau8 yuGtNBzXOuqU= X-Received: by 2002:a5d:6781:0:b0:2fc:3596:7392 with SMTP id v1-20020a5d6781000000b002fc35967392mr2628934wru.24.1681833402338; Tue, 18 Apr 2023 08:56:42 -0700 (PDT) X-Google-Smtp-Source: AKy350YBuzvTWcCQhnHtly8+4rzkBkEULSOiTAtS5qyHVRgWX5InlOQK650XXEk9mTPSPN0p7akgTA== X-Received: by 2002:a5d:6781:0:b0:2fc:3596:7392 with SMTP id v1-20020a5d6781000000b002fc35967392mr2628920wru.24.1681833402021; Tue, 18 Apr 2023 08:56:42 -0700 (PDT) Received: from ?IPV6:2003:cb:c715:3f00:7545:deb6:f2f4:27ef? (p200300cbc7153f007545deb6f2f427ef.dip0.t-ipconnect.de. [2003:cb:c715:3f00:7545:deb6:f2f4:27ef]) by smtp.gmail.com with ESMTPSA id z2-20020adff1c2000000b002f900cfc262sm8099302wro.66.2023.04.18.08.56.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 Apr 2023 08:56:41 -0700 (PDT) Message-ID: <21bc9c1e-9941-9f51-0a38-85ae406ff2cd@redhat.com> Date: Tue, 18 Apr 2023 17:56:40 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v4 4/6] io_uring: rsrc: avoid use of vmas parameter in pin_user_pages() From: David Hildenbrand To: Lorenzo Stoakes , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton Cc: Matthew Wilcox , Jens Axboe , Pavel Begunkov , io-uring@vger.kernel.org References: <956f4fc2204f23e4c00e9602ded80cb4e7b5df9b.1681831798.git.lstoakes@gmail.com> <7fabe6ee-ba8f-6c48-c9f7-90982e2e258c@redhat.com> Organization: Red Hat In-Reply-To: <7fabe6ee-ba8f-6c48-c9f7-90982e2e258c@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 3B4F940020 X-Stat-Signature: q7gz47ujg3gf5f4w3akktb5ih6sdqwp3 X-HE-Tag: 1681833407-545012 X-HE-Meta: U2FsdGVkX18rUOyujpyNXo/f81TIP/yyxenOY2gTf4AJy7elqaEgNNUeH0dK8OuZ6sJJ1CBVkj434itYuY0O68WbFP30DTcIVWP77+K6Bi8xE98zJtAs0LtKKq5FgztMHtzW0M8xZ4/GGRaRwGbnKBTSQwAL/WQWHze2yPTwbBOApF63uXVovqFl+KS9IyaRAg65I87IkV3xeRuwwt6O80saoflNmNdUjQyCoWuh5fo3w9jaKvZfYK3d4tFEjXEGrQcZgXDhdSxPnF46TgivQK+m3ojQXtDHZteQzV0leNWWzAo17yvRhYVja3YUzjux4zHbDPqIs2luZDHPTEbSmh/ifmK6ToK8SNn2KQb9d5oOWPhUxq0TejFxdOImYTTztuFH6hxHJpN+R2O3jgj8nV0dHfTfR0pTcKghI+0q28bAV4SgFZX8MZRDaxGpHO3KN1Vg7rIr+Ej5QwZOmzcu9CVrjaygZKSjIWBens9Zy+IoQJbghvEgznd3c6EbdXSJ5qT9IektPIkRO9SdoN6iFJGukxa7Vlepb8x17M8mgJlYxpZcMrnF5YyQvldvub5Zynqz7pXwNRpxLeyLVbJETQxuxtM9WEtQFr+g5VHVIAzYq+ema7qBnriRUs7VS/4rXClqo26vk+vgs29FujnUk/3YCBVQUPvQo8u5efyyq/LLK0jyTmxBIq9N+rtP322hh19BDPJfB2g1kk9ik1eqZ3vujkLRVzs+wXeSaT9qNJjLdajaWkKmhT6py3smlND7t5/6RQr2dgEmX31OvIcj4mpw4Pk7GhlMuAieyb5VZlfsFa9v5iLiFA8d7hAR5IzmAt4yDxmmEynC1yZ+PmlcfC9VQ0gm6VGGfyV+70HZ9j2syaBok7PAZAzxwO9aCQWdxslFy6vDuXmDKEpuwRpEEkLHp4yhrwZOHXID6GngkyKR+7AZhVYZsLxQYGzfQwOU75blVV9D9ej7ej3Fbu4 D79KflO7 QwhUHtdIzC2GqFfyyioXvKDzDO+bIn9BHdr79A0RflTxrpuClw3i2p1JnXFmEczfJxuw31sDwHh2TWYxbi7vPHu9GWnnwMMqboexVaombhPoooG9YterTIp7EbTCNJoLYC/hlYref1cq/bZeQOhkj1rO/vdFq0BSamp5Y+oViXDKCNO3xPLgYBtNdS90mT2YNRdI5d70Z0X28S9zaf06vf1CDexUAr7y7nbHlxKgY1d5vzkIjLmqB3jKLGt1wnpdz6PXP4y9fZbgt1aOB1Z7+9OnRJvWI1noQPLZC+I/nQ/U0g2i24UoM5ZcG25WninBgG1MBuma6GKFKadPwT3cb/IRznj7RwZ23aAtmTiDYUzXFHTxbI82sy+tdUNrGygCTX94bLMJVdiiXqOCdGUUiYMIyycQt4HFnp+O3aZvJc74+quph+wa8xQSJNZ93oAmzEa9P79o3U7TOnv4o05K7cqZpap6Lm0szHnvFebZf6o0wnGQhQteNZAbMp1Ik94ohUaUNLyPanzEuSMQAT1btau+NK+HSHi4UCaDldCigpo+jas0vvCPGLSWtkRJ21FELz4Zyh1ifBYNmUbmA4AqrHKjrgYY+50LYshyk X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 18.04.23 17:55, David Hildenbrand wrote: > On 18.04.23 17:49, Lorenzo Stoakes wrote: >> We are shortly to remove pin_user_pages(), and instead perform the required >> VMA checks ourselves. In most cases there will be a single VMA so this >> should caues no undue impact on an already slow path. >> >> Doing this eliminates the one instance of vmas being used by >> pin_user_pages(). >> >> Suggested-by: Matthew Wilcox (Oracle) >> Signed-off-by: Lorenzo Stoakes >> --- >> io_uring/rsrc.c | 55 ++++++++++++++++++++++++++++--------------------- >> 1 file changed, 31 insertions(+), 24 deletions(-) >> >> diff --git a/io_uring/rsrc.c b/io_uring/rsrc.c >> index 7a43aed8e395..3a927df9d913 100644 >> --- a/io_uring/rsrc.c >> +++ b/io_uring/rsrc.c >> @@ -1138,12 +1138,37 @@ static int io_buffer_account_pin(struct io_ring_ctx *ctx, struct page **pages, >> return ret; >> } >> >> +static int check_vmas_locked(unsigned long addr, unsigned long len) > > TBH, the whole "_locked" suffix is a bit confusing. > > I was wondering why you'd want to check whether the VMAs are locked ... FWIW, "check_vmas_compatible_locked" might be better. But the "_locked" is still annoying. -- Thanks, David / dhildenb