From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F179C25B74 for ; Thu, 16 May 2024 04:43:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 315386B039D; Thu, 16 May 2024 00:43:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2A8D46B03A2; Thu, 16 May 2024 00:43:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 18D116B03A4; Thu, 16 May 2024 00:43:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id ED5C36B039D for ; Thu, 16 May 2024 00:43:35 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 60655A26E1 for ; Thu, 16 May 2024 04:43:35 +0000 (UTC) X-FDA: 82123015590.15.A837C2F Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by imf17.hostedemail.com (Postfix) with ESMTP id 9A0BD4000B for ; Thu, 16 May 2024 04:43:32 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=none; spf=pass (imf17.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715834613; a=rsa-sha256; cv=none; b=TQjHvhW5aE+fXHD/XUyvwIqJ9bBTaK68Mm0hWfoJlwyy1+LS6JLT6timJ9T9yQ9ToeuhGd +Z0MjWMgimXk7DZu3p3bj5/tVlVfAhjbs+R5A/5lk50fZ57yOiSWmb13nJ/O4iqEKILSKE XPRHfquZ1SoQhMHBkUKQVIEr+z13Sl0= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=none; spf=pass (imf17.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715834613; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TW5NMVS7TMEWrycAO7Wb/6V09KBkhEAzms6oLapyiHM=; b=pQLdn+ZbznUH9L2hhDsATHMGxp1XcpaseWXy7ipZgF8sB5ch2mBcfkIWRo8G2XLKwaUeGf A31p9jZmnXihB2Tr5DIit9hyZ8KqpsJvGkGHf0wOvMXt3BVFTIT5KJZCU1VQwu2c8Jb/bS PUJyE00B55PWRih6kvwfyzPI+1+gN/8= Received: from mail.maildlp.com (unknown [172.19.162.254]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4Vfy9x0cjfzcdyb; Thu, 16 May 2024 12:42:13 +0800 (CST) Received: from dggpemm100001.china.huawei.com (unknown [7.185.36.93]) by mail.maildlp.com (Postfix) with ESMTPS id BE4B3180070; Thu, 16 May 2024 12:43:27 +0800 (CST) Received: from [10.174.177.243] (10.174.177.243) by dggpemm100001.china.huawei.com (7.185.36.93) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Thu, 16 May 2024 12:43:27 +0800 Message-ID: <21b117a4-d869-436c-a939-cd48ba4e84f0@huawei.com> Date: Thu, 16 May 2024 12:43:26 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: refactor folio_undo_large_rmappable() Content-Language: en-US To: Lance Yang CC: , , , , , , References: <20240515064506.72253-1-wangkefeng.wang@huawei.com> <20240515065326.37970-1-ioworker0@gmail.com> From: Kefeng Wang In-Reply-To: <20240515065326.37970-1-ioworker0@gmail.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To dggpemm100001.china.huawei.com (7.185.36.93) X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 9A0BD4000B X-Stat-Signature: s1thwqrqi4gjhocysjf155ccou8h1ndh X-HE-Tag: 1715834612-411614 X-HE-Meta: U2FsdGVkX18VIKxJegjCMiqiNQLywgi1iHK1HmwZEsTn4V1SH8TyBg0gLYGK/6tHlNSVcvoJDDAOm6E+VcWvJCIUqet3GPvyqzmGPvH39WIQNyPI6K787YaGBOOjVbyi65fY992bIdQ7uW+beKRghdurB4yDN2/xHN/TK7kByJjCCdXNYcqMqShU6ymZsdk9RcsWnJH2H2Sw/b3N3q8aq3NO8yF0uDUynwUAUpcawAHKtAHwEhHO5JFjC6FdeYDpluqWm0e2XQoD1bJKD/8C6o4/uOi7l7nne6sEN1R/FTcYI+JkjpSbrjAGlDVsIlUa9OJjtrAH4LdaO9czbxwnKzeywvVUHjLIH5Idqen80pQO+9x2kBEV5TPmTBLKGZ5oTWQOJ6RgkfAZtZoiv+Mv0R6i/sCer7ePR2OcNLCvxBpa1DUZkG1ryF3aDixptImZO7orCWc+6mjTHGHSRQkfI6VrKJZLW6htkAsxoz5lnhQq+Wo8rVmig0/UoKbATzn8E7MKL1aY75EY9fVnS61UMCrs1rkRzCoqyi71A98yQJrXfUClsvdDE28xlZ71jEicfaXUbf5jR5ooLM5KsrknI2J6vZ+Uz+NOiarnXu9fcfi4VGG+iPbguizKJaMwMf1htO638825oi9u7qeH5tSo8j8wky3PIfmJ/MTH4j/ewANUbNN/Qnk4UH1j0CnTDqoQM50pARGINSt0DNTU8I3YkHTihUlwFGUI7AsvCoy1sVFgLNjlUf+s4bWewWe35GdEh9FqEM1GPbiGXlw8JckfgZY2H250se09LJfRRkK+seneSNUwg/oWGpoutGuI1ZiwPBYNqVarTI30vzEEY/AYKKRpyiY24rGabsTMwRwUnfge0AXwXAVpnHN3g2w2SuAsihj1RShLKhOjRKdUicia06tsoqv7aVl0w3pKglZct6BPB4mO+58S5YwkffT/b9cWb1Xg9/6Yh1YMy3KDpLt durY+oIw IxFTqx2ABlo0PCJC3CxDFSbJtnN4Peg3k8ETnapp19yKYp8/7qGqW6PNOTr/aVG+C/+RVXgcHKxsjG2f4PWEEZ93hqpSrU2ZUkKqo4penkjmQ0B+U/DXlLzHTi/X0Jof1y6BlRpLO11i5ws/RPQxq0ZDcbDgrv5ZFUsWMuowNorpKPT1YvM6CsNnxaqIT2IwJijV+lx5j8JIjLMovTqhvG7IULg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/5/15 14:53, Lance Yang wrote: > Hi Kefeng, > >> In addtion, move all the checks into headfile to save a function call >> for non-large-rmappable or empty deferred_list folio. > > s/addtion/addition > > And, IMO, 'headfile' looks a bit weird :) > s/headfile/header file Thanks, will fix them. > > Thanks, > Lance