linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Qian Cai <cai@lca.pw>
To: Rafael Aquini <aquini@redhat.com>
Cc: Linux-MM <linux-mm@kvack.org>,
	linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
	iamjoonsoo.kim@lge.com, rientjes@google.com, penberg@kernel.org,
	cl@linux.com
Subject: Re: [PATCH] mm: slub: add panic_on_error to the debug facilities
Date: Fri, 1 May 2020 17:29:19 -0400	[thread overview]
Message-ID: <21CF143C-B9D1-4D3F-A875-370924265593@lca.pw> (raw)
In-Reply-To: <20200501211540.71216-1-aquini@redhat.com>



> On May 1, 2020, at 5:15 PM, Rafael Aquini <aquini@redhat.com> wrote:
> 
> Sometimes it is desirable to override SLUB's debug facilities
> default behavior upon stumbling on a cache or object error
> and just stop the execution in order to grab a coredump, at
> the error-spotting time, instead of trying to fix the issue
> and report in an attempt to keep the system rolling.
> 
> This patch introduces a new debug flag SLAB_PANIC_ON_ERROR,
> along with its related SLUB-machinery, in order to extend
> current slub_debug facilites and provide the aforementioned
> behavior override.

Instead of adding those things everywhere. How about adding something like panic_on_taint? Then, you could write specific taint flags you are interested in to that file because slab_bug() will taint it TAINT_BAD_PAGE.

  reply	other threads:[~2020-05-01 21:29 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-01 21:15 Rafael Aquini
2020-05-01 21:29 ` Qian Cai [this message]
2020-05-01 21:54   ` Rafael Aquini
2020-05-01 22:00     ` Qian Cai
2020-05-01 23:17     ` Qian Cai
2020-05-04  2:36       ` Rafael Aquini
2020-05-01 21:37 ` Andrew Morton
2020-05-01 21:41   ` Rafael Aquini
2020-05-02 23:16 ` Christopher Lameter
2020-05-04  2:51   ` Rafael Aquini
2020-05-08  3:06     ` Christopher Lameter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=21CF143C-B9D1-4D3F-A875-370924265593@lca.pw \
    --to=cai@lca.pw \
    --cc=akpm@linux-foundation.org \
    --cc=aquini@redhat.com \
    --cc=cl@linux.com \
    --cc=iamjoonsoo.kim@lge.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=penberg@kernel.org \
    --cc=rientjes@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox