From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 287D7C433F5 for ; Mon, 14 Mar 2022 02:59:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 870696B0071; Sun, 13 Mar 2022 22:59:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 81F426B0072; Sun, 13 Mar 2022 22:59:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7354C8D0001; Sun, 13 Mar 2022 22:59:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.26]) by kanga.kvack.org (Postfix) with ESMTP id 655266B0071 for ; Sun, 13 Mar 2022 22:59:47 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 3303320479 for ; Mon, 14 Mar 2022 02:59:47 +0000 (UTC) X-FDA: 79241486814.07.8448A34 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf16.hostedemail.com (Postfix) with ESMTP id 03AFB18001D for ; Mon, 14 Mar 2022 02:59:45 +0000 (UTC) Received: from canpemm500002.china.huawei.com (unknown [172.30.72.53]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4KH1SS1dd6zfYsV; Mon, 14 Mar 2022 10:58:16 +0800 (CST) Received: from [10.174.177.76] (10.174.177.76) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Mon, 14 Mar 2022 10:59:41 +0800 Subject: Re: [PATCH v2 2/3] mm/memory-failure.c: avoid calling invalidate_inode_page() with unexpected pages To: =?UTF-8?B?SE9SSUdVQ0hJIE5BT1lBKOWggOWPoyDnm7TkuZ8p?= CC: "akpm@linux-foundation.org" , "tony.luck@intel.com" , "bp@alien8.de" , "mike.kravetz@oracle.com" , "shy828301@gmail.com" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , "linux-edac@vger.kernel.org" References: <20220312074613.4798-1-linmiaohe@huawei.com> <20220312074613.4798-3-linmiaohe@huawei.com> <20220313234157.GB3010057@hori.linux.bs1.fc.nec.co.jp> <8aa7cdd9-8104-2fea-879d-61519f6489d1@huawei.com> <20220314025034.GA3061370@hori.linux.bs1.fc.nec.co.jp> From: Miaohe Lin Message-ID: <219aeec6-5ff6-5101-8192-13b9f761e7c9@huawei.com> Date: Mon, 14 Mar 2022 10:59:40 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20220314025034.GA3061370@hori.linux.bs1.fc.nec.co.jp> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.177.76] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To canpemm500002.china.huawei.com (7.192.104.244) X-CFilter-Loop: Reflected X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 03AFB18001D X-Stat-Signature: qq84hza7yhe8nrfzg1jqi84he9x8engm Authentication-Results: imf16.hostedemail.com; dkim=none; spf=pass (imf16.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com X-HE-Tag: 1647226785-470142 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022/3/14 10:50, HORIGUCHI NAOYA(堀口 直也) wrote: > On Mon, Mar 14, 2022 at 09:58:49AM +0800, Miaohe Lin wrote: >> On 2022/3/14 7:41, HORIGUCHI NAOYA(堀口 直也) wrote: >>> On Sat, Mar 12, 2022 at 03:46:12PM +0800, Miaohe Lin wrote: >>>> Since commit 042c4f32323b ("mm/truncate: Inline invalidate_complete_page() >>> >>> This commit ID does not exist in mainline (or in the latest mmotm?), >>> so you can't use it in patch description. Could you update this part? >>> >> >> This commit is in the mmotm but not in mainline yet: >> >> commit 042c4f32323beb28146c658202d3e69899e4f245 >> Author: Matthew Wilcox (Oracle) >> Date: Sat Feb 12 15:27:42 2022 -0500 >> >> mm/truncate: Inline invalidate_complete_page() into its one caller >> >> invalidate_inode_page() is the only caller of invalidate_complete_page() >> and inlining it reveals that the first check is unnecessary (because we >> hold the page locked, and we just retrieved the mapping from the page). >> Actually, it does make a difference, in that tail pages no longer fail >> at this check, so it's now possible to remove a tail page from a mapping. >> >> Signed-off-by: Matthew Wilcox (Oracle) >> Reviewed-by: John Hubbard >> Reviewed-by: Christoph Hellwig >> >> Am I "not" supposed to use this commit id as it's not "stable" now? > > No, it's not stable yet. In whatever way you get the above commit (I guess > you get it from https://github.com/hnaz/linux-mm), all acked mm-related > patches are sent to Linus by Andrew *by email*, so the eventual commit IDs > should be determined when they are applied to mainline. > Many thanks for your explanation. (I get this commit id from linux-next tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git) So I should remember always to get the commit id from mainline. Thanks again. :) > Thanks, > Naoya Horiguchi >