From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF38DC3ABC3 for ; Tue, 13 May 2025 09:06:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 922946B000A; Tue, 13 May 2025 05:06:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8A9FC6B0083; Tue, 13 May 2025 05:06:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6D6F06B0085; Tue, 13 May 2025 05:06:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 4B74E6B000A for ; Tue, 13 May 2025 05:06:20 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 6EDD31202AF for ; Tue, 13 May 2025 09:06:20 +0000 (UTC) X-FDA: 83437303320.23.5AA6DE9 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf29.hostedemail.com (Postfix) with ESMTP id E6E05120004 for ; Tue, 13 May 2025 09:06:17 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="Y3l19tV/"; spf=pass (imf29.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747127178; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=q9jxOCEACQ9TguSqvzkS3Gt7WQBGW3OxfkGW2LURiUg=; b=JvSzKvQyceuy1uCeneuEoe5z5ZUuBtH+dxiDbPafr8UDzdR6zRLkdB4vaFJj5A4eQ/KM/u qkKyQvv8HMed8VfPdivJ2PeTttWVou0uTTS58mjk03bM+eWwaC3ILQqso31vXhcsv4GTuQ X3ED/0O7bZEy0HTLR6WZbC2wha/v4CQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747127178; a=rsa-sha256; cv=none; b=0+xH22FmqCQVNyqY7BeaGlZB+ziQEzctjjDZ+lLrvdGEbE/t9uQz4OIGTXVCeMXaV59RZ9 5MImzv/md9B8AM7cLcvBFVTLEBleD4Tg6raWnkUCxLI2aGW8q4RlsFXrn9RYklMcThiUjv mtLAsJAIiVgpbzUyojXEPOeAeGzqk48= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="Y3l19tV/"; spf=pass (imf29.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1747127177; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=q9jxOCEACQ9TguSqvzkS3Gt7WQBGW3OxfkGW2LURiUg=; b=Y3l19tV/MVPtvuejp43Dwhg+pUR96xHbR9HNKxVB+G0nEDhU+uiiCcP/R6y0p56jpJ4j7p oUgKaWKCcwKxQYHmUlQYwfsr3dbGZwX8yiBladNhGv4q2HchDpEoZkbFmIWBqpFtr7/xa4 xlslHCtoWto7TQPzWqWfKn6nAFZvc/g= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-630-2trJ5xaVMqORsJaw2mBVOw-1; Tue, 13 May 2025 05:06:16 -0400 X-MC-Unique: 2trJ5xaVMqORsJaw2mBVOw-1 X-Mimecast-MFC-AGG-ID: 2trJ5xaVMqORsJaw2mBVOw_1747127175 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-43ea256f039so39636645e9.0 for ; Tue, 13 May 2025 02:06:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747127175; x=1747731975; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=q9jxOCEACQ9TguSqvzkS3Gt7WQBGW3OxfkGW2LURiUg=; b=dP7ac7V86DtJhlEf10RVdkqROYApbu8KUKEZhBj6mdxnbgQz+n1UqvLblcHRTC0VJo lirQQsWq/dA7Qjo4vYnfgw7TNZDfdRQfDtfYOm8INvL/0rF0jKH2jQ+yZea2Rt0gRfn7 v6XVPH7Tbl/UvK9y4+TLpyLOmvrqUX8LZxlGaofvE9qAM/1HCEpi0bWSWnj0nfV17EZc TUXRSfD3tIs2QJQbCyvZ3oF8VNy7s7GHSFaHnS3veS6XcEZC5KodvYWNtZOwQEReHc0u 6vcFjJXBz4fMJ37q2QBNY4y5iwaj0+cexU9tWRXLbOWQ9lRL6d7JJb3xHFe/4zPr6zXr +Hqw== X-Forwarded-Encrypted: i=1; AJvYcCVZkpQ0tLXwzLoegdMTaAIx4aXT62wgOBq+0whF3laEBZHtj+Wwep8PggzyuNi9A+J5BAGlpj2DTw==@kvack.org X-Gm-Message-State: AOJu0Yxh0BhIhKd3HbnrqAItA9XKgV3RvFNoAUPmvRqm76JYA6aMVuKy nate5BC0HLyLJzn6YFY0nf/p8y+krYOK3oe+DpggUkfzg1U8Kwsr0FLt+gP/wRZA78iPperxRDX 2HTgognzbZpwAH4B+Wd486EE3Ut81g32K15I0TglZsLZN8ZYv X-Gm-Gg: ASbGnctRUhRr8OyV7Apjm90ndkdln45mtuMlVXlJax3X5cCP8WK0xjo4326Odc8yL1q IvvhHO6J29FjryM28ZSuBxuKc+syWxtvAPHhNVEHbje2UnXuSOT1zcH910m5TQGOv9M5Iu48Z08 dten4m1mr9xr8r8Z3cectTIgBF28fLmX7Q1oLMBN4CPmwLHDe+NTwIbOmxsMdzAZrPp+QkYe+ur f3gkZ0Ow6yieKrar7nrbQ87Es5+9ZlTM7OBq10uXVpR1mWbawGZILBcnwxHbifGTmMbWvWnXkXb UbZO1WY2iuVbw01D4K8jXajhpLQ4dNDAYVqs5+v+ddWWXdgGfo2qbgRY9HAUjQtCEHp+RQN0qb9 sBuD6CvNI3gH7A+QnslwbiEWt1TAbC9II56TFoRw= X-Received: by 2002:a05:6000:184b:b0:3a0:90c6:46df with SMTP id ffacd0b85a97d-3a1f64ae085mr11924392f8f.48.1747127174854; Tue, 13 May 2025 02:06:14 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFczOcMfR6BGu8q55UlQ2KyVNNVnSREngFyFtwsspWxPS6JUuFMiq9K5/NPrcvYrdGyfp5UgA== X-Received: by 2002:a05:6000:184b:b0:3a0:90c6:46df with SMTP id ffacd0b85a97d-3a1f64ae085mr11924338f8f.48.1747127174488; Tue, 13 May 2025 02:06:14 -0700 (PDT) Received: from ?IPV6:2003:d8:2f4d:1a00:4fdf:53e2:1a36:ba34? (p200300d82f4d1a004fdf53e21a36ba34.dip0.t-ipconnect.de. [2003:d8:2f4d:1a00:4fdf:53e2:1a36:ba34]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a1f58f2f58sm15131406f8f.49.2025.05.13.02.06.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 13 May 2025 02:06:14 -0700 (PDT) Message-ID: <219ad4d8-c191-4c1a-a835-e798ab58374f@redhat.com> Date: Tue, 13 May 2025 11:06:12 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 02/11] mm: convert track_pfn_insert() to pfnmap_setup_cachemode*() To: Lorenzo Stoakes Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-trace-kernel@vger.kernel.org, Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Simona Vetter , Andrew Morton , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , "Liam R. Howlett" , Vlastimil Babka , Jann Horn , Pedro Falcato , Peter Xu , Ingo Molnar References: <20250512123424.637989-1-david@redhat.com> <20250512123424.637989-3-david@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: tsgigwYkfUYfciQCbVCO7GYRO-SIrYKfXvnEYSSfbgA_1747127175 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: btnjm95nb799p8i65psjfepyj4ghdxoa X-Rspamd-Queue-Id: E6E05120004 X-Rspam-User: X-Rspamd-Server: rspam02 X-HE-Tag: 1747127177-29530 X-HE-Meta: U2FsdGVkX1/Abd7WrPdPdgOc/uGokHt8q3J42f4WO3wInmKgcR2d4dgZejzpT3EbqbmfQmBBeSY0b3STsvsDGyOsyl+TB/57LSb9aX6RltxYrQy91tvPkk92RA4xbu+sxZMM+PVqxN17AEpDaczJHmEHUhTqBz+w4W/xK3qvOf4EmJjUGNY0e2bmiAqy+NR0vT1Kr+qewqcdAvIeN0P9X8k3YbagEDZBxn1pWr42nYv8eNvKRfrxcyPkExWpv24KcYuqsmH45c138SWqRz+dImzm+RouoR8D53NKrc4zNVRzBVmbskZM3YNVmcnm8JkWPWFFB4qKviLTDp+cSo9AkEVccyQehl1fDzpu04AkiEOB3q7i63EwvLLQGU1W7aM5Y3JRNA69wa6rrur1FCcctaGisr10aPjPfnwy3UhNxkDy3yR9ffslLBKpWbPMntko8l8CVyc+cuqOjv65n2AEtFCORbSfEPgbCcOF1th5+qiz/ljE9aTvbLMEHe4ZBboP6r4eepMXyfmy1JZPv18sbfCc4EZZc9R6HFaFFwYmge5Yd1I/+sUpBeAhNXFGFPoysYlAK49XP3qmA/gBr/Jdf1pLF0xLQMSo9KKgEPrkZUTR9MyQEWqL6oXF/e1DROIE6zV36WWPQJ+GnwE2pB+hq0b9BifjIUiUOFWv1enMjPPursj9QU0jJxgmJQRpI15/bYL7UHBeLh9i34dGJGEHahxQfrB8FeASp/6nIGdojudjHCIKcmvQ7Md3kHbFqAZj2bF0qoKiM4+GsPTMYZ2J/QZTAM/PJcqqmimLQl4FBLOu0vwg2bUYb297UA+sPorWjM/ulcdzn3rCY1onCebFOLxAFdZE47e39VFC57GdR2ZKC6KptzPu1wKW185B6rtDLwNvXdY+OFGqMiCIWPg7likw1t5ZxqxcfNX8GsyCR9hZLP8pEG0j7T+z4PPjnUT+uAKW7HWBtMLGb/uJ3jU 7ru8r9Vo YeyzBVAzCKuCQI85bUbY46lb0gGV/CLeTrLyd8jGLTqF+Ckn0BGvDwFL7Rb9QSZ3a+wKuQbA121ITcfWkqKkzu/7ANWCXcHVIJ8vPRIhsS9g1Xq7IEMtEs37uZu7Soamf7Kdav3mUkarWdkniwjIxdC/5GZZ4LuRDp5sf4QFoiSFJO39pNOnWvSwu7wBAIyfQtDeJ8kALMb696QDmGQUFPE2QCWJNkskzo3bNegfIeFr1qmnwEAlFMzdqvTpAtueeZrS3sWvYgEQnCPO3OIUodJ6V7axQvGs7wD5AlAoKVee9rh2o0o5GEH0V105hm17f2wQYG3ME0sCAszoeiaiHqy8xKgBRZ7FqH7mwXEmaegJ7ulCm9NcUAtfcGZx7LKh9K6CGTycg2uu2omwpnWeXkBgyYq+jVv78WNXqc/5ulmVDHv45FxDNcmHd7Jmc/DwP3SxCAB2ua1DmONHgkXDDGaJ+R58KNVlgT+mKTitk9Om9wo8pi4zJS8U+59zm6IOcH89U+Qm4EXanUEigh8st2xxqIg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 12.05.25 17:43, Lorenzo Stoakes wrote: > On Mon, May 12, 2025 at 02:34:15PM +0200, David Hildenbrand wrote: >> ... by factoring it out from track_pfn_remap() into >> pfnmap_setup_cachemode() and provide pfnmap_setup_cachemode_pfn() as >> a replacement for track_pfn_insert(). >> >> For PMDs/PUDs, we keep checking a single pfn only. Add some documentation, >> and also document why it is valid to not check the whole pfn range. >> >> We'll reuse pfnmap_setup_cachemode() from core MM next. >> >> Acked-by: Ingo Molnar # x86 bits >> Signed-off-by: David Hildenbrand > > I've gone through carefully and checked and this looks good to me :) Thanks a bunch! -- Cheers, David / dhildenb