From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0073AC71136 for ; Tue, 17 Jun 2025 13:58:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6A3FC6B0089; Tue, 17 Jun 2025 09:58:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 654826B008A; Tue, 17 Jun 2025 09:58:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 51C866B0092; Tue, 17 Jun 2025 09:58:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 3F9826B0089 for ; Tue, 17 Jun 2025 09:58:38 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id C18061402BA for ; Tue, 17 Jun 2025 13:58:37 +0000 (UTC) X-FDA: 83565047874.07.55957E2 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf29.hostedemail.com (Postfix) with ESMTP id 4357012000F for ; Tue, 17 Jun 2025 13:58:35 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=QjPKeKCn; spf=pass (imf29.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750168715; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UCoWasVGpebT4pYyaDzSoFsRBl+kSgrz9fApdkK/1Sk=; b=OBsB011xVAj9JH5o+Fqh7M7+xRAyqx2xDgFssHwvgU6H7d6shYcvFMh2BS8RqVjl7wuv8o 1+0GFIUQAKKxiNrbcrx51NdU23riKfL0cv30JmwXmpVHI2Tl8GIvK9xyYLgZan7nW24kHw rrLS6mO867rldTEg5ZffRKJ9q7b4MMA= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=QjPKeKCn; spf=pass (imf29.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750168715; a=rsa-sha256; cv=none; b=ml6Y1FJwuBgtzWRSqAYN8jCHRkXiokZ8lG5lUV6P+ef95G12JGXgnt/M5pOxbJUOJWH6TQ 9PNY9CnwDltk5c9S5ZXZm6EWfUszQo8iwMo8KXmgib2Ev4vOKngaErFmHrV0xf/cjOHZAk iTr0qLqcO3Bs4rTGxlJ7ZARrsSajFQo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1750168714; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=UCoWasVGpebT4pYyaDzSoFsRBl+kSgrz9fApdkK/1Sk=; b=QjPKeKCn9PdQzDOzTok3DVq869a7vSiOVq0R9IoTMkgAUN6IxN+3w/yfSotlvztjni11/f emclADvtmza9S+QYVwA2FWfuNor+aY8JNJYTZnBVHc0pQG8I2gf8J8Rte8Yfffji3+iw4n RapQ+F6hNT5QrYF+9NLIWPTMsdxH63I= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-138-HgSeR3V4NGCO7WXaAen5Zg-1; Tue, 17 Jun 2025 09:58:31 -0400 X-MC-Unique: HgSeR3V4NGCO7WXaAen5Zg-1 X-Mimecast-MFC-AGG-ID: HgSeR3V4NGCO7WXaAen5Zg_1750168710 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-3a4eeed54c2so3639619f8f.3 for ; Tue, 17 Jun 2025 06:58:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750168710; x=1750773510; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=UCoWasVGpebT4pYyaDzSoFsRBl+kSgrz9fApdkK/1Sk=; b=N/Vg+VvdaZtW9lYSY1D5ij1OVM0TFQWbn7ldQ/SA0T199HC71io30NXheW132ryK0k PBreskGwguCMK9C/nfBrUmG+yxrdrVWxPfawG4HNBK7kIqziI+qpkPcpNYetR6tL6lOe U+oYhB+2XMYXcfr6pm9TLIZt23RSfrAmDgfnWCfmFKUJmNj9Y+qG9CzE9BoXYE2B6ZnN LVArTh1oDUsomb4DcyudFbj4CANGs5FOjzPrtczrKFSDbymWkdeY39rItEGOwk4x8RLe uegrOh/bmiotyq5NV0hY5xvrvWBar0200YZLGuG0BwlKLFStDHMWBu6pIOJq74z9ngBH HFgw== X-Forwarded-Encrypted: i=1; AJvYcCXYf3P0LzABVGTBbsXQN1mTHG0mGmtwbfyApvItY1uinnFvo1NM9P+5g06wiLjXHuwJnyXRNGMTTw==@kvack.org X-Gm-Message-State: AOJu0YwlNEU9U/oXqkMQabC/hHFAgUtEZw0tsILnBCzzZQkJhR0CZK58 S6hdonxXHCmMlEyeSCpAmtBjYU/UvzOWcJfY019ZK/SOrqoSTbPnbavlRHmmmk91W8Rp+lWHQ0h gdk6rmqglglD9ER4DK+2M8w0TagQ5j+RK25DutSjHPja/PQq3hTJK X-Gm-Gg: ASbGncuPmWp1lZcvGX84FWEjjDk/UAAAYIhzhD1YmdNM9I+eE7guntNIzkRWWcDBtMI DDc7t8tCCoNF8nHNY45wLnyNY/CT5CBbMqCDLPGr7020u0KrZsnMcPfu172KLxk8FUhB2ReWy/D XwYIFXixrMyhM6KGjYnnMyNG7XBdH9Jr9MN2mWx1Pm0gTTOnSqWueQ1614BQ7kslD9jJcwwfPTf 1CJ8DTznZusBfkQxPa44CL81NAtATlfODsgw12qJvGkl51sSa8kYkNC6n+xDRhf+LsaFa0Y4aSg gYPHrtKpgiEk+tb67wDBk8St+BtbPVpY3Py5YJuvT7aVc5AlxAevXDfgZJoFsER6gCX8XOQE+NY AWT5+3up5oioTajjy9UThxgHMTk1vLw/dOXtJIufBLsn2b8s= X-Received: by 2002:a05:6000:1449:b0:3a4:ed62:c7e1 with SMTP id ffacd0b85a97d-3a572367734mr9722383f8f.12.1750168710048; Tue, 17 Jun 2025 06:58:30 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF9tCgVXCdg2h3H99E2uuyROs/cSpd9476VBWtxM8o5GIJvE74IbqrY9BHmfyX4S8yOl5tz4g== X-Received: by 2002:a05:6000:1449:b0:3a4:ed62:c7e1 with SMTP id ffacd0b85a97d-3a572367734mr9722365f8f.12.1750168709634; Tue, 17 Jun 2025 06:58:29 -0700 (PDT) Received: from ?IPV6:2003:d8:2f31:700:3851:c66a:b6b9:3490? (p200300d82f3107003851c66ab6b93490.dip0.t-ipconnect.de. [2003:d8:2f31:700:3851:c66a:b6b9:3490]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a568a734b5sm14399629f8f.33.2025.06.17.06.58.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Jun 2025 06:58:29 -0700 (PDT) Message-ID: <21958961-259f-4520-ae60-e234383945d7@redhat.com> Date: Tue, 17 Jun 2025 15:58:28 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 2/3] gup: introduce unpin_user_folio_dirty_locked() From: David Hildenbrand To: Jason Gunthorpe , lizhe.67@bytedance.com Cc: alex.williamson@redhat.com, akpm@linux-foundation.org, peterx@redhat.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <20250617041821.85555-1-lizhe.67@bytedance.com> <20250617041821.85555-3-lizhe.67@bytedance.com> <20250617134251.GA1376515@ziepe.ca> <460e16a0-c8d9-493a-b54f-2c793c969eb1@redhat.com> Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <460e16a0-c8d9-493a-b54f-2c793c969eb1@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: md9g1fTf7vVyw5U5xqDzN1zrz7gbSLC3jSrdG3Z1HIo_1750168710 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 4357012000F X-Stat-Signature: hsyoddg7rhx1ekshufksum6ic4783o44 X-HE-Tag: 1750168715-137860 X-HE-Meta: U2FsdGVkX1+2WLDDofIvUWOYO15Jsda4GvDSg8lESWDBoiC6qxXuhXZOsvNRoATR9iFYudYjiBezoEioZmdeXrcKqYbi5x6J7cnrRrNPLKEur/0ZHo9kdH+B5YpMk6snWWZ0TGZnAaYai+U8vQTJpFPslhkhtou/J74tRDSGxjcCayiZPrDdEIyJNro/uEnbSRdnADDa95SbgpJ/Ncq8JmwXZzfuD7nq/XqfGvn4HZwKI7SwJBhAXmC5sO9j6qrJnPZdf9oAc+P0N96C0RjZK1fZlX2FG0DN3+udlFbQz5ZinLbKES8sIe9guyQPYVj24hilnDMzGDiYeVOCayF/MWJZTWfsAefq1N6sZXUNs7VC4dE4RobswKZ7rhHdV4uHg+E5sHsWEUzYRxlq/aZmXujA6mXDgRTuSwYzR5CnMUsYS1wyxO+N3dJyyivSX+1KaQjJYUjlkVBZb0oEkjWnknTrT1yaHWUuizDjgmbBIuu6cMfAgUmfsVRko29jhEG3AgkCLq7246iFE6CgZRSFFEVPn7bz05LoqprC/w0lyGWq4GqgcJqGRWvd2oDRCEiS+YfrJPCNmJNhRjWAdPNiYZMIyAUC1SwM3AaMjel1EtIuB5hp9XNIjtFnumTK/sxlBHwZtiT274mdnxAMzULTohF17xONTg5W8826uiB9YgEXI7+8zmtHQMagCambCMVa1ceU2mlHY+Z/+XhjLpeEetZnTKf4/ED73S6Owh0nY7uZNo4LLXcRZrhDMV5rROUf4aakzKrwEhShHAQG+8tktEwccIzNls8ko6CPJuy/OtBXjyvdskH8/5cxqryovS56Cw5VBgrmllAKxg197QO4FXjgu7J8KzN7SapO5O1wPVdTe22xl3Qq/xPU6HgvpHwUri+EkdQXCrk7c73VfRazjHzoDVQy9OL6RCkNZRDm4ZTxS4gdH2gWW2/X8M7ZXn8msPWdSfqJcq62Y+Kt6Ps 4i8TgmTw p7IIKtDRRjvwJRMgHg1KWlJGdzk/nVHdhPlVcPS96Br7jJzuLH0OSHIQVW0mNMZf2U15yPwONmU/9iQtXvMevJNl0Lr6OU4hp9ywrSDsEG+mC9KGvgZOmPHW6wA33HF+UrV42r9KcGsxnWff4hRlpNUfuozTjTJxxtJbMiBK/iSqVlVBgBIY8lGydi2HrVgBxVSr/XaanMzVrpgFPDnjtILhu8yMAX3mTlqhl7CwUBM5CtsIoYBPwFWukFa4hwYlYsLtn25g6vq3AhT76+vgabvv3IQ4Y2YSTT6m5cmLtRxGlD2ZDmOmn09UlRr2Pj9j08u5Wkg2anZEDjAS70LVqhGmY/cnb0TfERzLK/VvbwgO0f1IWAROJixOI8vTyXzTu58astezMhhH1jKzLx4hXQk+R0QXtCKmW5Ia8sbidGGrEr+RgNPCXDk1c0q84KfOprRXDqhEEal/bX3OdUyO7vB+zGypqUaoxDL+h X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 17.06.25 15:45, David Hildenbrand wrote: > On 17.06.25 15:42, Jason Gunthorpe wrote: >> On Tue, Jun 17, 2025 at 12:18:20PM +0800, lizhe.67@bytedance.com wrote: >> >>> @@ -360,12 +360,7 @@ void unpin_user_page_range_dirty_lock(struct page *page, unsigned long npages, >>> >>> for (i = 0; i < npages; i += nr) { >>> folio = gup_folio_range_next(page, npages, i, &nr); >>> - if (make_dirty && !folio_test_dirty(folio)) { >>> - folio_lock(folio); >>> - folio_mark_dirty(folio); >>> - folio_unlock(folio); >>> - } >>> - gup_put_folio(folio, nr, FOLL_PIN); >>> + unpin_user_folio_dirty_locked(folio, nr, make_dirty); >>> } >> >> I don't think we should call an exported function here - this is a >> fast path for rdma and iommfd, I don't want to see it degrade to save >> three duplicated lines :\ > > Any way to quantify? In theory, the compiler could still optimize this > within the same file, no? Looking at the compiler output, I think the compile is doing exactly that. Unless my obdjump -D -S analysis skills are seriously degraded :) -- Cheers, David / dhildenb