From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9201EB64D9 for ; Thu, 6 Jul 2023 09:19:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 663AD8D0002; Thu, 6 Jul 2023 05:19:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5EBF28D0001; Thu, 6 Jul 2023 05:19:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 466B88D0002; Thu, 6 Jul 2023 05:19:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 389AF8D0001 for ; Thu, 6 Jul 2023 05:19:46 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id DC6DC16054E for ; Thu, 6 Jul 2023 09:19:45 +0000 (UTC) X-FDA: 80980639530.09.F84DD74 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf18.hostedemail.com (Postfix) with ESMTP id 8CB4C1C0005 for ; Thu, 6 Jul 2023 09:19:43 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="epjPAH6/"; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf18.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688635183; a=rsa-sha256; cv=none; b=BQP7azMsQYG2YXtyz6gwA3CKWKU7kkDL2KdxeSGB8X34GfeI/wzvxQbrzvZTHWe/yhl6dk o4Zcr8VK+XS+jGEgozfbo2XeClFgGMgvdYTPqkWvj/TvB3bfXp4G1jQRXmqyczUfWEr0gu HZ9BWwK1N8e4p+Lh26Dt6PIlJtNfe+M= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="epjPAH6/"; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf18.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688635183; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=AEvYguDfY+Mp4KrdEEXfAOL6aMrfvU4QoTMKpCYd59A=; b=xGFyUhbh3d+zbtsGdVj5BQu75O33rcNvM3UEUq09Fcf78eyrPIltGal96JlO/WFeKCHhmX cla8xvCLba4kBVed+DyLzAA94BHV8rOBZ8NWssom9dQ8AymkqjEi6XfnfXfAVgLReeLpCT GIcsYfRt5ANJwdwRI3fAO/jrkThP+6w= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1688635182; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AEvYguDfY+Mp4KrdEEXfAOL6aMrfvU4QoTMKpCYd59A=; b=epjPAH6/Q2rSxr6WKkX/XaaKlD2wbFyBZtNdDayCMLZMgtw1GnTzsYihxuFUdzigqBX/KF GSv5XS8/YPoOLot9JaJNq7J/s38nrWpK5evpC5GFF0yZyAVqyWnRJidcQd6MQNmRCfV4BE SxvyRwkbqWrBEow8Qi0n9NU2+O8R97M= Received: from mail-lf1-f70.google.com (mail-lf1-f70.google.com [209.85.167.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-558-NYy98pDBMnSMojrT0J532A-1; Thu, 06 Jul 2023 05:19:39 -0400 X-MC-Unique: NYy98pDBMnSMojrT0J532A-1 Received: by mail-lf1-f70.google.com with SMTP id 2adb3069b0e04-4fb913e8cddso232817e87.0 for ; Thu, 06 Jul 2023 02:19:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688635177; x=1691227177; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=AEvYguDfY+Mp4KrdEEXfAOL6aMrfvU4QoTMKpCYd59A=; b=h+8nu+YCzQvn3hThHfcFe367jVjDfHDh+D8UkODogstyYEsLpDviJPWy+4vu4LeVuA XH4XocAfYIyc1UoOUYrHlqR60w5lz+0+lShHALmmVD53NVy4AZgxvfSFRTv/xGL2vDSZ MnwpdrwuWA/XdfyR+R2JqEIm3COl7iP+SsihEjGxqLBrcFCccH9jGn+6plvosmYNc66W 1RwSDeRrVbyKM3NxFR05hhGwNRk/Pw9+XQOsSp2SuALdV+ux6vUGNIi0k6w3o39SYVuD noC7dRXpx8rESP7PJlPIdLFXUOPcCIlz2N1XmyESW2cc/dZFfjeURMxTQ1NjIi/hOdgl /ocA== X-Gm-Message-State: ABy/qLa2YPugo+mfkVoDPL6rZ42pu80D/Z1ZuKTRd3M9exvTzL3Gy/7s NSN2ca1HBOYkvVyb0hTclzL6/7vwcqQ0ItEv6+XaOF9Tc3fb/WSiLECgnBaFY7613cRJnYhv1RA Hh3CF8UI+AMg= X-Received: by 2002:a05:6512:524:b0:4fb:8585:eefe with SMTP id o4-20020a056512052400b004fb8585eefemr944775lfc.57.1688635177629; Thu, 06 Jul 2023 02:19:37 -0700 (PDT) X-Google-Smtp-Source: APBJJlFqMeIF2cMZUQ7fAShjCf8Z+1xgC8NcamfV8klHi0RWMAYvGphlkhDcZJEKJeQJaT+GA4Vy4Q== X-Received: by 2002:a05:6512:524:b0:4fb:8585:eefe with SMTP id o4-20020a056512052400b004fb8585eefemr944764lfc.57.1688635177303; Thu, 06 Jul 2023 02:19:37 -0700 (PDT) Received: from ?IPV6:2a09:80c0:192:0:5dac:bf3d:c41:c3e7? ([2a09:80c0:192:0:5dac:bf3d:c41:c3e7]) by smtp.gmail.com with ESMTPSA id r13-20020a05600c458d00b003fa9a00d74csm5352253wmo.3.2023.07.06.02.19.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 06 Jul 2023 02:19:36 -0700 (PDT) Message-ID: <2190efc4-0cfe-d636-6254-60bb39dd02d3@redhat.com> Date: Thu, 6 Jul 2023 11:19:36 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v2 2/5] mm/hotplug: Allow architecture override for memmap on memory feature To: "Aneesh Kumar K.V" , linux-mm@kvack.org, akpm@linux-foundation.org, mpe@ellerman.id.au, linuxppc-dev@lists.ozlabs.org, npiggin@gmail.com, christophe.leroy@csgroup.eu Cc: Oscar Salvador , Michal Hocko , Vishal Verma References: <20230706085041.826340-1-aneesh.kumar@linux.ibm.com> <20230706085041.826340-3-aneesh.kumar@linux.ibm.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230706085041.826340-3-aneesh.kumar@linux.ibm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 8CB4C1C0005 X-Stat-Signature: icwx38azz8c4pbhyj95ubcg1f8r5qxxu X-HE-Tag: 1688635183-871424 X-HE-Meta: U2FsdGVkX1+JUiybS1tCc2ZxlTtL2JTp5p+1ZplOd1dp6d2fTheP5RPcs2e4NlJ+wrnPw4uVmT9ewG66ncKb3MTu/ZKHNQZHZcX86TqVatcE7wtBF28zhlShcM/CgvT/iFE7fKeVJQ94Tq+4KihVpHPRuZvRLNRH/0QxZqBcnKlOO2q86EJw9o4bU7YDT1vS8sNHyXyxYd7YIzwHY8RF22CMlU2CKbn9gvYe6tnVcB3tyFb031+njOEFw062Edcye1A68F2uEEsiy2Mdvwsdg0j5qiC+IFHeoD0e9aG1JfGKCicHeyq5M+MTzXPVVstxFvvj032J5taJ3aYAfjTjpHdVGT01cs/oDTApTy/XtIn41EeWF8sDDl5244yttoAgRsxoZtPZ2RCkJDx+aCIesnO+r9kqqc+DQXpazkLGOTrsfrawH9r6yLFUHXNAntsoqVsvIuOPOkZIbmLxgKDg8cEFhhrvIm2yF+/D1yZGT8lF94+zVSvoHV7Y5gacxpJnrj9q6sXRG4OyRG+twrZX1IUOGn3uLC/yc6vqZvgaVDHuw3npgWpmaGy3TjHU9Z5WsV1KpcjcC1AR4BW+Iw7bd6uIWBraY9nYqxxDuPfZo+ORW/RcFRRr9y719K6VonERcYntODmpLAFOyhXpIbhlgEPWZNrOfMRsV/Ild+yncSlN88fFu8zzaXYkwPS4fxuDfFUPHLN162ainfJEDLxGRCHcOv8zn07nUeiiuKjYbiqdeiswUL1Lz7/L4ORak499XyypaoeG8WVXPhNomqmyhVtrtolSLZ7NPLDt9Jgmkpy1r4nJcyDljSQWxPBu32Vay6XpeeyOUR2djG4zKIclINtVVk1uDoaK6L0Ubqbbywug471LGsd+yTrz+LQVii9+NwIzBsTBZIWoDfxhNphNzbhcKWDxXiRzwgFW320NAjny5Yr1r/aEnbAThXxbE+7oeuKnBAfBQLeSP3pO2Fr GTZUzqrr wdAfSaZ5K4BkNZZeJbME4Q00182ZmSBd4rrjpH5nzShutTlLOaY6+enHdFrjfvErAv9sv0m5ln5Pw8lvt5B4GcGCX3Bgxx1q01QUSQQwiNEh+5s6fPC7bpKVyUzKXzsgpdRWR3LWhKncI9D4M6saPqE746whcWm5EjvpjVr4PtbI5BtaxhaL0FBnGQ2cNXGl/jdRa2Rz8mw9FMDDUg+bHEyLAUKEFKMJ+/kGp5ycBjKBT7yU5ry9qIQhL2PgQx7k28zMTjTC5L7s/zuXv+7h37guPBZUar5lhGaT+mdneinnmgGhVHaCizrFV38Ow8uuvSrIYifXuYDDnDFx24T0sJHBDTOSRm5GFHz/YG1b6OCH45swjMSoS29k5aWxQMYz46JSqG8YGjsz/eaU/tpQlUIVNmVc4lOWsvGjs X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 06.07.23 10:50, Aneesh Kumar K.V wrote: > Some architectures like ppc64 wants to enable this feature only with radix > translation and their vemmap mappings have different alignment > requirements. Add overrider for mhp_supports_memmap_on_memory() and also > use altmap.reserve feature to adjust the pageblock alignment requirement. > > The patch also fallback to allocation of memmap outside memblock if the > alignment rules are not met for memmap on memory allocation. This allows to > use the feature more widely allocating memmap as much as possible within > the memory block getting added. > > A follow patch to enable memmap on memory for ppc64 will use this. See my other reply. Rather have another arch check then overriding it completely. -- Cheers, David / dhildenb