From: Vlastimil Babka <vbabka@suse.cz>
To: Brendan Jackman <jackmanb@google.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: Mel Gorman <mgorman@techsingularity.net>,
Michal Hocko <mhocko@kernel.org>,
Johannes Weiner <hannes@cmpxchg.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Yosry Ahmed <yosry.ahmed@linux.dev>
Subject: Re: [PATCH v2 1/2] mm/page_alloc: Clarify terminology in migratetype fallback code
Date: Tue, 25 Feb 2025 12:05:16 +0100 [thread overview]
Message-ID: <218b81f2-3ed4-4389-b08b-c26dd8c0a4bc@suse.cz> (raw)
In-Reply-To: <CA+i-1C0J5DiFXB3begMqe+TeuFDHqaGc1cg5C9z3=_ue6q0KLg@mail.gmail.com>
On 2/24/25 19:42, Brendan Jackman wrote:
> On Mon, 24 Feb 2025 at 13:37, Brendan Jackman <jackmanb@google.com> wrote:
>> int find_suitable_fallback(struct free_area *area, unsigned int order,
>> - int migratetype, bool only_stealable, bool *can_steal);
>> + int migratetype, bool need_whole_block, bool *whole_block);
>
> Agh, sorry, I was meant to rename all of these to claim_block.
> Apparently I got halfway through doing that then got distracted.
>
> (Literally the whole point of this patch was to clean this up, and I
> somehow failed to actually do that!)
Given Johannes' patches went to mm-unstable meanwhile, this now expectedly
conflicts a lot so I'll wait with review for a new rebased version. Thanks!
next prev parent reply other threads:[~2025-02-25 11:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-24 12:37 [PATCH v2 0/2] mm/page_alloc: Some clarifications for migratetype fallback Brendan Jackman
2025-02-24 12:37 ` [PATCH v2 1/2] mm/page_alloc: Clarify terminology in migratetype fallback code Brendan Jackman
2025-02-24 18:42 ` Brendan Jackman
2025-02-25 11:05 ` Vlastimil Babka [this message]
2025-02-24 12:37 ` [PATCH v2 2/2] mm/page_alloc: Clarify should_claim_block() commentary Brendan Jackman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=218b81f2-3ed4-4389-b08b-c26dd8c0a4bc@suse.cz \
--to=vbabka@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=jackmanb@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=mhocko@kernel.org \
--cc=yosry.ahmed@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox