From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi0-f69.google.com (mail-oi0-f69.google.com [209.85.218.69]) by kanga.kvack.org (Postfix) with ESMTP id 155C66B0069 for ; Thu, 23 Nov 2017 04:22:02 -0500 (EST) Received: by mail-oi0-f69.google.com with SMTP id g10so2961165oia.8 for ; Thu, 23 Nov 2017 01:22:02 -0800 (PST) Received: from mx1.redhat.com (mx1.redhat.com. [209.132.183.28]) by mx.google.com with ESMTPS id j28si8116576otb.336.2017.11.23.01.22.01 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 23 Nov 2017 01:22:01 -0800 (PST) Subject: Re: [PATCH] mm,vmscan: Mark register_shrinker() as __must_check References: <1511265757-15563-1-git-send-email-penguin-kernel@I-love.SAKURA.ne.jp> <20171121134007.466815aa4a0562eaaa223cbf@linux-foundation.org> <201711220709.JJJ12483.MtFOOJFHOLQSVF@I-love.SAKURA.ne.jp> <201711221953.IDJ12440.OQLtFVOJFMSHFO@I-love.SAKURA.ne.jp> <20171122203907.GI4094@dastard> <201711231534.BBI34381.tJOOHLQMOFVFSF@I-love.SAKURA.ne.jp> From: Paolo Bonzini Message-ID: <2178e42e-9600-4f9a-4b91-22d2ba6f98c0@redhat.com> Date: Thu, 23 Nov 2017 10:21:52 +0100 MIME-Version: 1.0 In-Reply-To: <201711231534.BBI34381.tJOOHLQMOFVFSF@I-love.SAKURA.ne.jp> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Tetsuo Handa , david@fromorbit.com, mhocko@kernel.org Cc: akpm@linux-foundation.org, glauber@scylladb.com, linux-mm@kvack.org, viro@zeniv.linux.org.uk, jack@suse.com, airlied@linux.ie, alexander.deucher@amd.com, shli@fb.com, snitzer@redhat.com On 23/11/2017 07:34, Tetsuo Handa wrote: >> Just fix the numa aware shrinkers, as they are the only ones that >> will have this problem. There are only 6 of them, and only the 3 >> that existed at the time that register_shrinker() was changed to >> return an error fail to check for an error. i.e. the superblock >> shrinker, the XFS dquot shrinker and the XFS buffer cache shrinker. > > You are assuming the "too small to fail" memory-allocation rule > by ignoring that this problem is caused by fault injection. Fault injection should also obey the too small to fail rule, at least by default. Paolo -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org