From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55BCAC47DA6 for ; Fri, 12 Jan 2024 14:26:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 914E46B0087; Fri, 12 Jan 2024 09:26:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 89EFE6B0089; Fri, 12 Jan 2024 09:26:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 73DB56B008A; Fri, 12 Jan 2024 09:26:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 5BE446B0087 for ; Fri, 12 Jan 2024 09:26:48 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 34A281A0218 for ; Fri, 12 Jan 2024 14:26:48 +0000 (UTC) X-FDA: 81670885296.27.0CC3307 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf26.hostedemail.com (Postfix) with ESMTP id 59B23140016 for ; Fri, 12 Jan 2024 14:26:46 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Eh3d5RrW; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf26.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705069606; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=iz6SIFr4k0uXKcNgYCgpcXfx++z4o4YOQFTzrgztyxw=; b=VkDfEfULWROiuIFMDmGv/VjOJC9XtiynONh9L/jdqZV9k1pTUmNXW8omUytKDNHrYeSr+h reMNehJJwawOdQRVjuS5LRspkE8WUl+lPt2ipnSj2d1XWZeyWCScRppUR9ieqwbmZcftfw VmENiITCz2P2uSAmY98XXau1o/4VFgc= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Eh3d5RrW; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf26.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705069606; a=rsa-sha256; cv=none; b=cu9gpvQD93hfTksXBwBaoW5HHcVvXFH7ZXi9WTWPD/bh52b+0iBlH/tShEazr1MUV6rdCQ LFtF7tEtkqy5f+VPlhzRwEKhs707lQSqQPoHX8UY3CvOLBTTPTK8FC74Aqy/exRMhumI9n MLUI5wHZW+aNCspFliZv8638Y9qGYmA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1705069605; h=from:from:reply-to:subject:subject:date:date:message-id:message-id:to: cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iz6SIFr4k0uXKcNgYCgpcXfx++z4o4YOQFTzrgztyxw=; b=Eh3d5RrW1xgqd7bsGzB3MC5n8MThHAmZ/Pn0T8kv+ble8yYXwdiPi34TYzqCkZJRmkjv0l X2K/O0PwLbqJWV0NSs38GPYF1iv9L9H1L3CbzHQhxyQv2qkri8uOrKDd7F+QKPniQJbrjK TUZ4Pz0BYiQ+SfeOnYJyR/E9Gz8596U= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-73-YTxaQt0lOjqs75Tj8puN5w-1; Fri, 12 Jan 2024 09:26:40 -0500 X-MC-Unique: YTxaQt0lOjqs75Tj8puN5w-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id CC356185A782; Fri, 12 Jan 2024 14:26:39 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.42.28.67]) by smtp.corp.redhat.com (Postfix) with ESMTP id 83D8B2026D66; Fri, 12 Jan 2024 14:26:38 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <2161774.1705069315@warthog.procyon.org.uk> References: <2161774.1705069315@warthog.procyon.org.uk> <2023121124-trifle-uncharted-2622@gregkh> Cc: dhowells@redhat.com, "Jitindar Singh, Suraj" , "rohiths.msft@gmail.com" , "gregkh@linuxfoundation.org" , "linux-mm@kvack.org" , "stfrench@microsoft.com" , "pc@manguebit.com" , "jlayton@kernel.org" , "nspmangalore@gmail.com" , "willy@infradead.org" , "stable-commits@vger.kernel.org" Subject: Re: Patch "cifs: Fix flushing, invalidation and file size with copy_file_range()" has been added to the 6.1-stable tree MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <2162108.1705069597.1@warthog.procyon.org.uk> Content-Transfer-Encoding: quoted-printable Date: Fri, 12 Jan 2024 14:26:37 +0000 Message-ID: <2162109.1705069597@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.4 X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 59B23140016 X-Stat-Signature: hkarcetcr3g61w3fodchu9ye6mt8bjdo X-HE-Tag: 1705069606-167691 X-HE-Meta: U2FsdGVkX1+d8RoudeN16peWZ3OPH07Dcnkn8DKiW1ulhDMtjC1fAH0evNw161Kur+/8D7CMq8YSfUGHQT8qnRrjCn07IFJvSAMbxG5w92b36ersK3nNImjrgDmdhinv1i1OG8bGQE0fzTNUFkZq1pL2KsNnPujQtYe9RWyKzQAfILHArC7utVNg0oDOmOCNkwM+fddsY7AhqKe7mQdjjaL6HDwf1/wQJZGPLyME9K5tbXJU6CIgt9CXi3ez2Xck2rCMKdK2HvG/DJ6xStblJQ+VBcgJ59dqqDStZ5fuD/foXGHorI5ylY24Px6xXe7a3zhIQnwivv0h9Yrxnssu2Jfi5a9jCM757W1d3qXe5H4I0gOY0tEdd7Gc3gJxWF6xXAG5PGd3SmBlyw71tqvgbhlWwTrW30CmHdn8f3QOvUw0tOSIvhiw8qiBqeBFSh1hIJDIcOdPfdXuaK1qEn+Wy5X5E6FLt7Swtf7xAd05aUTuLinX7fUz2HHSK/eN+vr0HWHDC/qWFTdv3fdEUdS9JP4hSbdt/Oy4rTlOYHxleX10jjmiBVTzkiBvzmMUpXuhu1rqYZWL+Q1A5ctlBFEhLjsW7gDn3pOOZtWOEozcVZpFq15qDdFTiXP0gnND3rngXrVEj9pC5gxeyA/QtXSUEKq5x4XqMf4pVKNbYedfK+pQyPkoE7it1DpCs4u7s8wQzOCRl58Bprs7dj6n5ORjl5ORYcibnRFWWMNuasSOi02qwwyLsnsEwJJjGaXwa1J+tNbi2Yd9cHfq1MEAtjYxYO47ygqZHfEKFE5IQRFPA02EqvVLTtm3sv9dPv/iWzsebymQLcgPI/ArUAcfdXOh+LfOcez/W9aub/rRbDvio2gxV8tCn9qT8irT1v4KhIUkGrJZx8tXWV/HEdoeuHkw7fdsQkJJjdnkshYWfDku0rp9Gqlh2MeQMHWKyrh2Xh1GxlmD7gG4+A9fFM2xQbI Ylh+rnfi 7L2Jv3ukrqclEhNmLVf6Rn38qwE3rkt3DubbxFNesOwvPvorbnv3VJUXgAbg3J/nLaeqNX9sEf5kxBkiXba6s38LkH4pC2eukcuxirHP8y2hHvlDnaRhU+ONe4zurAZOG/ZRi75bRdcILk67WnL7Gq6pW5D9L1o2PC1Q+68fD1ilh6zDNquHuZQc51CRefsUy/7oYF0jHx81xAl/IRATX54sU60tAZY/m1buOCi6fsF+Opri6bqYMJ3JS221SssvBknO3tFcXU/JX4ndqVf7KPZFrekiLJ3L8gsAECj/V5j+phpjl8NyVpA9PN5+oDR05LklLcMrZdkVMmG+OJFWLTZery9B/mcAqw8d/Ea7VRk6K0sh3dl8rWxEyns8pXbqJWXz7Nug/1FF1EIeaQh0FRfQaS/lXyk3O9mC9lIqhQxTBrylyabdXcRWKZg/GeV1oBWwD X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: David Howells wrote: > Jitindar Singh, Suraj wrote: > = > > When testing the v6.1.69 kernel I bisected an issue to the below commi= t > > which was added in v6.1.68. When running the xfstests[1] on cifs I > > observe a null pointer dereference in cifs_flush_folio() because folio > > is null and dereferenced in size =3D folio_size(folio). > = > Yeah. __filemap_get_folio() works differently in v6.1.y. There it retu= rns a > folio or NULL. In 6.7 it returns a folio or a negative error code. The= error > check in cifs_flush_folio() needs to change to something like: > = > folio =3D filemap_get_folio(inode->i_mapping, index); > if (!folio) > return -ENOMEM; Actually, it should return 0, not -ENOMEM. David