From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E695EC4167B for ; Tue, 28 Nov 2023 15:47:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 48D766B0083; Tue, 28 Nov 2023 10:47:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 43D3C6B0281; Tue, 28 Nov 2023 10:47:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2DE176B0287; Tue, 28 Nov 2023 10:47:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 1C7226B0083 for ; Tue, 28 Nov 2023 10:47:01 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id E5602C0211 for ; Tue, 28 Nov 2023 15:47:00 +0000 (UTC) X-FDA: 81507791400.03.6E1D66E Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by imf30.hostedemail.com (Postfix) with ESMTP id BFDC180003 for ; Tue, 28 Nov 2023 15:46:58 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=flygoat.com header.s=fm2 header.b=EwToAO3V; dkim=pass header.d=messagingengine.com header.s=fm1 header.b="uj/ia7ZO"; dmarc=pass (policy=none) header.from=flygoat.com; spf=pass (imf30.hostedemail.com: domain of jiaxun.yang@flygoat.com designates 66.111.4.25 as permitted sender) smtp.mailfrom=jiaxun.yang@flygoat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701186419; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vQ2DpM/PgnVcF0UkIV4NW3voay3Ssm0FPmSeIIJAMzQ=; b=3duaVbYAl1k7e3RHBzfuqKryU5pSZh87hxjFLWMv6sHQpbJcD/Nqim2ksoPCqTsSACS32H arKD7uRaE8Hk5YBSnaqm5dZa9mANTtWS8H/S+EPtNDRizyb68+6pojnYvX+EtT0rrLUjUe W6cNsij9n5Sb3kPYB5rsZ8zxb0rADD8= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=flygoat.com header.s=fm2 header.b=EwToAO3V; dkim=pass header.d=messagingengine.com header.s=fm1 header.b="uj/ia7ZO"; dmarc=pass (policy=none) header.from=flygoat.com; spf=pass (imf30.hostedemail.com: domain of jiaxun.yang@flygoat.com designates 66.111.4.25 as permitted sender) smtp.mailfrom=jiaxun.yang@flygoat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701186419; a=rsa-sha256; cv=none; b=OD+67wNr5hHWm5aFZzFI7ceCHDOhrag43xSzjkXiqfyVLXKWRPTwNOm07fODpIRKPCxr8k fRg97Rw75rk03sv/1ux7IM6nsyEjQ8A6wbEe0ZyoSp9MFguQw6Oq7xFSq0UAfJcyLvOaXg y4rHoygpcxQDhRAAULVBihOxePqnQvE= Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id E73785C01AB; Tue, 28 Nov 2023 10:46:57 -0500 (EST) Received: from imap44 ([10.202.2.94]) by compute3.internal (MEProxy); Tue, 28 Nov 2023 10:46:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=flygoat.com; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1701186417; x=1701272817; bh=vQ2DpM/PgnVcF0UkIV4NW3voay3Ssm0FPmS eIIJAMzQ=; b=EwToAO3VFs+JL4f3zp125iNCKmBpnz9Rtd5S3ATvpNIxrrjOGdd HeXXhc1bYQ15IZRYtOQiC0T/6J5Rff3RTYzPPQitwOmfRO+624cK9MlgOStYYRrx MkxDXPFQ+aPrDgQJnyDQp4DTfxrMawTTGT4sShXgrzbZOprA4Ib5VeGYu3eB07OJ I+qDLX7repSisScrW6pM94bBAp/AX9viq2faN7SKUuuAkHiTXNraJ0/6P6iJeXnO NBkNaa9MJiJRfoPc9hDuoZR0ZJPtHkWOzs7qBCL/RT1qbW5Mf1gMfDcTs/P4aqx+ djxJ3m+akqjLmIbb0LkqNvMaUjD6Az/3mIw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1701186417; x=1701272817; bh=vQ2DpM/PgnVcF0UkIV4NW3voay3Ssm0FPmS eIIJAMzQ=; b=uj/ia7ZObmuU9t+KLKPaQRcYi6+y4krZxl8PvB1ODVSbLQXyUPY pHF71eJu272E89Ilvh8GOaVd0P1sbBWZpNxWfq/LVj/tNz2VjZDCTO9Qg9FVnMF8 JqTG6MMzhnhQb637cX1x9Lzc5al8JfHD7wwJ5EafNOnfo7LL5krM09SAecz4SIRP fyJQC0Wx60j902L5vYuInt1tgafLVj2i3swVR6OGOESddtla8UY9vUBJwW+W5lyK RgscyL46lg7LPt1Z0It01P+pZ7FdxWZwzPyDFLksO/nLNKCkBszhAp8tPZTnhUl7 OUvl6Kj1TRyLSQY2gUZD11NpizCPQqkfaWw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudeifedgjeekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvfevufgtgfesthhqredtreerjeenucfhrhhomhepfdfl ihgrgihunhcujggrnhhgfdcuoehjihgrgihunhdrhigrnhhgsehflhihghhorghtrdgtoh hmqeenucggtffrrghtthgvrhhnpedufeegfeetudeghefftdehfefgveffleefgfehhfej ueegveethfduuddvieehgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmh grihhlfhhrohhmpehjihgrgihunhdrhigrnhhgsehflhihghhorghtrdgtohhm X-ME-Proxy: Feedback-ID: ifd894703:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 9EE0236A0075; Tue, 28 Nov 2023 10:46:56 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.9.0-alpha0-1234-gac66594aae-fm-20231122.001-gac66594a MIME-Version: 1.0 Message-Id: <2148a67f-bd4f-432e-aa0d-c914a4bd5e0d@app.fastmail.com> In-Reply-To: <3pgnihbrp5orh4tmj45fipbfoxdwzjh6uefitdpcea2vgkarcm@d56gv3areswl> References: <8ca730b9-fa8c-46ea-bdc5-158da0f29c3a@app.fastmail.com> <245d3985-9085-4be0-8c74-d95d06334584@app.fastmail.com> <3iksuovvsln3cw3xpmjd7f7xixfvwaneu4ok56fnookvyolpco@wrxxew3thgnq> <3pgnihbrp5orh4tmj45fipbfoxdwzjh6uefitdpcea2vgkarcm@d56gv3areswl> Date: Tue, 28 Nov 2023 15:46:37 +0000 From: "Jiaxun Yang" To: "Serge Semin" Cc: "Thomas Bogendoerfer" , "Arnd Bergmann" , "Andrew Morton" , "Mike Rapoport" , "Matthew Wilcox" , "Tiezhu Yang" , "Huacai Chen" , "Yinglu Yang" , "Alexey Malahov" , "Aleksandar Rikalo" , "Aleksandar Rikalo" , "Dragan Mladjenovic" , "Chao-ying Fu" , "Marc Zyngier" , "linux-mips@vger.kernel.org" , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/7] mips: dmi: Fix early remap on MIPS32 Content-Type: text/plain;charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Stat-Signature: 9dmzry7xp3n43yma5b7prs4y33819mhz X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: BFDC180003 X-HE-Tag: 1701186418-153801 X-HE-Meta: U2FsdGVkX1/fZa9bQp6SbGIlu5vOMRLUi6aQ+KezY9NoQXSdEJU9tmAUepzKS4WhkvdwJJe3H+bBOZloOiz0ZbiyxLHEUkhMu2f0qOLnw30sNjofl5upvDQEf7W44As56cBAb46KtGIRLuoI7s7s9hkQCcoFVizHck6f0/ns7IZVxApJ0MfGpkbRsIICzPH1bcTH+b4g7r5H26U72lfD3PtY32xBN81IzvZ/+t7m+zQlCBNDcbcCeRGk8dP7j3EyRuwhhrH/tBDHKkHNBbsh+JYc1ezZjBiSep320CK1uIZhWOLu70hcG0bcqo6suoyPdb6Ve14PXofIDXavcigaWaily5n+q+WaF1/rq9/RfVDGqIZRf6+N0T3UFlwi6wl5eNN7VIP1KbUXmfRq79s8sSrXa666lvRA6Lhz5/Z90R1jYwb4z+brMb0cxq78G5SCUBNvw5YY4Iu4nSFPzH9N/fZZfz0TaEh5WDmMrDMcRk3LObThErYCme686TCLBgJW0GV1eDZ4s7cfrPkxpEIIb7G3kjiJ84KJSUgs+XcG4wIWTJ/H60aWUvepEA8pdZdcxfx0Ey2V5hCYqkyWmueyui7CUKV9c8oRK3Y5kx2raprekg2eu/CyfUddYGFjZjoExD9o8rq+04mjtAGSQHNhphblJ/f7MwMSamL9eToI8CsBxmkEf3o/79vhxllbDETkNxj+XS45WoOVyO6q3mhfZlOfa76HbmhBKmszyUIFxD8ws19ui3YFHHEaur9SUqTTq6jKqJmyHK1l8r37wf8dR45ujZ3wxG+2wm/vFy3pzWquRHsyf6oJPP/gbQvGslx346JmjGZGZvEaLLMb9kZ1cyOu3v6hwT3jgoyUUSZfumlxZREI3gzFhZAJgv8awSQSwwALVfSf5SPcPxSKy+YarPLEPt9N7RsIvXpmZXCChUKd7NCJ4ePp5rV4WscpByffS+f5kW+Vd3EQNPXtwVD q4qXn7Kq xcbXfPBZPI4EnofeWLFTTjYAm+aLMhJKgAaks9Z2p/7cLQhWFnWoI84uDEiQBbdh8CquBVYPNvQLkuHUuPDV/VIpFKFaTsfLNmQspgCIvJT6+HbjRcvWAWhogXRjONnzIsLhVUPe+HPAHz6YXTQIjS/JeXSON0HCqIoql7+E7kfyjChi1gBJWLeORNaOQxwFk7fluvew3Sx8mMm3U9+DQ06FXOrxaytAg6vq23SPpFRas3Wr1rd+PGw48ePXmypevhd16J5I497jGsnIvMzZM3/FTbqbW1sRR3BalGjJ66WaYtIWfxY8H95jKu80FeltjLecQKSWXWd48+Ji+cAAK0SDL6w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: =E5=9C=A82023=E5=B9=B411=E6=9C=8828=E6=97=A5=E5=8D=81=E4=B8=80=E6=9C=88 = =E4=B8=8A=E5=8D=8811:34=EF=BC=8CSerge Semin=E5=86=99=E9=81=93=EF=BC=9A > On Mon, Nov 27, 2023 at 09:08:11PM +0000, Jiaxun Yang wrote: [...] > > Indeed. Thanks for pointing that out. In the last days several times I > was looking at that line and for some reason UNCAC_BASE seemed as > CAC_BASE to me.) Based on what both IO_BASE and UNCAC_BASE are defined > as of the uncached region anyway, then it should be safe for any > currently supported MIPS64 (including the Loongson's) to use ioremap() > in place of dmi_early_remap(). So basically my current patch in the > subject won't change the method semantics. Let's not to try to fix a > problem which doesn't exist then, and keep the patch as is especially > seeing that the alternatives might still cause some troubles. Will you > be ok with that? I'd say the safest option is to use CKSEG0 or TO_CAC here, but I'm fine with ioremap as long as the semantic remains uncached on Loongson. Thanks. > > -Serge(y) > >>=20 [...] --=20 - Jiaxun