From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A209CEACF3 for ; Wed, 2 Oct 2024 18:27:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9A1324401C8; Wed, 2 Oct 2024 14:27:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 92BDF4401B5; Wed, 2 Oct 2024 14:27:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 77C824401C8; Wed, 2 Oct 2024 14:27:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 4A4CE4401B5 for ; Wed, 2 Oct 2024 14:27:20 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id D03F2120E47 for ; Wed, 2 Oct 2024 18:27:19 +0000 (UTC) X-FDA: 82629494598.25.04921F7 Received: from mail-ej1-f48.google.com (mail-ej1-f48.google.com [209.85.218.48]) by imf19.hostedemail.com (Postfix) with ESMTP id D33AC1A0006 for ; Wed, 2 Oct 2024 18:27:17 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=PAuFRxRW; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf19.hostedemail.com: domain of usamaarif642@gmail.com designates 209.85.218.48 as permitted sender) smtp.mailfrom=usamaarif642@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727893598; a=rsa-sha256; cv=none; b=XT1yBCNIQb0RDy7deiZgTUP7ZgmbdfcBR92EgsfwiqU9E9zmiX0+UpR6IQM07vQ2DVTtfQ PHvoznyluHhjzBdwn6aZ7anJkDjC1s/KE++T+TBsaHvK4q8dqywYoIl9Xhed9CBZDQCW9J NlO/M76IL51ENxr6AyiJ5Kn0nLx6r9I= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=PAuFRxRW; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf19.hostedemail.com: domain of usamaarif642@gmail.com designates 209.85.218.48 as permitted sender) smtp.mailfrom=usamaarif642@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727893598; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VeyD8C4FvXwo0FLaCDBvuCrxOTWQzD59jm/41g8MBdY=; b=TUPnQzKl6iCp0fSnJfK0/+VSLslSCfFwa1hxLbIJBUujzLN6bwWsPNO7+Ui5TbqqCUseqz Jj6kj1RfTGACuXMNW2qGXWC0BuUQNUERwmMwIE0qDiJkLPq67Lh8rcInUg+rPZSgtt5Z6E tWhbfEfnbAjvPprMgXt41NDHLLr2K2w= Received: by mail-ej1-f48.google.com with SMTP id a640c23a62f3a-a93b2070e0cso3808466b.3 for ; Wed, 02 Oct 2024 11:27:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1727893636; x=1728498436; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=VeyD8C4FvXwo0FLaCDBvuCrxOTWQzD59jm/41g8MBdY=; b=PAuFRxRWAdXn03R7NtoQlHM/gIb/MdX2ywY2ZPHWIDz7nuqFZG61F5FzlzoS9CYM5C 7pB0EudNvZuUTrGTLlZPr+eB+JXSg+YnBRNq85p0frLuD+71+eKIfbwwSi6ALDOjv71c RJ/0k2UJW0OZlQ0M/7yGszuc+xGf0czQfVwgUe4xBcWcWjxnmhGuXAb5PaYIDW8UlpbJ wojOXKmyyji5nkHQ6sZYDoEMWczuYxkqK9zsfGKKBK852bdiHN5vxMZcW8JEudaeJGIi VQkoIDFvBC+mZRc1yqN3/dwp5l68qpkZBjlXKOXVNVFyZmEjYk2izlk470EOKd4HTjsn eT+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727893636; x=1728498436; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=VeyD8C4FvXwo0FLaCDBvuCrxOTWQzD59jm/41g8MBdY=; b=j1m5P/zBBO4OOxmhl5yL30GZgO/qccOeS7pH7wwyIHP0IiOYuloLMCvZJbobrCikqP q6QXD2n6oUxOG45A5PEECLpaozYrLi3rZk4wV/jNI69Q4/PE52yWvURZPJTEU8+WiDzi l/etP27lPKVj5q1p4zQrvoKgPHfCPV/oc529HvWs6PDVj2In5fWpa86QT+rMcCAGL5+w apckH9sE+UUSaJ4YKXXLNFqEmciMW5aXsJAlgwcEmoALE+J/a1mfsgvHBLaDIQ5sRNMB hQoXr2fbBar/rJCBQKYli+GP9A3fPSh+poUGQJlNEEPXZGdigfzAysKCpeZHjHnTV+Um DjJQ== X-Forwarded-Encrypted: i=1; AJvYcCUuvYVLlAhNdjE7kBJL+2+AJ5/RtkXX0GP1uIO5Sc+EEKjRbqjs9dbSlN5L0O/8RDzTSph4mIDNBQ==@kvack.org X-Gm-Message-State: AOJu0Yz0EZZKHXVRl1rrqF1VdgeWxvxgzPMvkRLZD3AlrjWPhBCD6sKi vUst5Ub35IBHi2bcLNzzdv1VcQ7vISlelp0KoR+VQhAzhlJaoCBfqtt3bg== X-Google-Smtp-Source: AGHT+IHTSIjSt5+kq2Va3437ePosbnMc3AbvavYo29mtfo/HCGdVSaMSEBjfv7Bea7bUOomY1BUTKA== X-Received: by 2002:a17:907:a4c:b0:a8d:7210:e28d with SMTP id a640c23a62f3a-a98f825aa48mr373675566b.29.1727893635890; Wed, 02 Oct 2024 11:27:15 -0700 (PDT) Received: from [192.168.1.50] ([147.12.138.70]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a93c27c70dfsm905469666b.52.2024.10.02.11.27.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Oct 2024 11:27:15 -0700 (PDT) Message-ID: <213a8a00-7ecc-4f52-a9df-7e2f9b1ff977@gmail.com> Date: Wed, 2 Oct 2024 19:27:14 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1] mm: zswap: Delete comments for "value" member of 'struct zswap_entry'. To: Kanchana P Sridhar , linux-kernel@vger.kernel.org, linux-mm@kvack.org, hannes@cmpxchg.org, yosryahmed@google.com, nphamcs@gmail.com, chengming.zhou@linux.dev, ryan.roberts@arm.com, ying.huang@intel.com, 21cnbao@gmail.com, akpm@linux-foundation.org Cc: wajdi.k.feghali@intel.com, vinodh.gopal@intel.com References: <20241002173208.213631-1-kanchana.p.sridhar@intel.com> Content-Language: en-US From: Usama Arif In-Reply-To: <20241002173208.213631-1-kanchana.p.sridhar@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: D33AC1A0006 X-Rspamd-Server: rspam01 X-Stat-Signature: hchmk41sh9ohio45zhock9997unddcjy X-HE-Tag: 1727893637-413371 X-HE-Meta: U2FsdGVkX1+d9GHkrG0JYJYNeKSAkwYGtp9/1aOMTtnru9g/DvB727LrpoTRAZ8KeEuTgIf0CdM7XKOl6TGFgkN01p8mbzDVHnHBqHfnbCpyGqduftNq0q1s3jGxdsZ7IPC5+iW118wwDFNYeF8dZ+d7w1sH6EVo7zwN3I1hCD+07OuJC97kK0oWEDQV4pYWuaVFO5pCXtoRmqiFl7G2LltnyrS2GiTbUiyaHLH7JYV/E4TeL2u+/H/y0bGQoREWNKPCv4IUf5cxsm/JcFQH7Mg/5xAQZMFsQg2NfBsKBBhfUNuveQP5LT+7Jbb6GlByVLluE8MWl+4JFcxHEu6t3GgfNyUvM9++VPcrYM0ge5/xkqgxYm12uDUusEAlkxApOkD2uOkN2BCEpDrYUpOj7ZK7Ey20daa2zhPkAGtxaOWKjFLI4wwSLoaKtkA/kv5qMqp3jfaIlh5MsZalIQRFgY/ntQ4QZlWodyI9F0eOeP2WA8Glp3NEfqFUnGUHqWkfB9XrFHaYwHrwlxwz2tYavJ18bgRNQ2m/guLnnCINpSEdwqrmDKudLAvf10QU2ZKqZGQ2bpjkFAdHZeAkk/jbJ4loT0UJa1zdHZGSJqTs9ntaP4dmRH7b42HE4RSFdGyoBJPAik+lPqhQEZ/RnGjuoew3vPAm6mCHyc/xBfgDOPPmPYOZKMf5kdq5+Czu6Ldz/fvYGPgdYtSjpeLHR+p+AGLBqkGh1Evh232ztP8K8ixOSOiSBf/jhuYyVHxvesnTFm9Yu+pvsGyjkGOPyZkF117rjlrfIXTbPaL1ix31p4+V2+zRfnyhLY6xredeOGWmBIW9TCPxWQaPZn6xM1NaElZ+eFY/j5T892/OvTSTqPxprwmAq9uVU0DuXQY3TsZJhnUGlazRx1E2bcdiBlRM0V0Bak5D4pKRJWUGutgCkwt9BPeNvqLG/NJbzNRNy97ZpQ5xeH38v6N2Iw7oiOu DWVOJ42A JaWqY1xvPq0JX/Hf4r1bCsUKHRKTh5TSaIfm+DsyPWeXxyXc/oImLSkWpNbb0CpmXPvSNzfmuPyxHwejAmScoCGX9vAqOq7SxXNpUcQLdQIu64LNa9siwz/Cycts5rsR8cIJJ8AYMwgGXpnmtRY0QOBReEhm1C2HMZLDKNqC+bK68FqtN66DrO6lIkK63FlhN+94+Tu7oByRjy821+IDc5ZZMhW/XsL4lDZ5rhg7Ex3DZd3V5Y52NHJN5DG4t8xherMpKds7i7jmhr8RGTybIUKQAnkcwQkjcOWSGBbP5R0ojutrGlYvt1alG7eCyprx3AUXLy4XSklaJLDwgMbRQDVgP2Fa/3dk4B7Nk2OT/sje8TlYkZyd69uMgz+G04wEz0ZHD/l3r6PSnf0cBFM1V+O848weO7k4Tm35IwoXTfdTO4QjyrjyXSNFShG9pKnRTlcNx6v3pNoSG9Iw15Z2CMvaxnwPMuufQO8KNDimtA4cr1E9S/yq0nqVuGkyrWCr/LwvncrJTMuuVoP8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000021, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 02/10/2024 18:32, Kanchana P Sridhar wrote: > Made a minor edit in the comments for 'struct zswap_entry' to delete > the description of the 'value' member that was deleted in commit > 20a5532ffa53d6ecf41ded920a7b0ff9c65a7dcf ("mm: remove code to handle > same filled pages"). > > Signed-off-by: Kanchana P Sridhar Reviewed-by: Usama Arif > --- > mm/zswap.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/mm/zswap.c b/mm/zswap.c > index 09aaf70f95c6..c3e257904b36 100644 > --- a/mm/zswap.c > +++ b/mm/zswap.c > @@ -190,7 +190,6 @@ static struct shrinker *zswap_shrinker; > * section for context. > * pool - the zswap_pool the entry's data is in > * handle - zpool allocation handle that stores the compressed page data > - * value - value of the same-value filled pages which have same content > * objcg - the obj_cgroup that the compressed memory is charged to > * lru - handle to the pool's lru used to evict pages. > */