From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF6A3C61DA4 for ; Fri, 24 Feb 2023 12:12:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 22AAA6B0074; Fri, 24 Feb 2023 07:12:28 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1D9AD6B0075; Fri, 24 Feb 2023 07:12:28 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0C9156B0078; Fri, 24 Feb 2023 07:12:28 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id F146E6B0074 for ; Fri, 24 Feb 2023 07:12:27 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id BA707418F9 for ; Fri, 24 Feb 2023 12:12:27 +0000 (UTC) X-FDA: 80502073134.14.7F201AB Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf06.hostedemail.com (Postfix) with ESMTP id F02A718001A for ; Fri, 24 Feb 2023 12:12:24 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=GKBUi19L; spf=pass (imf06.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677240745; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Fzv8kKvKUnDQl9L+lsYADmjdu4rL9VzyOE69oB2LK2Y=; b=7uJWD15Qx1iWUSk7DBagRIh7IrF1TsiFhInvbbcJIBe36Iu/mefEOgBkJiiHzumzoBx9In YQxPUBRUGrKV8yifcIwBiTrPlAKCyUbsP0O1VYtf9dalim3dRW4GzM1ke3cTbIyMHeyU5t sX+LxiMJQ3pp15sORz80cqdcF9TBQDg= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=GKBUi19L; spf=pass (imf06.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677240745; a=rsa-sha256; cv=none; b=E15t0IjQSWTHrjviDrac1dnDp4KN+Jt3rcKMmC+RZlMRisKI+kl49Fx2fLeQmdH+P1Dqg9 kEdalSyRvWb5+gcNJmzZ4+uG0CSep0/f8B0a3nGVKgLvFlVRi4IOTaA6waslJ6IHLZ1EoV LwYvUjNhKztt5PbQfqM9Y6bmLdJGtNk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677240744; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Fzv8kKvKUnDQl9L+lsYADmjdu4rL9VzyOE69oB2LK2Y=; b=GKBUi19LbF5FrPTLLRpuIK7unIAiUEftQFkrXdrLwWv0LnmBe6MyJEg0rY5JzdyAuuhwQy H1hzPOcZ0VWO4pomiYfoVSnYEUuVl7KHlYGVOO6/DYTcmZWoz05G17DQzGyTdrY+VBT6/M cHxZT8iSXHJUXUMuUihznbaQ6122u9k= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-341-FvU3Mpm2NdSaHJanVekUVg-1; Fri, 24 Feb 2023 07:12:21 -0500 X-MC-Unique: FvU3Mpm2NdSaHJanVekUVg-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 34A6D3C0CD4B; Fri, 24 Feb 2023 12:12:20 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.36.18]) by smtp.corp.redhat.com (Postfix) with ESMTP id A4D8C1121314; Fri, 24 Feb 2023 12:12:18 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <2009825.1677229488@warthog.procyon.org.uk> References: <2009825.1677229488@warthog.procyon.org.uk> <20230220135225.91b0f28344c01d5306c31230@linux-foundation.org> To: Linus Torvalds Cc: dhowells@redhat.com, Vishal Moola , Steve French , Andrew Morton , Jan Kara , Paulo Alcantara , Matthew Wilcox , Huang Ying , Baolin Wang , Xin Hao , linux-mm@kvack.org, mm-commits@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [GIT PULL] MM updates for 6.3-rc1 MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <2134429.1677240738.1@warthog.procyon.org.uk> Date: Fri, 24 Feb 2023 12:12:18 +0000 Message-ID: <2134430.1677240738@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-Rspamd-Queue-Id: F02A718001A X-Stat-Signature: nn9efe55mep1t3t4dphsjrm9gwdcam9k X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1677240744-629265 X-HE-Meta: U2FsdGVkX1/8Ek/PzCM5Edbf1G66cnBUFrfTZC3VZE2qL/2qkpC0TeQT4glOThPlQOHX8xOHGYJmC6TUbvnoP13iAeGBI0Udi8YV1HspanHmMiRNXj7kp3QXjvV8AKx/CgWLAXlghBKTqIUnfAgXot2tkwOW5WbrOc86YJCN7bZatkz6ai/DPtsjv5V8287JGmo8Ad16nF8VWUbEmKHEnuTMSM+lTQzVIHCY3xsIfscogc0yiwVk2eMPab5WK8Sx4CuBU7Nm/y4WItzvsP7vJRzFVGcIbur2XtwrufWTHtkFPe+yJvYgQTmWn6SUsno69B32PnmCMvR1RGBClf+lvAK6ZMTdeVY05GnsXVSRgU8kQ2HGZWKMVIJZpaD/Ky8s5HQJvsLNBdY1fiKCmFdrNMAzQjB8xNRlfN+nmIAQmCMmyOD12pEHYw61z05Ti0csFCq38o2g6em8OAnICJ4QdwCpkDcVf9EMFzY8SGDkN5LPC9jvxMGvOHYe4RpuDpfd9BK8dqH67/3e237uzOcJ6vlELCgcJKbR3NnnNfDOYUCxUSHE62VlDycjF4VI/musv7C91XSnsiTH2QPDPOE5EztX8nfxqwPx/4z3XEDh4+9XGhHvPtLG8ocoixiEKVbad11XKF4v9cN6JWSVhJDBvsO6stJWh3Cly7aRfE3YhxSZc4bbpQiAZy08ieyjpnya2/j7PdXIllybb+WOodO55rDG/tPYrLDEWPUJC0ed4ds+rAQSHOfWQCzaNjOCVrv5liwyep+Tl4IVoAI/7ksmXJ5AgV2DisXT0rftc/DOKQH+QcqckIS/oYi1SbAOYs1lvecc7fLf7f8ho27SyYykSgBQ/kWtPEr+8Fm1YpXWk0eIA8+/AtQMtwx2fEvDN/0tFpvNKuV08zN6+fEhj0dfU+UV/uHHlzX7+Owoy3VMRaFXuoJeI/Mnf8zVNpwa333sO3pp2VlhJVtal6/EmZy EalZGa28 Aw1XWH+LXPM/eaX+4l4ToBwrqx1j40p/5d0ifUkBZ/1xfIKmW1tAwMsUhX+NJx6HYcEASfHixgCZtizJxYQghOSvx2KNC9rulS/YY4yQ3YEYLMAjrdp10Py4ByoYGDzqcTz01DMyAKRkfaI5kT8k7u1OoABtGnNo0CtToinpm2T24QHLHpBGsKLJEIRZ2NtsbU6nPb2NhWhc+eaQOv5SaeLfpIKJy3VWzkHULx8G1ju7YS17nI+AGHgBNiA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: The problem appears to be here: if (folio_mapping(folio) != mapping || !folio_test_dirty(folio)) { folio_unlock(folio); goto skip_write; } in my version it's: if (folio->mapping != mapping || !folio_test_dirty(folio)) { start += folio_size(folio); folio_unlock(folio); continue; } In your version, skip_write doesn't advance start if it too many skips occur. Changing your version to match fixes the problem - or, at least, the symptoms. I'm not sure exactly why it's occurring, but the -EBADF (-9) is coming from cifs_get_writable_file() not finding an open file. I think this is a Steve question. With Vishal's change to use filemap_get_folios_tag() instead of find_get_pages_range_tag(), the most common file write case (open, write, write, ..., write, close) in which all the data is added to the pagecache in one contiguous lump without seeking, hits this a lot. Unfortunately, unlike find_get_pages_range_tag(), filemap_get_folios_tag() doesn't allow you to set a limit on the number of pages it will return. David