From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BBD50C7619A for ; Thu, 23 Mar 2023 12:03:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 21E466B0075; Thu, 23 Mar 2023 08:03:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1CB286B0078; Thu, 23 Mar 2023 08:03:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 093C06B007B; Thu, 23 Mar 2023 08:03:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id EB2B06B0075 for ; Thu, 23 Mar 2023 08:03:49 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id CA2221201FB for ; Thu, 23 Mar 2023 12:03:49 +0000 (UTC) X-FDA: 80600028978.05.B6AA429 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) by imf07.hostedemail.com (Postfix) with ESMTP id B6C8040016 for ; Thu, 23 Mar 2023 12:03:47 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=bnXNzBQw; spf=pass (imf07.hostedemail.com: domain of lstoakes@gmail.com designates 209.85.128.47 as permitted sender) smtp.mailfrom=lstoakes@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679573027; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TeiulGRJuAG8oV3+nSxuU+e5BdoA3oJAm0zh1OHOoQY=; b=X+PZZ/EImTbeuVT8d1cGSa19dOYuYq5R++TeZ/4emoNo8Ik7GgPe9Hvr5V194vicBMnxA4 RR2iFsUwjtQOOUzvHHlnAFYwZiA+NWzAk81kZlERULncMzsakrPw3EoPzWGjuioHkd4lYQ 86SgjnPO7+55XSgq3QMy2NFY/+bkdAY= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=bnXNzBQw; spf=pass (imf07.hostedemail.com: domain of lstoakes@gmail.com designates 209.85.128.47 as permitted sender) smtp.mailfrom=lstoakes@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679573027; a=rsa-sha256; cv=none; b=VnXWBJeFlO+H3u5v8Wktfdg5IUlW066mjXGo5DIQ5ptx09fd+LJpf4BHTTg7CSEopaiutw Bc9lvpBdK4IHTytiCakJNLEFH+TcsX1W44yaHEyXY9Y+7GSBLtw/F2mN0AFEfu3EctEE4J HnIIwS8NuRpEFNJIP6tFdkKIcKBY6vI= Received: by mail-wm1-f47.google.com with SMTP id n19so3089729wms.0 for ; Thu, 23 Mar 2023 05:03:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679573026; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=TeiulGRJuAG8oV3+nSxuU+e5BdoA3oJAm0zh1OHOoQY=; b=bnXNzBQwmOq0q/QSsr3o8zZd/0xdbYPBHZ59TxEv9j725JKXeofdx/aZeL1D8eCWaU WpIr6JBYOLWdXl1A+x28YtZq7kE5Ai3lL6mXIMZcWCAQWUqqROvn2j93rCjLu/OK7eL9 tlHdemCXTusvbjoGWj332SUk1MGBmDSwBhApsVpOpuIJvvlPfCmGk3/lqZEBprxRE7sf ZgX4Y5HnfaFT+YOqj18DjFR4/MZwUBZvlpSeFsyL/NmKvzjQPD7l6hEzJX891MhOvt1i UcOnu1kiUVWLhONtILhLB5frJPVUTtJCyEDDh+8a/A148wmIgmwMIksaZSS3n5WRckPP fsmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679573026; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=TeiulGRJuAG8oV3+nSxuU+e5BdoA3oJAm0zh1OHOoQY=; b=cp9+qNZ6rz0FwlLJK/Q/ppDxfLA7TCag9AuLN70JYeKTpVIRz9QGuaupjCJ+Ek4PUp eGwlh1gM0RqlbPX7BZT0BtEtWLnkjewNJW19zXPG811CItY5HT/U4H49A+KKfdSWdMCh dC+WIEzPYJut8ZPv5PZHWTqeCphYTbeO/1yYuORHWjXe4EHUAcUHg+hzH5cbBHgyzYj1 kkInnyQ2GjZ/wkP+cCNcZfCYRsEnaXWLLKKEa3U1YCSYUnSdkQ9ymS+CLpqYKZeNSEy8 MHcxUG+8LeuJ9gz2H0Pmm/qT8g9XyAPkUIRloVZf+G7JF6zfjJasOnGmJVyrlSuwCoXt ZhPQ== X-Gm-Message-State: AO0yUKWy777r/k20epG7qkS3ZEqG3k7sDvEw/MI0J6V3jJD7fcN2e8eS tRelxfq2/t9sZci7JOgAqkU= X-Google-Smtp-Source: AK7set/cQOWUea/d79eWNQjNG1Mc2o8W27XFk4hxmba5L79MsY8xd0cMreE4dc3uzSnvzx1xPhB7Sg== X-Received: by 2002:a7b:c409:0:b0:3ee:2b04:e028 with SMTP id k9-20020a7bc409000000b003ee2b04e028mr2231927wmi.14.1679573026088; Thu, 23 Mar 2023 05:03:46 -0700 (PDT) Received: from localhost (host86-156-84-164.range86-156.btcentralplus.com. [86.156.84.164]) by smtp.gmail.com with ESMTPSA id s15-20020a05600c45cf00b003ee2a0d49dbsm1695390wmo.25.2023.03.23.05.03.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Mar 2023 05:03:45 -0700 (PDT) Date: Thu, 23 Mar 2023 12:03:44 +0000 From: Lorenzo Stoakes To: Arnd Bergmann Cc: Andrew Morton , Arnd Bergmann , Nathan Chancellor , Nick Desaulniers , Tom Rix , "Liam R. Howlett" , Vlastimil Babka , Suren Baghdasaryan , linux-mm@kvack.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev Subject: Re: [PATCH 1/3] mm/mmap/vma_merge: actually set next to NULL if not applicable Message-ID: <21236776-232e-4653-8bd0-8a2dcc6fe63c@lucifer.local> References: <20230323115903.1483668-1-arnd@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230323115903.1483668-1-arnd@kernel.org> X-Stat-Signature: 53ndcyugi3irouypi6r57f69mwwi331n X-Rspam-User: X-Rspamd-Queue-Id: B6C8040016 X-Rspamd-Server: rspam06 X-HE-Tag: 1679573027-860042 X-HE-Meta: U2FsdGVkX192zxKnVxavr1u8OPaEYOo6ZO0MPk4ADimEgeYi+Y2blgDH2/9wWXVlIsj2lubVzkQOWJHRlKWaRhBRehzXiMjPXJ2bDfCRDUrizRqat5grOD06ZkAG0Qd6sH7eeKmUgUXOwztomE6XgJwOdlcazLDPxIFCv/luXXfQL8AzMttZyWlRG426k8Fn3XRZJJta6vxQPzxr5xocTrQupR+hTAJtdBR1R31GPiV5bLqvEF/y2Ejl97dzhCfytBXTR2qd2wyuJxjUaAypxIME9qwIC/agLg8LKVUSs5HYLKVWiejN4571LxwTdjKktdueuRAJDld7JOUYsfjP8T7mHthm1ADhFvxAEjx4yi2Phu/bSyf8gx2WdrYJHUTA0ZctLAITtWDAESnTQsNKW+o55pgYmp8SboTrHCbvTtiPETsdcD7IBiNzQySkqG6mkVBBTfsBH1eKa49QyrA2V0/QsKvgLiYieKjCSm/WohKJlH11jH8zw5KJr0S1gSEjaJWY2Tzr0ZjOfDMrsIUKuXREvkYKTCVNJcIki8vKW9ccJoXOOcuadp21XybQYviwdMTlJmE8JnmsSEuySIZUF63ViM59VmJxeqhRNiKVf1PA8nHVqRZr5kkD/e3AXFRYBa++4876jAFMbRz8IXUKWb10q2pZlERKWPGbE411qICtNBrhbA3zvPEzv/K0EGYa1osjVD2+7f4P/XOWzFeI6knhkOhwlyCQ4f4KrRmK4cYS2PX9h7sdnkSBQk+vtHFyKOz5SdV/ahmnmmx6ct6vu0YT8E/Z1CFb+OI6B1Bjug1CVFQ8GAzq8wgxsjOpWQZ0LhKIUFyvgMBwLXM0ounHpbXfQFlGpedXNNKSBub4L3XoXialYSNUDq5BIJxZiAZoOg+5/g6wz21/+Q5BwDXGoYLZYRW5A9XWExLGu/z2Cs9iz+HgL7DPA+5lbhQ48BELtW3fMlVrz47hvNFOnWr rM37kyov nz0aIFlUUHTw4fyyq1Y8b2Y9X1nM/zWfRpw8b3BJKXLkNUpFx23OvAGMV73ITeN+tI8jO5JdKOSMAYfQ6k8Kuu+a21rdwgVbhuPePHGlKKomPEVh8Pup1+KnH3mAWwW2XIPG9caDa91ugVd+8PT2rk73zeTrkRahVBAbkr2MAvJPQBKkxPO7GKI34weNZ6dNvZ7AZB6RkeyynSkAiNx/l/l6Co3pmrs3NRq+XaILvnmId1cgdoV1KQ4l+T4ppHovl1c7uaHSIgSung2LoBhTLHS1vUOytUxNlblh2JpOu4C/qJOBGmQYcbn3JHFTYhhak8Si9G80KWgjkrSGpOzixbirPPgT+7urxZQJbnB3XAbHhvzqmBF+LLyljcKlCZ3OKE/nNvFzl40yTAf1we+++5jz9uwUANEbeEtgISNBBLx4PHb/VxoM4Op419BH9NRFp6yFS+gcGlmGQf2qX3uO0SXmBM0cMWLJEu8pXv/LTQ2AwEknIPnz4FD4Uqa+iROkkzHqDzlxNFIh1MOBP9TS4RoZPNpg7bUKakxlz X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Mar 23, 2023 at 12:58:34PM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann > > As clang builds point out, the variable 'next' is now uninitialized > in some conditions as a result of a previous patch that tried to > rely on it being NULL here: > > mm/mmap.c:939:11: error: variable 'next' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized] > else if (!curr) > ^~~~~ > mm/mmap.c:952:15: note: uninitialized use occurs here > merge_next = next && mpol_equal(policy, vma_policy(next)) && > ^~~~ > > Fixes: e887ecae997e ("mm/mmap/vma_merge: set next to NULL if not applicable") > Signed-off-by: Arnd Bergmann > --- > mm/mmap.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/mm/mmap.c b/mm/mmap.c > index 54099a604cf8..c01d43bd694e 100644 > --- a/mm/mmap.c > +++ b/mm/mmap.c > @@ -939,6 +939,8 @@ struct vm_area_struct *vma_merge(struct vma_iterator *vmi, struct mm_struct *mm, > else if (!curr) > /* Is there a VMA next to a hole (case 1 - 3) or prev (4)? */ > next = vma_lookup(mm, end); > + else > + next = NULL; > > /* Can we merge the predecessor? */ > if (prev && addr == prev->vm_end && mpol_equal(vma_policy(prev), policy) > -- > 2.39.2 > This was already fixed in a more recent series of this patch set (at v3). Sorry for this reaching -next! See https://lore.kernel.org/all/cover.1679516210.git.lstoakes@gmail.com/