From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2B28C5AE59 for ; Tue, 3 Jun 2025 17:55:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 620196B04DE; Tue, 3 Jun 2025 13:55:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5D0806B04E0; Tue, 3 Jun 2025 13:55:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4E6B66B04E1; Tue, 3 Jun 2025 13:55:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 362DE6B04DE for ; Tue, 3 Jun 2025 13:55:36 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id D6C321D74F8 for ; Tue, 3 Jun 2025 17:55:35 +0000 (UTC) X-FDA: 83514841830.18.8AE0ACF Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf13.hostedemail.com (Postfix) with ESMTP id 5BD8520007 for ; Tue, 3 Jun 2025 17:55:34 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Nxai5nHZ; spf=pass (imf13.hostedemail.com: domain of broonie@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=broonie@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748973334; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qomRGX8M2qk/M0e6ZxoYq78bDD8jLSollfEjgres6Tk=; b=Z36NguQ8unhqMoDy5o5GYNC3Nu/XdzlO9uzA4fW6NVA689guxjpo8qwNb+oGExzV3IOgnh bEEbn/1DdTu2jYdSq/sn3XOTNT5s1e0b2CgPJUCix+d7IQY1VTZudpPgET02Ws9ZjTdD9I 2FfpHJJ4CnsOvC0+YvzQexMhwzUqYCs= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Nxai5nHZ; spf=pass (imf13.hostedemail.com: domain of broonie@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=broonie@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748973334; a=rsa-sha256; cv=none; b=3xt0XhBO5fRbXdRLvPBVDzWx5DVkazriRssE6YLGBm9lYevUndt+Tz5O53awYu3/gQf9mI CqQms52vRdSSdWt7V3M/tzz8JLC02VSOCNoPrDqprWmMU/qmreYkvrRKXLfhF2gLe+zXlY WKf0m0Dyy4bmQZAvS8mPWPogMt+u8qs= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 9BA1A61129; Tue, 3 Jun 2025 17:55:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C51F2C4CEED; Tue, 3 Jun 2025 17:55:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1748973333; bh=BqpJYvEEm44Wut0dEbEcSr4ol/Oxc8jp7Jp3kQ74+iI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Nxai5nHZqWlBY5TDc4svlBTtJT8OHagNBIDoJDmHFQWwn/Oi28apk2DwLrDknmu+k xRVXoO5KkD1ytkkP3iBuZpA+HnfdfcHIiIlqSw2Nhc4hbvCfT5MSEeVKwlhK6klNbN 8F7ZjmnSdHUw/amg5AdQ3u/6yWmi6nLPjsWUUqij/iVoMXN9LPYFRPPMWSu6O0piN7 yvfQIz5qTbyuXyrmnkWHWhAcSwt1my5bsbOqrzUdn9EmgbhuALaOhKS8/7+aRsCru2 WsFKfUXe9TGyoh8ygrgrLbvYlcIMJqv+23kCOz6r1dGGQ8yMtmj770TDWRrIJ7fnuk rYhC5TInUT1Lg== Date: Tue, 3 Jun 2025 18:55:29 +0100 From: Mark Brown To: David Hildenbrand Cc: Andrew Morton , Shuah Khan , Lorenzo Stoakes , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 3/4] selftests/mm: Report unique test names for each cow test Message-ID: <2117dfe4-befc-4fe4-9b5f-184433299494@sirena.org.uk> References: <20250527-selftests-mm-cow-dedupe-v2-0-ff198df8e38e@kernel.org> <20250527-selftests-mm-cow-dedupe-v2-3-ff198df8e38e@kernel.org> <9961082f-848d-43d3-b97d-3df675ca4415@sirena.org.uk> <4676a010-a977-4d5a-b42a-edbbea7d356d@redhat.com> <27f74a9c-8bf9-4877-ba14-82dcd79f6d0d@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="9K5Lxces5yzC9hI4" Content-Disposition: inline In-Reply-To: X-Cookie: Avec! X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 5BD8520007 X-Stat-Signature: dq7gqctuiy4db3pgr94kmq5iuyt1oyki X-Rspam-User: X-HE-Tag: 1748973334-449543 X-HE-Meta: U2FsdGVkX1/SJfZ/Q+KFJzrxKes6u5gEzqNeVonIt91jwsC68DSTM9V1CaglEIFmo2vrySIFDs96r4+p887128H2db/5kGwz+16mibxXkdrAhJc93FXhYgFZTm9R2bMyB6kKqfGYkjXeoPzkICdVPYaacgNHiem1uHlcfLuiIITEokww+i0Xit7k1mucSMPath92Uq4mJXklw2ctfoQeAACLyAwQHeuNgd3YD9J8nXUaDFMTK4L/fVsGcM6scfqspinW+k5fBS/ymY5oyQcJW9QnWDh63MGRuBnyQK9sIaQBHZKXJtSUzNPgb3KpJSnHz6xt+4XC0fQ55AayHiQySFqbCQXWuR3TNjPdO5PD+JikgJTf8IhCps2M5GOdKBIBHxNl1cn1sEvz9Rdmfnun/6Dw1CPi3S6yGYcOrxXP7HDRe3GrZFWAXRL/Vh4QV2WiRFqTxVYRwmir/FnyLttmMV1ru3YksX7zc1aq00QIDlBpgUp7XZWadCSjFki+4oMNQtP68lnlOa2xgp72o04iSCrPqAloePaR3v4j1ohWq2TFE8Mlzp9btcUi84C7Q43jKDGrC5maEunI4Oo+CHuglbDxIOPAzK3OXcQr6yC2RbhsI8e83hiqX7ooGlQGBgiDLpyeEVfR+8yi1363R+q1YypB2sGUVHi5yXZFzvisYEtcY+5NusdBZqmIHUAlpwjvde7IX4uYgDW2TAP/IWL4sQZSvazBcOg76AgwA9mgF06f7g8bUk/WQh6arlMHtNBJOBkPIOLw16tF8AZIltFUPn3yJA9UXB/+lAc/BXzkiCejVpsRmsmqDBXnyJTcYjqfq21HenyeSWTVS+/8qK7jznr/t0tvj92OFuboBUcAfPCHqx/yeOY/wG005c50T4GvdOepy6QcfyUtb2AqRFVY7RDfylQKgYWDTdgcqhN2hwjBGhfqCUtkip7pxqlDP/CTBn2tn4NdzOs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --9K5Lxces5yzC9hI4 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jun 03, 2025 at 06:48:19PM +0100, Mark Brown wrote: > On Tue, Jun 03, 2025 at 06:57:38PM +0200, David Hildenbrand wrote: > > I agree that printing something in case KSFT_PASS does not make sense > > indeed. > >=20 > > But if something goes wrong (KSFT_FAIL/KSFT_SKIP) I would expect a reas= on in > > all cases. > >=20 > > IIRC kselftest_harness.h behaves that way: >=20 > That's mostly just it being chatty because it uses an assert based idiom > rather than explicit pass/fail reports, it's a lot less common for > things written directly to kselftest.h where it's for example fairly > common to see a result detected directly in a ksft_result() call. > That does tend to be quite helpful when looking at the results, you > don't need to dig out the logs so often. As was the case with the prior: /* Finally, check if we read what we expected. */ - ksft_test_result(!memcmp(mem, tmp, size), - "Longterm R/W pin is reliable\n"); + if (!memcmp(mem, tmp, size)) + log_test_result(KSFT_PASS); + else + log_test_result(KSFT_FAIL); =20 --9K5Lxces5yzC9hI4 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmg/NxAACgkQJNaLcl1U h9AYLgf+ISgFWBb0M/8bRo5cBiZ0eLhHKK91ccJp2NsN17X4/KsfEJDXpDoU5jmJ VBfAHk3KYWoNUHEgISMveAvjx7VNrbiK2rwtKz0MWtoj/IeUUgnVINfng7+H+sZA 1Cr6IiChsu/NX4rBUyoChrgKcPyj3VwI6/MaItC9nCblcsJdqCCpDOq/pg2R3WVB 0ZZWo2cOyOW68Bn+TO5Y3PhX2T6VonJbH1NedXvqU0zQOILaUxkvgWqwIDqgIEpX 2Eii26c8nDis/YP/4aty3w7lRi32KSP+eY3WyUNaDFQQNYY1CrvLbnUcladl7fBb Bo4eil1iXsv3RyDy0ryj+0J7YzTVfw== =7hL4 -----END PGP SIGNATURE----- --9K5Lxces5yzC9hI4--