From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77380C433EF for ; Thu, 23 Sep 2021 15:34:54 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 14E7F6103C for ; Thu, 23 Sep 2021 15:34:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 14E7F6103C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 5486D900003; Thu, 23 Sep 2021 11:34:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4F7CA900002; Thu, 23 Sep 2021 11:34:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 398B1900003; Thu, 23 Sep 2021 11:34:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0064.hostedemail.com [216.40.44.64]) by kanga.kvack.org (Postfix) with ESMTP id 25CBE900002 for ; Thu, 23 Sep 2021 11:34:53 -0400 (EDT) Received: from smtpin32.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id B04622FDFF for ; Thu, 23 Sep 2021 15:34:52 +0000 (UTC) X-FDA: 78619236024.32.8B8FFCE Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by imf07.hostedemail.com (Postfix) with ESMTP id 4FE8310000AD for ; Thu, 23 Sep 2021 15:34:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1632411291; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=B6vU7I66Oh4IvVlNoUJK6FShhyszDTfSEBuK0IXxA/U=; b=B/b0Ij56L4nxhTS01WGLvOi5pc7UNGaoFFuwXruZ8mG8degF0hQMU0TWWcTNr6dRQmpf+H 7kdX1oWeSoNGdewKXlGjdlYpgJcNXobKLLSPcjw543YwuvtqQm7ViP/EW8iR5jW4hyzWC8 CNIVPTVvHcDiTg107j8T+z6KDSiImU4= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-433-CqFR3cXMMTiplCWgm04sOQ-1; Thu, 23 Sep 2021 11:34:50 -0400 X-MC-Unique: CqFR3cXMMTiplCWgm04sOQ-1 Received: by mail-wr1-f72.google.com with SMTP id f7-20020a5d50c7000000b0015e288741a4so5488709wrt.9 for ; Thu, 23 Sep 2021 08:34:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:to:cc:references:from:organization:subject :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=B6vU7I66Oh4IvVlNoUJK6FShhyszDTfSEBuK0IXxA/U=; b=agnEVzaJtaPlJ/P27ZxmUO/PCOE2Tcl92oS4h1sDXGdNXcqgvUKjDG8AY81Ur8wg71 xzEGpcZVCeT96X8DVxx3LQaLTQagpixRPY+lfl5pAPNDmSul96hL+n/cpE6gHrhGnXS5 +h+3PRhGvUBxZfyUTT6RVlTM2mFyi2DrjDKhaxMsmtcxRrT85jg9ovIM7JMCBj2AF+D3 CIOUysrlExf10lGWLM3uOnkJ6+zVEsunXerMTm/e2Nq8gwQ1dmyKgBUzqSVzSJIYzyQS cRH4ayxsfEy3PMYEM/nj1FpKsXwqQJc5i8pFmsJj9Wk6R7sPkiQeGGaTpQGhLlohOv61 QsAg== X-Gm-Message-State: AOAM533u8s6bgEha36plZ3orIkf5h8mCtL+21mwZkrKA9fVXvd7yNhiC 3wpHjIQ3ZS/+5d/k73lCL8erG9exGecBW4uJLKY4esUbHtA7O0w472k2gYm/PJAriOPDN+LroNy SLm1acAqxNRc= X-Received: by 2002:a05:600c:4a16:: with SMTP id c22mr16730722wmp.72.1632411289511; Thu, 23 Sep 2021 08:34:49 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxBZhyVs/6Bg7XD0uHKGpE7WMvutAt47Dpksuv26PSDqXvvl4mTPp5CHm/1FAbKd+sEANHxSg== X-Received: by 2002:a05:600c:4a16:: with SMTP id c22mr16730710wmp.72.1632411289286; Thu, 23 Sep 2021 08:34:49 -0700 (PDT) Received: from [192.168.3.132] (p4ff23e5d.dip0.t-ipconnect.de. [79.242.62.93]) by smtp.gmail.com with ESMTPSA id b187sm9825989wmd.33.2021.09.23.08.34.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Sep 2021 08:34:48 -0700 (PDT) To: Kent Overstreet Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Johannes Weiner , Matthew Wilcox , Linus Torvalds , Andrew Morton , "Darrick J. Wong" , Christoph Hellwig , David Howells References: From: David Hildenbrand Organization: Red Hat Subject: Re: Struct page proposal Message-ID: <2116e35d-019d-67e3-e163-a0ef0a821a87@redhat.com> Date: Thu, 23 Sep 2021 17:34:47 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 4FE8310000AD X-Stat-Signature: d85dhijjpp886rh7cgupekkqsueuobwn Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="B/b0Ij56"; spf=none (imf07.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 216.205.24.124) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-HE-Tag: 1632411292-809227 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 23.09.21 17:22, Kent Overstreet wrote: > On Thu, Sep 23, 2021 at 11:03:44AM +0200, David Hildenbrand wrote: >> Don't get me wrong, but before there are answers to some of the >> very basic questions raised above (especially everything that lives >> in page->flags, which are not only page flags, refcount, ...) this >> isn't very tempting to spend more time on, from a reviewer >> perspective. >=20 > Did you miss the part of the folios discussion where we were talking > about how acrimonious it had gotten and why, and talking about (Chris > Mason in particular) writing design docs up front and how they'd been > pretty successful in other places? >=20 > We're trying something new here, and trying to give people an > opportunity to discussion what we're trying to do _before_ dumping > thousands and thousands of lines of refactoring patches on the list. >=20 This here is different: the very basic questions haven't been solved. Folios compiled. Folios worked. I stopped following the discussion at=20 one point, though. Again, don't get me wrong, but what I read in this mail was "I don't know how to solve most of this but this is what we could do.". Would we want to reduce the struct page size? Sure! Do we have a concrete plan on how all the corner cases would work? No. IIRC Windows uses exactly one pointer (8 bytes) to track the state of a=20 physical page by linking it into the right list. So what would you say=20 if I proposed that without tackling the hard cases? Corner cases is what make it hard. Memory holes. Memory hot(un)plug.=20 Page isolation. Memory poisoning. Various memory allocators. Lock-free=20 physical memory walkers. And that's all outside the scope of filesystems. --=20 Thanks, David / dhildenb