From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BB71C27C6F for ; Fri, 7 Jun 2024 07:19:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B09226B009D; Fri, 7 Jun 2024 03:19:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AB8276B009F; Fri, 7 Jun 2024 03:19:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 93DD96B00A0; Fri, 7 Jun 2024 03:19:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 742E26B009D for ; Fri, 7 Jun 2024 03:19:16 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id F19E4A17E5 for ; Fri, 7 Jun 2024 07:19:15 +0000 (UTC) X-FDA: 82203241470.20.1A38B4D Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf26.hostedemail.com (Postfix) with ESMTP id 888B3140015 for ; Fri, 7 Jun 2024 07:19:12 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=J+Y4LT4e; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="HYB/qIxC"; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=J+Y4LT4e; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="HYB/qIxC"; spf=pass (imf26.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717744753; a=rsa-sha256; cv=none; b=b4ZT6K8PdG/tbMCdR9RNhwa6+NGvlC3qykRzfIK1g1gDm85A9Ogzxik//D16jhZvvOtpki +RysEuph4wAuLB8AAE47lLSuT9iJ8stLqqFvr0Q70Au81YB7O3xa9GitVgwzq8fR/Nf+eb TyA/kGbtG5/D5P/MDjhJ4BzDKWh/dTU= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=J+Y4LT4e; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="HYB/qIxC"; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=J+Y4LT4e; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="HYB/qIxC"; spf=pass (imf26.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717744753; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Cum8zSN+Lk2ZaAZKd6SaSp6UIPpMMmmcaIXWYwzxkN4=; b=lLerqTA8ymeks1LX6VcT372jQs4HzXr4ktGAkC/RyZKsfKBVhTH/Qgmgcr1dJseZmVTSLm rtlD59BTpNeklVtJH5lGdoap1ugKndj0n98zW39O3jOnYV/4K1g9QexEaVmWsv2nzg+XpZ j3bGn3/8718SmPblKQFnIaVgZQDV9BA= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 7804A21AF1; Fri, 7 Jun 2024 07:19:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1717744750; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Cum8zSN+Lk2ZaAZKd6SaSp6UIPpMMmmcaIXWYwzxkN4=; b=J+Y4LT4eQyfa+2k7YLlwFS8IgfXCdkR/GnwNLpHoRQ/NBygEinCbHWEVoA3SV8bruA1RuO EXC97R1deDcm0a43LaLRthawW5gT2gCO3+80hqiGF0w9hFzs2Nbp/QkBHJaBY2A2ZKOKDn cFT0mYwy+Q2rz9yvBYyCAl5atx+CDa0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1717744750; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Cum8zSN+Lk2ZaAZKd6SaSp6UIPpMMmmcaIXWYwzxkN4=; b=HYB/qIxClOWuODR30ltS3v63p0hyzE1a6wTiFzQfj1U+czOxK7IXr59ZB5cUSPq8+B3J9o NDD5kzMhOULN1yCg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1717744750; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Cum8zSN+Lk2ZaAZKd6SaSp6UIPpMMmmcaIXWYwzxkN4=; b=J+Y4LT4eQyfa+2k7YLlwFS8IgfXCdkR/GnwNLpHoRQ/NBygEinCbHWEVoA3SV8bruA1RuO EXC97R1deDcm0a43LaLRthawW5gT2gCO3+80hqiGF0w9hFzs2Nbp/QkBHJaBY2A2ZKOKDn cFT0mYwy+Q2rz9yvBYyCAl5atx+CDa0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1717744750; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Cum8zSN+Lk2ZaAZKd6SaSp6UIPpMMmmcaIXWYwzxkN4=; b=HYB/qIxClOWuODR30ltS3v63p0hyzE1a6wTiFzQfj1U+czOxK7IXr59ZB5cUSPq8+B3J9o NDD5kzMhOULN1yCg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 60C5E13A42; Fri, 7 Jun 2024 07:19:10 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 9oRIF260YmbCcwAAD6G6ig (envelope-from ); Fri, 07 Jun 2024 07:19:10 +0000 Message-ID: <210c320e-4b85-442e-870f-32647838a497@suse.cz> Date: Fri, 7 Jun 2024 09:19:09 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] mm: convert page type macros to enum To: Stephen Brennan , Andrew Morton Cc: "Vishal Moola (Oracle)" , linux-mm@kvack.org, Omar Sandoval , linux-debuggers@vger.kernel.org, "Matthew Wilcox (Oracle)" , David Hildenbrand , linux-kernel@vger.kernel.org, Hao Ge References: <20240607001116.1061485-1-stephen.s.brennan@oracle.com> Content-Language: en-US From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: <20240607001116.1061485-1-stephen.s.brennan@oracle.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Rspamd-Queue-Id: 888B3140015 X-Rspam-User: X-Rspamd-Server: rspam12 X-Stat-Signature: jus7pyiozn5snayrie1w5zkcpck6p3ty X-HE-Tag: 1717744752-990725 X-HE-Meta: U2FsdGVkX18CUY3rNHgJ2PUsQWh6rm8kdjEnK/qxKQBplz6soJJRbg+uj4MGpqej3zHot9SLn/hrqFtv1B+ZJCfehZzPGV7nIKsziyfEB30zJUx0B1mLG1sTIvLoL7iT4utn8mE70CjMiV2vDGqw/KiJ/hYV7rWYuPAv2SM7tK8FpfNxv0LpBT1ROZ9OR4uFNeYzbWCnaS4kVDd7sNEFwotJCM/Vi25HF9bkZSmoMUQEaJEPNNe/vGroVG2csLJw39hq0m3O5YEVBHPOAkPSwa2BTv5278F7dxQmCDC9Ur/mRJQeiP/2iS4Y6OD7lCxSTTE5JUou1+cPv6vydQkB44+S04PE56D0AhrExKlgzi9aOPrgznAWBNRzA9F+IQUA0UCfl9jVjDTfzCN2zK3sQuVtRX2kOQjpbFfZyFHzi0TZsmEn+Uh639sZXuyKKcr1sSGVZSG2OcPDOLrs1sxoNEbLo0lnlulHWKDCdbfX1vhlgVwntWjM156skjm1+u+S0/QQNz3O5SX6GKdubuDMdbxztSLZD/SKpZEo7PtWqS/rJdtDe3g038XUKEUk6A8QjeG/311lyVp9pkFuWe2Oi84ahS0cbK1iafWk57uiVOYKeH9W28RztNACfXwMvGUpZuRmmd7aXDDmByJGFp2CgWgQuPfwjc7PFVEiNwckDH656bCymoMQpc2cISXK4Db8d3gio8xXPlZOaL1B8e1rrLrlFGZaxWxNhMiKxO0kGPbluaWU9gag4uvyV297NXNYC8B/tj5cIBXSR3vZq5TKfLSiYTePKUqHfj3VCyt3PhL2l+zUqlSYVlIwnkmBquNkxquCRY7zzM87W+0aeoeIDYlNz+zdQZxrdlTPEnGMWKtNqSufpq28dNbuvw6fOAXZk6Q6OebaBj7VgnODXiYDLNBWD1YmjioMBj8IG6VpWq76Q70tZSD4NDJIPgaGirHICEWL/FaBt0SB7NfxPv+ EckoVUNt pYPuh/f9/lgcUICvVM3zr27R91qawJ1R2KC45gbYlwyxhZPXtlnMuArYMtStHfB4+w/2/NGxbnsKupjS8av/SmCnDQmdNTHT2OMpWYg2AmGsjKtYgDikHCLw5QiSJz4/32LojAvy76iWsf3Pp+J6d5CkhjJW0Rs2u7RXMYraoTCct0as29VaQHGoihb5lTWTd62LYrbXEhQRYUPUmZR07V6Aal/rFXZRLzt2UpKGvTH/aqRQrlsEXvUJJbwEDwJTsZCOMVGIPmpRBPWG2lYG3uPEzp+h2gGquE/RTAWJqXyWUrcd/k2E18ilzKaNWW5tJPS7n4cxKLDonjr1krwiFft/ZEtMH52De5kUxQ1EDRhyEskg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 6/7/24 2:11 AM, Stephen Brennan wrote: > Changing PG_slab from a page flag to a page type in commit 46df8e73a4a3 > ("mm: free up PG_slab") in has the unintended consequence of removing > the PG_slab constant from kernel debuginfo. The commit does add the > value to the vmcoreinfo note, which allows debuggers to find the value > without hardcoding it. However it's most flexible to continue > representing the constant with an enum. To that end, convert the page > type fields into an enum. Debuggers will now be able to detect that > PG_slab's type has changed from enum pageflags to enum page_type. > > Fixes: 46df8e73a4a3 ("mm: free up PG_slab") > > Signed-off-by: Stephen Brennan Acked-by: Vlastimil Babka > --- > v2 -> v3: rebase on mm-unstable > v1 -> v2: include PAGE_TYPE_BASE and PAGE_MAPCOUNT_RESERVE > > include/linux/page-flags.h | 31 +++++++++++++++++-------------- > 1 file changed, 17 insertions(+), 14 deletions(-) > > diff --git a/include/linux/page-flags.h b/include/linux/page-flags.h > index f04fea86324d9..7c0a8fd2c8c17 100644 > --- a/include/linux/page-flags.h > +++ b/include/linux/page-flags.h > @@ -945,20 +945,23 @@ PAGEFLAG_FALSE(HasHWPoisoned, has_hwpoisoned) > * mistaken for a page type value. > */ > > -#define PAGE_TYPE_BASE 0x80000000 > -/* > - * Reserve 0xffff0000 - 0xfffffffe to catch _mapcount underflows and > - * allow owners that set a type to reuse the lower 16 bit for their own > - * purposes. > - */ > -#define PG_buddy 0x40000000 > -#define PG_offline 0x20000000 > -#define PG_table 0x10000000 > -#define PG_guard 0x08000000 > -#define PG_hugetlb 0x04000000 > -#define PG_slab 0x02000000 > -#define PG_zsmalloc 0x01000000 > -#define PAGE_MAPCOUNT_RESERVE (~0x0000ffff) > +enum page_type { > + /* > + * Reserve 0xffff0000 - 0xfffffffe to catch _mapcount underflows and > + * allow owners that set a type to reuse the lower 16 bit for their own > + * purposes. > + */ > + PG_buddy = 0x40000000, > + PG_offline = 0x20000000, > + PG_table = 0x10000000, > + PG_guard = 0x08000000, > + PG_hugetlb = 0x04000000, > + PG_slab = 0x02000000, > + PG_zsmalloc = 0x01000000, > + > + PAGE_TYPE_BASE = 0x80000000, > + PAGE_MAPCOUNT_RESERVE = ~0x0000ffff, > +}; > > #define PageType(page, flag) \ > ((page->page_type & (PAGE_TYPE_BASE | flag)) == PAGE_TYPE_BASE)