From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8A96EB64DD for ; Tue, 25 Jul 2023 03:18:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 225598E0001; Mon, 24 Jul 2023 23:18:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1AE9B6B0074; Mon, 24 Jul 2023 23:18:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 027A48E0001; Mon, 24 Jul 2023 23:18:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id E40386B0071 for ; Mon, 24 Jul 2023 23:18:18 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id BAA3B140BBE for ; Tue, 25 Jul 2023 03:18:18 +0000 (UTC) X-FDA: 81048675876.18.AD05F07 Received: from out-22.mta0.migadu.com (out-22.mta0.migadu.com [91.218.175.22]) by imf26.hostedemail.com (Postfix) with ESMTP id B536314000D for ; Tue, 25 Jul 2023 03:18:16 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=HAeGJ99i; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf26.hostedemail.com: domain of muchun.song@linux.dev designates 91.218.175.22 as permitted sender) smtp.mailfrom=muchun.song@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690255097; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=keHNwQXyGxB+2fa9SqrEE3DvQ5TME2b5TMHAzSBP2pw=; b=pIJbroeCLY3GJK8Ml9nISDp4IE0qtTtLBqLGEbL+TOe2cQvPLPENqLAhi9NKZdotOF00dV Fz12e8BqqJCEtpx8EfLXjDN5kfLKneuYqEihuWjRxT7kq8JbINvVpvAFCBjw2VefYsrhRT uYQNKbEIQ00waF3oJZ3FSrqMJ/aaDDs= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=HAeGJ99i; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf26.hostedemail.com: domain of muchun.song@linux.dev designates 91.218.175.22 as permitted sender) smtp.mailfrom=muchun.song@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690255097; a=rsa-sha256; cv=none; b=xZF+XnUGzJMKwbQCuBuSuBJR4wJCwB+FgwbGdEi1t2az0g3HTPuvW0/jcxEsoURy+ZcoA6 0NxhyxYLX/JmfPAhG64ENmOe1tAF6Gqtg4tehJMJ2jx3GKczQExVlX0z98nvqT1Mi6K0MU NQQj1O9h+V8DmZyAWf4MTKzYnr1JXNU= Content-Type: text/plain; charset=us-ascii DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1690255094; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=keHNwQXyGxB+2fa9SqrEE3DvQ5TME2b5TMHAzSBP2pw=; b=HAeGJ99i5xFhmj3CijzGTxYLYsS22+UCkxr4poXrv7YrVuJ+ys1PsTwIPg8xpWVSxn9zir H57AkKYqiD1vOZNVzVNI7GcU+WBHpxaXuuBnNpw5g5o1ZYYgFiQKUmRNmm30EbXVxytcjf W5muscH4uShV5wnAUhi90ZLbjVnLzlo= MIME-Version: 1.0 Subject: Re: [PATCH v2 02/47] mm: shrinker: remove redundant shrinker_rwsem in debugfs operations X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Muchun Song In-Reply-To: <20230724094354.90817-3-zhengqi.arch@bytedance.com> Date: Tue, 25 Jul 2023 11:17:24 +0800 Cc: Andrew Morton , david@fromorbit.com, tkhai@ya.ru, Vlastimil Babka , Roman Gushchin , djwong@kernel.org, Christian Brauner , "Paul E. McKenney" , tytso@mit.edu, steven.price@arm.com, cel@kernel.org, Sergey Senozhatsky , yujie.liu@intel.com, Greg KH , LKML , Linux Memory Management List , x86@kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, linux-erofs@lists.ozlabs.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, linux-mtd@lists.infradead.org, rcu@vger.kernel.org, netdev , dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, dm-devel@redhat.com, linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org Content-Transfer-Encoding: 7bit Message-Id: <210C013C-AB14-45BC-AB2E-199FF7F5E523@linux.dev> References: <20230724094354.90817-1-zhengqi.arch@bytedance.com> <20230724094354.90817-3-zhengqi.arch@bytedance.com> To: Qi Zheng X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: B536314000D X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: tq7rydj7tp9cstmkw88y5c7aamfbdp4x X-HE-Tag: 1690255096-926841 X-HE-Meta: U2FsdGVkX18Xb8zeIv+wbhBTLgTWWi5wlqGLvXyZE43SWplzJ+uwzOBHY48w4uZmKM3elFaMOZ94hu9qkSppTgTLP732Khb4D0JwKKLhW2vP0N9cDs2IXsRQM58bv+DI7UFnjLt+SGoFCSgeSotcw/F7EDfKuS6OVLTms8hg2KM/cvdY8JadTHewtSMYn9zrdmtzov3SgzMPqZ+Uy2HcYosvfnca3eaxHX8rms+ulzUQHL3+uR4xMPa+HRrVZOntmHdxQfn0qesOQYkXT6LwXEZxriWvzssPQENKGY3NIywtcUA4o+ahxGfouVQlrhDP18ADDL6LW2Mwk1ddtkfu1iR9Rzd8VD1tZt+I1Yiho2EKFLoTel5zq8pdyDOsOsJA63IyHK4Y4hP3+sSPsjdh50jK7lpRffm19HILNf6kjXoP45B2yo2S7z5FJqrLprGwIsBcRFeBZf1dEb0cAX8RUBs/v8wQfUiczdPJFZAFZo4V+73y3JJrrNw3ZC5swjI376tMItcYkwwLi8SEVYAzGJfl39D/uO/SjoWubV0fEclw8mfcmRQscYgm0kRON6QWCSOF7OqUKBZFa+UCLZDxgTsBdhMxNaelFWGv5eTCFgNQxquHs96jHdzKvkiE0+bYVe4Np3W9iFjwCTUDVe7PnVE/cukKIlp+VzyTnAI9jJME1GemDiRghxOsFaoXvlEk/2tYptQki3S64mNJetLuy0bZKTkiSQ3UitXLLHxZ3XYfRITu4Fj6veuySNMhT7dNW6Q8WqjbLUSr1X3Y2MqIsS5F+X3woh21EExSlh80UpN6Ay29wUhuqRjtHb0hbIp5TGsuffRT2a1ZZhp1xrHw+qqCiBHTaSiYhxl5IZya0Vs4JrNqGtTUUOs+3k13tWmsL64gtk8cCyV+bqWc7qRfhrmQkGvIspiENa278JJhkR0aalh+woqaG1Ma1dRcFL619oZkisrXBPJLTduDIjv aouTpi4e FOOR8Xhsum/8qWTa0liV36EDIvWbrcs7ewwbMY00VaBn4uTHKuwLq8Mkb5UdK+fVcXRgYHwzOPl2xGGNMb2rBGYz5A50YBcaJk7ZLBGD1yBF+OpOqYzYO3un4hhlqLg+yRhCa3XFRAAHg+XDyR4AYzF/Dv5E9LXfxP+kE8AW635ECRHtdOn9R7/Q47CZCYmPbxQIVvCSjb41sgMie3dbq0xr4abAsWd3EKf+i X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > On Jul 24, 2023, at 17:43, Qi Zheng wrote: > > The debugfs_remove_recursive() will wait for debugfs_file_put() to return, > so the shrinker will not be freed when doing debugfs operations (such as > shrinker_debugfs_count_show() and shrinker_debugfs_scan_write()), so there > is no need to hold shrinker_rwsem during debugfs operations. > > Signed-off-by: Qi Zheng Reviewed-by: Muchun Song Thanks.