From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98E5FE6894E for ; Thu, 31 Oct 2024 03:53:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 113646B0096; Wed, 30 Oct 2024 23:53:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0C45E6B0098; Wed, 30 Oct 2024 23:53:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ECD906B0099; Wed, 30 Oct 2024 23:53:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id CF5BD6B0096 for ; Wed, 30 Oct 2024 23:53:08 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 73BD3AD09E for ; Thu, 31 Oct 2024 03:53:08 +0000 (UTC) X-FDA: 82732525848.25.F86BB61 Received: from out30-133.freemail.mail.aliyun.com (out30-133.freemail.mail.aliyun.com [115.124.30.133]) by imf11.hostedemail.com (Postfix) with ESMTP id 2DA5540002 for ; Thu, 31 Oct 2024 03:52:32 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=PQthkC52; spf=pass (imf11.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.133 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730346655; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sOP+DFaQKBYehdC1jobFZNXJQ8TaEZTpRfVqUforLqg=; b=kQb+MSqjKBhLIoxpbyxun0Yo0cjXjlYst1qHEHYfiqRVmD6pZy+Q2/n57C2kpIxPmakFtk EHfuOYTOC/PEvmhgZ7EDCxVjY1vvbQ1dv1HXRSzLvQBqvrFXR3inA+dG9pSzB9jLG5Z28G ChTzsnvYY0BMkP2QCjj2u1vfIk6dQog= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730346656; a=rsa-sha256; cv=none; b=m9QrucCFKkWuRBv+f3NXZFjBEoydlbExpLavkznCcj5L6jZcidIv7w2UR4akX3pieYw18p bWlxtWadUSwpKEqiSfA78cNJbDNqn5NoIoZbFyaN34PgjgHrZcxOidGQ88PbqeeLiXWII1 uQGUN/xSqNo1iNIAq0LvQUc+6fAeR2s= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=PQthkC52; spf=pass (imf11.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.133 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1730346782; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=sOP+DFaQKBYehdC1jobFZNXJQ8TaEZTpRfVqUforLqg=; b=PQthkC52u2e4WvvmFZcSWC03P+a7px6Ud1Ovn+keAtuUJFCGx52EIpfvvV+lMRAyebidpNZnuMim6Ni8ECvfeaUy6L8/zQPB4VhBCENGwdeinAOJOR8RjYcv3Fp0D7F5NpT0SKlzneVPf0rkjgCDUA+bmQfTrp67xqwubH52sSA= Received: from 30.74.144.119(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0WIGvEqL_1730346780 cluster:ay36) by smtp.aliyun-inc.com; Thu, 31 Oct 2024 11:53:01 +0800 Message-ID: <2103c4c9-7da5-49a1-95f7-be11f62b58fe@linux.alibaba.com> Date: Thu, 31 Oct 2024 11:53:00 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/4] mm: shmem: control THP support through the kernel command line To: =?UTF-8?Q?Ma=C3=ADra_Canal?= , Jonathan Corbet , Andrew Morton , Hugh Dickins , Barry Song , David Hildenbrand , Ryan Roberts , Lance Yang Cc: linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-dev@igalia.com References: <20241030130308.1066299-1-mcanal@igalia.com> <20241030130308.1066299-3-mcanal@igalia.com> From: Baolin Wang In-Reply-To: <20241030130308.1066299-3-mcanal@igalia.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 2DA5540002 X-Stat-Signature: mawhic15mpuzpmnkbanf14cu1ms16xfx X-HE-Tag: 1730346752-963855 X-HE-Meta: U2FsdGVkX1+tb4vwFRwPsoVtJAFP+paoOrCdJB1CV4USFpLS2R9lLNmAkGMRRmzTWdb8u+Da4PTnYhj+9ZA7b0KctU74xfAAN6rVe9klLWopD7D91UjOiDE1/FX103BsHMtb982mKuDM/AKhM8OP9XW18jwwiS8TBBz8WucO2BmWRgztNyU0rVUYp60qPDqlTA39DalURKWcz6lCn6YhXqVH8p7UGuGjJivjaOj6igOUv2YrfkCNH0MRzlU6pr/VW6sXttZZQSoGMGhrv55E7H5u7fPJqOWmtNKWWZaCpay3t4dqX4Y62HKwTEgEPFTP4pws9nqMQCzbck+G9/Kt29Ezlt3WA9fi951zkd/4AVhCrt3Tyu5HC9Mc89PoK8ROyytRrnvoc2WRbMaZRDucjGMRHvyOLTSyrCmCdqN86U06bNKhMDoDO/wZ3njECCgyoJfZ1iCIZWkh+teqlusl/Kx205khXMZYwKnjcM1e4mPwHpikxVGgH9cqGFlcvCEh7+HGcgqchojyjGucUk2DzNXDszjpYIxLncAeGwDub5k1/VbsOqXtWK9tIGSdJa7ugNYqU8mtgwyACqp3/Lau35fNHbDHgHYfWlSD5ifx/MH7/sRW/Jf7MKvSkg1eorprlrBhEVdHh4lrTfq4Lebi85UJuKIrWeWGm6EyakeCVsxeY3nsjgUw9PRB/C7MvEBbYLi9PYs5MTLlAWkk4ur+cDASRJuAkugDarUj6cRAPgdlbYqliKjdOxTvMTnTbJvy3EaPbby74yLdEXDQtoXjC2qdFfAyl3GO4RQGEMb910M6vI/EUJ0B6csKX95DJKevZOc40Nr9evsQVH1ptWhXrUf5pfO5ZY2Gwzfl3JLB3JYRpKmql9utPELIudG+Kh9D8XeFNqczOKgscGxW9luRezctbC+gfiiQaE4AJVmPLxliBARl6epavV4FcwrxXW3xOHaTkdOgtUhENvoGzU6 bs1/O2Wj g56h2JRWBjrbkrxxWJUrfJzz6EIlEdFh/8+okyfL7XLVnmFr0YmYwNdejDUfsGgIrBWtku1XFY1dWNFWeb6wn8M8rndshqtViAZpPT9xfOiQAzycCabzq6te1mkf2Yzw1CdFbjo6yVB54VDY0Q3+UU8CEZZcoz5NpniB8lbG6/i/8IJrIswEIUhPvcaGpp+ScEW7nZlEDkXNjOG1qNeEy1wy2Y1hZ9po1ZJBJqPPQowdX2RSd0wtaQ1y0iagJU1+TyeO8oRGo53EwCrXCFtJYbSJz8me9uXdBZMXWbkrSq+y75JG7j9NhGyGRxy9fflyWnjYLMHXLcXugnjJDryRsRehDBoO6q15Z/1FAk/agWTqJ4RM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/10/30 20:58, Maíra Canal wrote: > Add a new kernel command line to control the hugepage allocation policy > for the internal shmem mount, ``transparent_hugepage_shmem``. The > parameter is similar to ``transparent_hugepage`` and has the following > format: > > transparent_hugepage_shmem= > > where ```` is one of the seven valid policies available for > shmem. > > By configuring the default hugepage allocation policy for the internal > shmem mount, applications that use shmem, such as the DRM GEM objects, > can take advantage of mTHP before it's been configured through sysfs. > > Signed-off-by: Maíra Canal The changes look good to me. With the commit message update pointed out by Andrew, feel free to add: Reviewed-by: Baolin Wang