From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F824C433EF for ; Mon, 23 May 2022 06:33:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7AC8A6B0005; Mon, 23 May 2022 02:33:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 75CD56B0006; Mon, 23 May 2022 02:33:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 64B476B0007; Mon, 23 May 2022 02:33:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 50F2D6B0005 for ; Mon, 23 May 2022 02:33:06 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 2D99334103 for ; Mon, 23 May 2022 06:33:06 +0000 (UTC) X-FDA: 79496040372.21.B40B312 Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by imf01.hostedemail.com (Postfix) with ESMTP id E898D4001A for ; Mon, 23 May 2022 06:33:01 +0000 (UTC) Received: from dggpemm500023.china.huawei.com (unknown [172.30.72.54]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4L66p848wkzDqL6; Mon, 23 May 2022 14:28:00 +0800 (CST) Received: from dggpemm500001.china.huawei.com (7.185.36.107) by dggpemm500023.china.huawei.com (7.185.36.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Mon, 23 May 2022 14:33:00 +0800 Received: from [10.174.177.243] (10.174.177.243) by dggpemm500001.china.huawei.com (7.185.36.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Mon, 23 May 2022 14:33:00 +0800 Message-ID: <20d731fd-f7f9-4c93-d851-01972dc04cb9@huawei.com> Date: Mon, 23 May 2022 14:32:59 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.5.1 Subject: Re: [PATCH] mm: kfence: Use PAGE_ALIGNED helper Content-Language: en-US To: Muchun Song CC: Marco Elver , Alexander Potapenko , Dmitry Vyukov , Andrew Morton , , References: <20220520021833.121405-1-wangkefeng.wang@huawei.com> From: Kefeng Wang In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggpemm500001.china.huawei.com (7.185.36.107) X-CFilter-Loop: Reflected X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: E898D4001A X-Stat-Signature: r5oe3fq4pon6b37azhdorppntk64y8qu Authentication-Results: imf01.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf01.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.189 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com X-Rspam-User: X-HE-Tag: 1653287581-382271 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022/5/20 18:26, Muchun Song wrote: > On Fri, May 20, 2022 at 10:18:33AM +0800, Kefeng Wang wrote: >> Use PAGE_ALIGNED macro instead of IS_ALIGNED and passing PAGE_SIZE. >> >> Signed-off-by: Kefeng Wang > Acked-by: Muchun Song Thanks, > > BTW, there is a similar case in page_fixed_fake_head(), woule you like to > improve that as well? IS_ALIGNED is defined in include/linux/align.h, but PAGE_ALIGNED is in include/linux/mm.h, so better to keep unchanged in include/linux/page-flags.h. > > Thanks. > > .