From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2DA9DC27C54 for ; Thu, 6 Jun 2024 14:19:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 779B16B008A; Thu, 6 Jun 2024 10:19:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 729AE6B009A; Thu, 6 Jun 2024 10:19:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 619496B00A1; Thu, 6 Jun 2024 10:19:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 449F96B008A for ; Thu, 6 Jun 2024 10:19:47 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 125CF1A1653 for ; Thu, 6 Jun 2024 14:19:47 +0000 (UTC) X-FDA: 82200672414.01.0DC79BC Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf09.hostedemail.com (Postfix) with ESMTP id C004614000B for ; Thu, 6 Jun 2024 14:19:44 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=JEAj96XI; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf09.hostedemail.com: domain of "SRS0=54/E=NI=paulmck-ThinkPad-P17-Gen-1.home=paulmck@kernel.org" designates 145.40.73.55 as permitted sender) smtp.mailfrom="SRS0=54/E=NI=paulmck-ThinkPad-P17-Gen-1.home=paulmck@kernel.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717683585; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dC4OypPnTIJENrKH7rgwvKApzfDanHBytE+WGvev/VU=; b=UqYKHI78VMqmV0pkBhHubjTO33zxOHhyOcGMXic9C4r4qzhMtDW7jo6pYSWHiL1WQkVRVk ImN/GuzmR/Sh63L8SvqRn8Z7V2lLM/hxeXRlL1vVtWDOYkiPFS1j4Bqc8Q8TSZL7ziDefY fl3ui+8Sp2OXDnRwsjSBngKAMX0OBkY= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=JEAj96XI; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf09.hostedemail.com: domain of "SRS0=54/E=NI=paulmck-ThinkPad-P17-Gen-1.home=paulmck@kernel.org" designates 145.40.73.55 as permitted sender) smtp.mailfrom="SRS0=54/E=NI=paulmck-ThinkPad-P17-Gen-1.home=paulmck@kernel.org" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717683585; a=rsa-sha256; cv=none; b=4/S07lvJm8RBaXNI4DKTBUOeOgZeMh4Qpb/I2pJqmxQaeSBdXYNHwBKTP/Mb4+EIn4Cb/9 oz1FU8F6Vh35DpihK6TUrcURsfKVpGNNkgDgUaWqY2wTOc28uJpm5ottTSeMDW6XDk8dkL kT9vn/yyq1IEdpd3CRsHp5JyJCCtZGM= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id AEF58CE1B00; Thu, 6 Jun 2024 14:19:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0939EC2BD10; Thu, 6 Jun 2024 14:19:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1717683581; bh=xmEdPDXw1k/BWduDyUVJLV259V5w3Fa90zom/EWQBFk=; h=Date:From:To:Cc:Subject:Reply-To:References:In-Reply-To:From; b=JEAj96XIpIO8CBmuyI6nhs3Mj9yer+/ii3D4GgzK/9cOYp60HZaQxY3fZkRAXORVv 2lfgYC70M+Db7+Ht/VjPrFhuErIvi8H5nR71Df8qsUoL5+JnMzdHW2NZ/gHpO5w1qA HV4O4GnnG0P6toiMR2QXOP2ISFR8VIW1DHYtOG9PIAt6LGmNUyCJJVl1wpIBmg+DbL eNkKk+5hGmT9dQfY4mS7C2MXukA0aAaNrCoNfr3/BMoX9B/0xxUzJGZNn2/dgdbpEQ 8jpVdwmjGxN44DkJyZVrRuY0cIkVLMjYM5UYd5BCJjSxUDZjE1tHqTkwxuMgQT9Lyd j0Z4249u5aIpw== Received: by paulmck-ThinkPad-P17-Gen-1.home (Postfix, from userid 1000) id 9512FCE3F34; Thu, 6 Jun 2024 07:19:40 -0700 (PDT) Date: Thu, 6 Jun 2024 07:19:40 -0700 From: "Paul E. McKenney" To: Jan Beulich Cc: Naresh Kamboju , open list , linux-mm , lkft-triage@lists.linaro.org, Andrew Morton , Mike Rapoport , Dan Carpenter , Arnd Bergmann Subject: Re: x86: WARNING: at mm/memblock.c:1339 memblock_set_node - Usage of MAX_NUMNODES is deprecated. Use NUMA_NO_NODE instead Message-ID: <20c484a5-d797-4782-b5b5-bea5fcae9284@paulmck-laptop> Reply-To: paulmck@kernel.org References: <315d6873-d618-4126-b67a-de62502d7ee2@paulmck-laptop> <7d55b65e-331a-4ce2-8f72-d3c5c9e6eae0@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: C004614000B X-Stat-Signature: cx86ncfzhjbb5q1naez1xj8jnntb79ex X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1717683584-726567 X-HE-Meta: U2FsdGVkX1+iUYKJejsqfKIN74HRyvouGBj2vDnk6J8gyPUA8haZO+9obqfby5wwC4h6CjVE+SCC3xKF4/8KSro0EER1X8bC9R4T50n5QVVMKk0gTkNZrj28zzWmzgWC7ZgQFK+9LqEwpBrmoC4JD4hVn7w8epc5RCARPfcO/v0hqVOhyNkxtRtn9IgdXfXLk60/bwLNGDSFQsHmRZHzbsDwAHvNbfgFJSs+gKV5fbfYzSEc91O0mZ4Gaba1hDUWflPn6ee7vP84bCxuwq1NyhEqADFRlRAIlBpgKuiN1XoH6qBps7SMrSo2lqx5n1qWnvJh+MlT2r3qZJPpN6tGTmKQCUTN8OSFUt6IoR6QZFyOzTmF/th00iZq/lx1VGLMIaMagxdVYo4BCUyaz7c5HMs5rFpeg2DtLrLxaWRvGG91sPZsugwqyTZ6YH+4XSrsjM0uGqhQ/za/WBXDRFw0LtvRRPXV0WFJWlpqIqqo2Er+fZ0xru+Ohr65y/J6vuiQU7mRVWhTDrG0lRkDV1XbWnRzQlbCQS+hzRHpGkiYDIa8RgbP5iKwF8TaMXqogcfMaNyUQGX1Aa70auqR8bUeufpD/qf+HMAZqQQJPuhKHMblx/4a1rZAT/MFbgCp6Kb2lMBJiiCI9l1edL5zU3aK+GnbgGsGa04yxotMDHV2bw4mbiwfONLDz373X1wsrcvBPc7b9aKXAE3//UZ3gQuWYa6DchyeLwgrYfxhcxzntj81Zxo2dxGXnrAVc82nUQs5+vwvxLjpPhzdAHWmj+DZ+IKzubcv/F2jkz1GPaYtCwJarEP2kBL5c/PohR+/P9G5PP0x4kcsUG41M3i52csKDzrURATcC0fwoGqUZ5Zr2ZERnWCjOjdzvM+zBJas3AqO9RD3BawUKomLC/KqNNz92Tg87vwDayUeJ9sfG+Qes0YTMmXx46HecKd3ojAJu8FlA6wADOQFzRhzA4xByDp f3gZXluf H+kZLTl/CFCTciGin+NEa2p7MgW/zuvtiUCpM1frqOrvsSpgtUdmjeQmuxCQMbCV91Qr6/18bP8AypTA7QWObQRmxBZiIuwm3jjyhD5zrWJXILXt3D2RWvvpEMTrD+St0tjF5uaZyLrLztD4beT1O4tzvP8U5aTlQk/WYSQbI6dcs4zpcDKeH4vXLC1rE2EPkmhAJOWEUaUjmpAsHBkeZzEskfETRtyaGdkBJ86ofA5MlqbzHu9dKQhNPJ8/zalsmztmepH7MA2Djf7th/8eXMm0peRIYBuEyOIlsHf8oiDtMbIvFM3rVh0y+7Y30kigJJRGN33q3zwZMwtEAd9NlMsvaDjymanUIQhS9c0Xt9+c0sMHJ0KkHMY4nuErhCmqJguKA+10ncms5dKzf/B05CDfiFfGwI6r+aKNAfbOmNU4aERtNT5nK98m/1Mn/I1yIVHAhUEMCB6rnnIDctvEHj6zPPhjQuFwZPFzt7MG62enqExWBDyTywXdnDXq6vyug0zOX41CNEOhfIlXf0qIncxIaYa2mmmYDRxL8gOMQzhr9BWEt0pn5NZminC6LUwUyurKk/eJ9npnwaSGHHGyvC3E0sxWyeFT9YErO3iCEALcrZ0y+aYULPS9AysSyGG4SqaGsE4frAbQcjWcJmN9YkgNcZzCaCxxsLoCe8jY4rGanlIlk7K1VGGbMet/qD0lm0rnx X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jun 06, 2024 at 08:13:17AM +0200, Jan Beulich wrote: > On 05.06.2024 22:48, Paul E. McKenney wrote: > > On Wed, Jun 05, 2024 at 09:46:37PM +0200, Jan Beulich wrote: > >> On 05.06.2024 21:07, Paul E. McKenney wrote: > >>> On Mon, Jun 03, 2024 at 07:19:21PM +0530, Naresh Kamboju wrote: > >>>> The following kernel warnings are noticed on x86 devices while booting > >>>> the Linux next-20240603 tag and looks like it is expected to warn users to > >>>> use NUMA_NO_NODE instead. > >>>> > >>>> Usage of MAX_NUMNODES is deprecated. Use NUMA_NO_NODE instead > >>>> > >>>> The following config is enabled > >>>> CONFIG_NUMA=y > >>> > >>> I am seeing this as well. Is the following commit premature? > >>> > >>> e0eec24e2e19 ("memblock: make memblock_set_node() also warn about use of MAX_NUMNODES") > >>> > >>> Maybe old ACPI tables and device trees need to catch up? > >>> > >>> Left to myself, I would simply remove the WARN_ON_ONCE() from the above > >>> commit, but I would guess that there is a better way. > >> > >> Well, the warning is issued precisely to make clear that call > >> sites need to change. A patch to do so for the two instances > >> on x86 that I'm aware of is already pending maintainer approval. > > > > Could you please point me at that patch so that I can stop repeatedly > > reproducing those two particular issues? > > https://lore.kernel.org/lkml/abadb736-a239-49e4-ab42-ace7acdd4278@suse.com/ Thank you, Jan! A quick initial test shows that this clears things up. I have started a longer test to check for additional issues. But in the meantime for the issues I was already seeing in the initial test: Tested-by: Paul E. McKenney Thanx, Paul