From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03F1BEB64D9 for ; Wed, 14 Jun 2023 08:49:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2CA818E0003; Wed, 14 Jun 2023 04:49:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 27B308E0002; Wed, 14 Jun 2023 04:49:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 144208E0003; Wed, 14 Jun 2023 04:49:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 041078E0002 for ; Wed, 14 Jun 2023 04:49:56 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id BD2CC80890 for ; Wed, 14 Jun 2023 08:49:55 +0000 (UTC) X-FDA: 80900730750.22.7923DBE Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf16.hostedemail.com (Postfix) with ESMTP id 090C1180017 for ; Wed, 14 Jun 2023 08:49:51 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=cJQrfhvU; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf16.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686732593; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3Rsvso4l9koDuzHwHgyAvlpKhmbENWcT5E1vZaroQkI=; b=G2TFx1OoJhUgjxLZt/ZHH0SExLTas+LvRA/FMb83Gm7hk5LekREffb1Kkqvo0mI/RTmZ3L fDJp3S8x/FNeCi0b+EfxcshJZ8MluzD+gMqd6QmZvmeYo4DucuTweMaQIIVhTSNeGZ01YD cNXJrV8mGSa842VGuIFVq9zJhjfeErQ= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=cJQrfhvU; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf16.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686732593; a=rsa-sha256; cv=none; b=6rI1eGAYA3t15SLL6MrkaUeARbMacEserWRkg72/Df0Jjs7K2dxgDy96qCXpQ8XuocbYsD 06NMzaCpF8S/qtMuADsIZRgr3I50ZO2CPTfWdk6fkDQzydREngU6DzEJHJoNyNwvBh0Vyh yFSzFKgCJh7Q+HpWlCgfJfpJpgNGirU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686732591; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3Rsvso4l9koDuzHwHgyAvlpKhmbENWcT5E1vZaroQkI=; b=cJQrfhvU4Va7nHxegMT/3JRFS1AqOH9bbYwLGnnPLF4leF56sMDHo2gGsdao28rKOxHVRu 26rlWAEEnxxbTw8Pj6lwqsMBFwJozYxWf+3fOVOuiAn8Hz8HRl253VrsF4JkTtomPmJcUi yHD8ubiFp8z1lA+TCElw6Ee2TJmpZ2A= Received: from mail-lf1-f70.google.com (mail-lf1-f70.google.com [209.85.167.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-145-Fi2OB6sQOFKtJJFxhTxr4A-1; Wed, 14 Jun 2023 04:49:48 -0400 X-MC-Unique: Fi2OB6sQOFKtJJFxhTxr4A-1 Received: by mail-lf1-f70.google.com with SMTP id 2adb3069b0e04-4f62d8e527bso5068901e87.1 for ; Wed, 14 Jun 2023 01:49:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686732586; x=1689324586; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=3Rsvso4l9koDuzHwHgyAvlpKhmbENWcT5E1vZaroQkI=; b=RtDdPPYcRi4CDx0JuSbzJUATUn0D64XwkM2O2wvmXEJNHCQo7ozVapZm+N7p3UXPd9 hBQ2knGADNj2AL5+4fPukr/hsl3Sw/LkL9rQg4v8qWEx/EC4AkuVZcDx4xVqbzB0ryyZ 4KtOe82uvYZchkwKIEdaax2A72UM5dRLn05Xuki0z+pNdEpgJqn2P1/y1vX7sFyyKqwG Fv0jjJfkssJd5SPaMpm/UQFLUOMsP78OBrkckRvotY7NT7ihc9KaUcN5916aZgX7DRtR BAe7DX7m3C2tsN1GMgfGxUrs6jWIkQXG0lYgoxYVW2QD/HEBNTnzUDHLZGTUNF6CW0ih f6wA== X-Gm-Message-State: AC+VfDzQO0rDtzIOOTGm7+kfhSjMSnSvschC6b1hvprT3FbFTBO6lu1n eyud49lA38ukIU3RQ71lqZdwDb4dM5hC9+Pm0yCd90qxymexx7WtHlQHfG7D3o0RZvuxOgyykhv ltodIIYFQib8= X-Received: by 2002:a19:4312:0:b0:4f4:b28f:6b9c with SMTP id q18-20020a194312000000b004f4b28f6b9cmr6502180lfa.29.1686732586595; Wed, 14 Jun 2023 01:49:46 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4r4XW6g5a7gzGlx/YsBE42/ZrV5TBz6ylOyFXzEPjbNlpThttCQBG7uP9TbF88yZOz/A7BQg== X-Received: by 2002:a19:4312:0:b0:4f4:b28f:6b9c with SMTP id q18-20020a194312000000b004f4b28f6b9cmr6502133lfa.29.1686732586113; Wed, 14 Jun 2023 01:49:46 -0700 (PDT) Received: from ?IPV6:2003:cb:c704:b200:7d03:23db:ad5:2d21? (p200300cbc704b2007d0323db0ad52d21.dip0.t-ipconnect.de. [2003:cb:c704:b200:7d03:23db:ad5:2d21]) by smtp.gmail.com with ESMTPSA id g26-20020a7bc4da000000b003f60e143d38sm16709642wmk.11.2023.06.14.01.49.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 14 Jun 2023 01:49:45 -0700 (PDT) Message-ID: <20afbea8-fef7-55de-20af-8497273bf11f@redhat.com> Date: Wed, 14 Jun 2023 10:49:43 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v9 04/42] mm: Re-introduce vm_flags to do_mmap() To: Rick Edgecombe , x86@kernel.org, "H . Peter Anvin" , Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, Arnd Bergmann , Andy Lutomirski , Balbir Singh , Borislav Petkov , Cyrill Gorcunov , Dave Hansen , Eugene Syromiatnikov , Florian Weimer , "H . J . Lu" , Jann Horn , Jonathan Corbet , Kees Cook , Mike Kravetz , Nadav Amit , Oleg Nesterov , Pavel Machek , Peter Zijlstra , Randy Dunlap , Weijiang Yang , "Kirill A . Shutemov" , John Allen , kcc@google.com, eranian@google.com, rppt@kernel.org, jamorris@linux.microsoft.com, dethoma@microsoft.com, akpm@linux-foundation.org, Andrew.Cooper3@citrix.com, christina.schimpe@intel.com, debug@rivosinc.com, szabolcs.nagy@arm.com, torvalds@linux-foundation.org, broonie@kernel.org Cc: Yu-cheng Yu , Peter Collingbourne , Pengfei Xu References: <20230613001108.3040476-1-rick.p.edgecombe@intel.com> <20230613001108.3040476-5-rick.p.edgecombe@intel.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230613001108.3040476-5-rick.p.edgecombe@intel.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 090C1180017 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: xeqj1r8kwompmq1zp19jkfnwxgiznicn X-HE-Tag: 1686732591-852077 X-HE-Meta: U2FsdGVkX1+n01536d3bNqKE0Iqcx5+uoGPBgS5lr8H/rTDVjDSu6BjKFpb7JKkW+QYxwvHF0rasd2scInSsXI0BliFbwuGmMDrD6wCv53ll4xbDP5ox04ILCws8wZ3ulrSdBHMXPHlvbC72oyPSxlGi2fvzd26YxyFIAaH+1URNS1uVq1dlJda3CtEOaUK0GgPbFqSgsZmPk8DFOMm/DRVvyWqJQtKM5G/hzhuxExaBEyhO6g1SHGvB0sN5rj0YzzAhYaj4It+5+sqDPwES+DGyjhxSb3pOxVNv9qGfYfGb88KDLMXowUVT0vrCNXY25nsBWgLtlL4JQRJf5m0P5xHUFGRphUO92Lawoyt0zen412aeXe6e3Oho6tKdND3WddFHtHQLyXvzqc+fuEn7PgYb+UjUrwQQys7YCB2xfQTsEwInIxRm/QspNcGL9FX//YqP/EocfvqVBd2sdD0jYKd6QQ7cIosx7OAGm38EjYLl4MmhmIJKqqj3K2pVZsCg65gsmeqYuLMZAVR5sa7724OIKpMrhYrbfWMwsqco1zB8BdA2Z2P1mMQFgcavGxbpJ+A242qfDdQSJK38d/7cgr+yTdqXgf2oUXwlRet4TXteBCIMs8eQDt1CcJzOTWGTmlBPVOG21wr7gPieKy0rXDteMWkC6skR5q5ji324ZlVkt5OHcrHEO2ZMWbowkrb1GAGlYrk7EoCwHSaCgOnQcFOnlRI7RLWDwJwe7ysWf4zFTxqS5idvtyZxJ8EpoKDXCIl+JOIq+RkRRu+TlppdstBy7DuQ9Rihyc58Q0re70skSh5+Qjpe+WWY1tcJxzy8izv3xQguCYShvwvKMAWfcXkI/cz7tst7ZLxIoBEceOm9OQivnyjEmvcLYW78Um/+8fLKy5/QeT7bUFod5DrMpWlsXa+00tZGcDgE5NQQe+DkFyTEIkcoOohGadu64w/SPMnDHvGO3ueUYiGVRcf OqxYcGkZ GPu8zqj8a0N7MhStwMfDJLrE8snJrdWfwVfq4xiVzA9Ci54vji+0rsILUwsFl05cJWWGGo4nELwzPUL7eOTjBQzT1dp6rUInSQzR/fPYn7iutuQlmVK13c0j7hostV/d9MvXcmy3zyM572b6bx9x7IheyjcVIUALU+KUwLsT5hugYi+fm0STT7C4bBWAaZQZmqcNni6ZGy0G78KacgK275k0/Bw7St59MBpi3bs2xoYHi9zpJ0ux12rp8fvwLBT5FJLbTziXnvhXYFCzbixJ1PYO79Bh1E6cz8b+un9RwdHTd8rBkuQuUBeuEDhxFdfXv0Q/6XlfSPd1ZwA4K2wyNyXDS5s4l6wDcykZGYBQKuX8wxCYVAnydIq2Z7u+LdSiv9v1CrPD9kfVvnbXwpFZmxN68wGgPj2/JCVBTJPzcCJHgVueTCmeGDI387mfngtab2/pDjbRD6CVYa6rX/KWX60OlDyN1KuKdCY7jzcx696QTJqgq2c82Xhpn/LDxhvYs38X6zY6v/62e8D2z0SvbBV6rFJ7l6m+fNt8tU8e6FOsQO4EtRHQC0JiIzI7WUs5ogEGBaMSPL0jMWn2lePbW5UV3MfKvfY3vMnsskIMxQQ6mjOr2GjhgglB8PvwyONtpTQ9SK6iDSFmvlxGOQYlfi6RsSw3nwz+fYXxXMjsw8ERPwgpnv1O3iTTzR5okHpYPLXlUCGsIRtPWVNY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 13.06.23 02:10, Rick Edgecombe wrote: > From: Yu-cheng Yu > > There was no more caller passing vm_flags to do_mmap(), and vm_flags was > removed from the function's input by: > > commit 45e55300f114 ("mm: remove unnecessary wrapper function do_mmap_pgoff()"). > > There is a new user now. Shadow stack allocation passes VM_SHADOW_STACK to > do_mmap(). Thus, re-introduce vm_flags to do_mmap(). > > Signed-off-by: Yu-cheng Yu > Co-developed-by: Rick Edgecombe > Signed-off-by: Rick Edgecombe > Reviewed-by: Borislav Petkov (AMD) > Reviewed-by: Peter Collingbourne > Reviewed-by: Kees Cook > Reviewed-by: Kirill A. Shutemov > Acked-by: Mike Rapoport (IBM) > Tested-by: Pengfei Xu > Tested-by: John Allen > Tested-by: Kees Cook Acked-by: David Hildenbrand -- Cheers, David / dhildenb