From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0516C433EF for ; Fri, 15 Oct 2021 19:40:09 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5BEF061164 for ; Fri, 15 Oct 2021 19:40:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 5BEF061164 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id BF0216B006C; Fri, 15 Oct 2021 15:40:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B9DB5900002; Fri, 15 Oct 2021 15:40:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A65186B0073; Fri, 15 Oct 2021 15:40:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0113.hostedemail.com [216.40.44.113]) by kanga.kvack.org (Postfix) with ESMTP id 9255C6B006C for ; Fri, 15 Oct 2021 15:40:08 -0400 (EDT) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 4A2E68249980 for ; Fri, 15 Oct 2021 19:40:08 +0000 (UTC) X-FDA: 78699687696.08.5BB0639 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) by imf22.hostedemail.com (Postfix) with ESMTP id 4BCC51907 for ; Fri, 15 Oct 2021 19:40:07 +0000 (UTC) Received: by mail-pl1-f179.google.com with SMTP id g5so7028908plg.1 for ; Fri, 15 Oct 2021 12:40:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=1a/6peZLSAD85mz3HpJfFRT3p8OOlLaLJWrrCdBU9sA=; b=e3mQV9GvtxxTsES/ruNVsn6hkp1PVZogK12qCFJREQXgexbzc2xBWXnyiq1sDF6gZ3 ySEFTeusj6kmZm5dg6klqEH91CH6aTk3oAbwNNMYkg9KhXeS60IMBFSZO+oe06Phso/i A1gDHWb7YjtZOWG283MFXHXPLEW7j0gqApLmIvX19BTVmOedMzS4bmnEHw8/EDybcut5 NkHBMogA5uf5fg1D1lBZTufjcdOs18jrCAqxDCj5efrPYGrmRiKnPLK3o0oxoUOIEz6M CjKhypphO0l2u9jnBdrFtodeLvLMDgmmcbVAk3wDDfj5lb2t/qvynBi+X8lgscAlXAKF /ENA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=1a/6peZLSAD85mz3HpJfFRT3p8OOlLaLJWrrCdBU9sA=; b=5njAI6jEKuIYwooHcqA2V0QVKF3mkmhuVSQxybuue6vq86CauIBOF1hs6KP/oZlqxM uWscvJ884r9eeJfaOPP6yfiH84b3KPKP2vhn/TP1V4/scRXGebsC8t5fejbpxu88FyNy MngogIUUdS75yyugDm9Q34cGpkSSVZsJLSQpQOu1B2aSVWXdlNhbIso/tkWdEcasXH7i agBNROd7aMqFFf6CSQCFOUMIxEx9Syrl9wcm14zWw7P5UVt58lJwrhLNyOQc45ipu+1W DGfaLH4z3t20GwmWTodQC1Jpijw4ZDZPrjXXSlVU/NbWsNX5Ih2v8LJMzUpL+aA73eAj nuJA== X-Gm-Message-State: AOAM531zlyDM7SrPHStLucfXXaVpzlYDeGPAHpuKgnIEo3cA33oXlYa5 0HtbN6e0tD5URRDSvYg+RU+HPoR4RAQ= X-Google-Smtp-Source: ABdhPJwTkc5fakXK/OOUpTRwuPBEbNMV1p0wKou25kBF6F95B/UvzmLUt1WvJ3igATMggAn0rhz88g== X-Received: by 2002:a17:90a:b391:: with SMTP id e17mr30100849pjr.137.1634326806762; Fri, 15 Oct 2021 12:40:06 -0700 (PDT) Received: from [10.67.48.245] ([192.19.223.252]) by smtp.googlemail.com with ESMTPSA id g14sm5225415pgo.88.2021.10.15.12.40.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 15 Oct 2021 12:40:05 -0700 (PDT) Subject: Re: [PM] bfcc1e67ff: kernel-selftests.breakpoints.step_after_suspend_test.fail To: "Rafael J. Wysocki" Cc: LKML , Linux Memory Management List , lkp@lists.01.org, lkp@intel.com, kernel test robot References: <20211014075731.GB18719@xsang-OptiPlex-9020> <51c0a15f-1941-f161-dcec-a7a9acc726f2@gmail.com> <6755cf07-fa5a-cbb7-c076-57c162a08c99@gmail.com> From: Florian Fainelli Message-ID: <20aedfba-14e3-3677-d21a-b87610095445@gmail.com> Date: Fri, 15 Oct 2021 12:40:00 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US X-Rspamd-Queue-Id: 4BCC51907 Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=e3mQV9Gv; spf=pass (imf22.hostedemail.com: domain of f.fainelli@gmail.com designates 209.85.214.179 as permitted sender) smtp.mailfrom=f.fainelli@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Stat-Signature: pqmdifa9f5wqxeezrh6wyupnm79pmmf9 X-Rspamd-Server: rspam05 X-HE-Tag: 1634326807-856250 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 10/15/21 11:45 AM, Rafael J. Wysocki wrote: > On 10/14/2021 11:55 PM, Florian Fainelli wrote: >> On 10/14/21 12:23 PM, Rafael J. Wysocki wrote: >>> On 10/14/2021 6:26 PM, Florian Fainelli wrote: >>>> On 10/14/21 12:57 AM, kernel test robot wrote: >>>>> Greeting, >>>>> >>>>> FYI, we noticed the following commit (built with gcc-9): >>>>> >>>>> commit: bfcc1e67ff1e4aa8bfe2ca57f99390fc284c799d ("PM: sleep: Do no= t >>>>> assume that "mem" is always present") >>>>> https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git >>>>> master >>>>> >>>>> >>>>> in testcase: kernel-selftests >>>>> version: kernel-selftests-x86_64-c8c9111a-1_20210929 >>>>> with following parameters: >>>>> >>>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0group: group-00 >>>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0ucode: 0x11 >>>>> >>>>> test-description: The kernel contains a set of "self tests" under t= he >>>>> tools/testing/selftests/ directory. These are intended to be small >>>>> unit tests to exercise individual code paths in the kernel. >>>>> test-url: https://www.kernel.org/doc/Documentation/kselftest.txt >>>>> >>>>> >>>>> on test machine: 288 threads 2 sockets Intel(R) Xeon Phi(TM) CPU 72= 95 >>>>> @ 1.50GHz with 80G memory >>>>> >>>>> caused below changes (please refer to attached dmesg/kmsg for entir= e >>>>> log/backtrace): >>>>> >>>>> >>>>> >>>>> >>>>> If you fix the issue, kindly add following tag >>>>> Reported-by: kernel test robot >>>> Thanks for your report. Assuming that the code responsible for >>>> registering the suspend operations is drivers/acpi/sleep.c for your >>>> platform, and that acpi_sleep_suspend_setup() iterated over all >>>> possible >>>> sleep states, your platform must somehow be returning that >>>> ACPI_STATE_S3 >>>> is not a supported state somehow? >>>> >>>> Rafael have you ever encountered something like that? >>> Yes, there are systems with ACPI that don't support S3. >> OK and do you know what happens when we enter suspend with "mem" in >> those cases? Do we immediately return because ultimately the firmware >> does not support ACPI S3? >=20 > "mem" should not be present in the list of available strings then, so i= t > should be rejected right away. Well yes, that was the purpose of the patch I submitted, but assuming that we did provide "mem" as one of the possible standby modes even though that was wrong (before patch), and the test was trying to enter ACPI S3 standby, what would have happened, would the ACPI firmware honor the request but return an error, or would it actually enter ACPI S3? In any case, I will change the test to check that this is a supported standby mode before trying it. --=20 Florian