From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBD98C5B549 for ; Fri, 30 May 2025 09:31:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 69F846B00A7; Fri, 30 May 2025 05:31:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 650E96B00A8; Fri, 30 May 2025 05:31:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 519306B00A9; Fri, 30 May 2025 05:31:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 2F0626B00A7 for ; Fri, 30 May 2025 05:31:34 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id C3EE61CB4DA for ; Fri, 30 May 2025 09:31:33 +0000 (UTC) X-FDA: 83499056466.07.040A18C Received: from mail-pg1-f179.google.com (mail-pg1-f179.google.com [209.85.215.179]) by imf29.hostedemail.com (Postfix) with ESMTP id E0AA5120002 for ; Fri, 30 May 2025 09:31:31 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=JjMY0UKl; spf=pass (imf29.hostedemail.com: domain of libo.gcs85@bytedance.com designates 209.85.215.179 as permitted sender) smtp.mailfrom=libo.gcs85@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748597491; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rWr/E1U9MoZB6J4RM+OE8fwerNiGURyoNSQ2TTxCRRo=; b=mm66EACOmJh5PDEsx0cm1U1FVYVkA+XVZI6+l0VoSgjSz6gkNTRFHsk41ukgZZmQRfJmW1 2x5OSViQfmOAdugxkK6jgO2H6SYiMFHoP4ozFmcgnX+nvYhRNj/ob/gvXoWHHlOGvn8JK1 vSnR1u0ze53rA34JumAmlcKYhVYThn0= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=JjMY0UKl; spf=pass (imf29.hostedemail.com: domain of libo.gcs85@bytedance.com designates 209.85.215.179 as permitted sender) smtp.mailfrom=libo.gcs85@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748597492; a=rsa-sha256; cv=none; b=R+p8AimPjK9iE6Pqlflqw5LGet0f6SxiTOEs5fmdln9DSGBkl6HQ2Jn761akuD7O4KH5K7 Jr2fYgxsXGxpwRsB5MO5WOthjn6AFwGZtR7zVOWSPImxHa+8hkFUCtgSqqWuA7S0d1fjnG YylqmHCbDZndgSY3IX1vjJcfW5Zuz/U= Received: by mail-pg1-f179.google.com with SMTP id 41be03b00d2f7-b13e0471a2dso1244358a12.2 for ; Fri, 30 May 2025 02:31:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1748597491; x=1749202291; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=rWr/E1U9MoZB6J4RM+OE8fwerNiGURyoNSQ2TTxCRRo=; b=JjMY0UKlkAg6Y6YASaH1z5j+zKUXWV7T/rnuEMURd34uhF0oFdnxCuwYFl75QwqF5J iLOEKqokoz1dwxM4idQ83k7awv84rWMptN+71BZ4RkbeqG8x17ojNeYhZLj0ipxSXFHy k2Bmj5kdU/oVDqs5iOgbf/DMZQE9PRZeiVxl8+yUtAxkpgV2D9VVMLlW1zbV552RTtqe HagdCPcY83/cd4e35sGyuievO7SMD/AoR0FjWLiTPjXbON4efDEEEQh2T3XQ9XK9pepO OS2HzU0dF0pwKQWPYw3VpC4vfezzxSojIScOGQq4DJBOXIM19YyFIiQq+nBIeomp41xv hyJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748597491; x=1749202291; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rWr/E1U9MoZB6J4RM+OE8fwerNiGURyoNSQ2TTxCRRo=; b=ZcjtfBLa5JPcRRqX405dzdaizWjv5PSpgKreX1RlnFYfK7anr787yAeZrs8KcTRCHP JhJxqmZeLyL1dfK3cZYBBa8SqxvOAXBltGNWbqxLcRrfAg0c690wPZEmgkjM2uQDtT4N XjgBWfraoA+Od8wUE1JZw4+Rpqa8LydQOkP/CDbGcdDn22T/rRPmoPzpEI/dtDh1Hn34 c/R77atZLXxvSjXdUD4bUfojd3Ns1HyViTJ1cFzNC49M8uiiq1H6VPYcGiXl0c3oafRm 6CfOKTA8GhdWTXcrdOgofXoZkuUr5NGqmpWEtfvGZ0CpwW1gB6kgZsngYYyRAuNszMmU cmxQ== X-Forwarded-Encrypted: i=1; AJvYcCUpmGAMhmCqaFTDxRW1Lq5uVp08SQhtA3hzwQDdLThHViS6SNQvTXXpsNPgApg4JIbfOGQlesmIhQ==@kvack.org X-Gm-Message-State: AOJu0YxxZsqHfwtHQ+/0jHMUO3bz6Gvk93gld8uN/2CeaVGBMLWXyO2r ZXWeaW9+9gNN0zWIp0ygIZQlmSKtfaqY+viJYXUCemAxmmg4QICl1ksQJBCM8w/eZkk= X-Gm-Gg: ASbGncuWVUcZTRRHWUJGUOoifcKCusE4ArtNn7AKc4c8gWLVurhBgjwcko5rYXTLQ7z LpYoN3qC36AS+Mu/wA9QOkDFVb+pxgJg3VzYxgrDKBNJQbCozu6GaO+2TcrU5+wkzG1jyZHl5Ab 82JS+Kufgpy6PhFosLilm2K6Xliigqt4jBsRGaGi+XSGn6ZyIuPUemQ+ec+lYX2kHgiDzAOTN1j YSV1P2n4EEYcBG4jmjgV6dKPPARDtTmfgnMkbBG8tjdgkAzAU163pfZbgk6N5DiD+ccUE9TGCw3 PJlVN7aDlk5e7g/TWtNqUWQ/bCXqudviXOHED4TwiHk6Co6WtNt+qQvqgW5Ag62Gd+qbChtftME ylKkEzJpq0WbIMygPho8rx4ekgQYHL50= X-Google-Smtp-Source: AGHT+IHWxhBqxJC7pLUfy1wWPlfI3PTo1BKYuowDxnWEkooeR6TUqW9HSM93HT5AUTV5EBB5Y+mNrQ== X-Received: by 2002:a17:90b:48d2:b0:311:ad7f:3281 with SMTP id 98e67ed59e1d1-3125036ba85mr2606005a91.12.1748597490626; Fri, 30 May 2025 02:31:30 -0700 (PDT) Received: from FQ627FTG20.bytedance.net ([63.216.146.178]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3124e29f7b8sm838724a91.2.2025.05.30.02.31.15 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 30 May 2025 02:31:30 -0700 (PDT) From: Bo Li To: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, luto@kernel.org, kees@kernel.org, akpm@linux-foundation.org, david@redhat.com, juri.lelli@redhat.com, vincent.guittot@linaro.org, peterz@infradead.org Cc: dietmar.eggemann@arm.com, hpa@zytor.com, acme@kernel.org, namhyung@kernel.org, mark.rutland@arm.com, alexander.shishkin@linux.intel.com, jolsa@kernel.org, irogers@google.com, adrian.hunter@intel.com, kan.liang@linux.intel.com, viro@zeniv.linux.org.uk, brauner@kernel.org, jack@suse.cz, lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, vbabka@suse.cz, rppt@kernel.org, surenb@google.com, mhocko@suse.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, vschneid@redhat.com, jannh@google.com, pfalcato@suse.de, riel@surriel.com, harry.yoo@oracle.com, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, duanxiongchun@bytedance.com, yinhongbo@bytedance.com, dengliang.1214@bytedance.com, xieyongji@bytedance.com, chaiwen.cc@bytedance.com, songmuchun@bytedance.com, yuanzhu@bytedance.com, chengguozhu@bytedance.com, sunjiadong.lff@bytedance.com, Bo Li Subject: [RFC v2 12/35] RPAL: enable service disable notification Date: Fri, 30 May 2025 17:27:40 +0800 Message-Id: <20a49e36e1efc99b1489d81eb7b5fe8787fcee4c.1748594840.git.libo.gcs85@bytedance.com> X-Mailer: git-send-email 2.39.5 (Apple Git-154) In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Queue-Id: E0AA5120002 X-Rspamd-Server: rspam09 X-Stat-Signature: y4qzde3ecnm4wmuw5r1mq9uyoxgwigh8 X-HE-Tag: 1748597491-465005 X-HE-Meta: U2FsdGVkX186rlL7cmIVl+yD+V92QXvXSaEM8EE1pux+z1pP1jyJi6QSVpx6K9Mxz7vwGETAQpmXEA8OMH0Wbw7bJs0UKdPt4cFBvFTARs/WsOMgJ0SRU1GNP7v6b2RSfVKyx80LLltgay3a9pY2Yf17YaB10g9eT6b9zVmie/oO/Q666FU4ERTDwW0s+2nG/xJrB4U26S+DNuWwiTq3lB+LoqyXiJIXVsT3Sq1W6k/Kkas+fuoqSYXA1/uDHPha3kRKChFi9bwFZywDQngVucJ2hI6Zm31db21/NtznQk6d/vI+VCoAyJ5T1NJhUuRuKVREr53jx8k7CxYRubi84vS72/OvhOpeNKQCnETUhvx5mFOJAVzdq0KslxE1+OqZ1i21peAENrKPPlbwCFbJHDZrZlaMiSuZn7ZqfsT4/RyREbzT0PR+LYX649X0p0ulIMWi7ZKr+MgyzUTwP0VTWdRY6KGiRl8CsGf/NsAp9a7F5y0V/vQY2cwuH0z/8npm0M9RwalpVgD0kDyEaYkWwFx2KpkWONR45r0lAvvmh2Ba9M5CetcrCQnu2WjUqvC7YNsfLfrwqjEjA0N9go8vm0zCnxs5FP4PUP9DeGNQpyValF0Xo12LLbMVdSeJUPDfnt23rL87kvpwb0nhM9EmJDtL8Tz5xblk5hTHFnuZPnWvfMzY6QXiIma5Xl6rnFNxI8cpF+iH8okzf4+NSunq+uA73SLxYB8mfP30EMRn5rilt49ayTVdye++Z0Lr8M76heX5uOuFx1jhJwb6UfN66+bhJEHsr7erjaY1z5+9uEjog3rQbxDN4IuL9tcGm+pwyKREDbVf5C2XCFPpYiXqiwQGfis3niJ2iqwbnymixrOdx+lzLdqIVgpLwmLKaUeqy6X5x2wEr/Edgq43DyASbVs9suDgRurLi1ENAyF5ImvVBcNJRlrRWLISmHyiz8BI9FDLujojOivzz4JQFZZ UpsgPZqM oedfuskXZprAaau8t2yhWCn0KhNR4JEQg5Q9yRl9gl7uYP0RUVO08TIIUrwjgBGNcSaQieVL6qzxCgTkyoM41VGGxu/YxYcvGiFI1x9fLp1ZydkmIq47Ca1jsoNY5lu1V30yAZZfpHqPOV7wNUZnVphWMCfsIaO5RBg1JxwtabWXmnTUHU0wnsST8kqpBN+k/aU7VEcURDBbqakaUfDhG3nNAP46p61Ii1kb2H+RTSxg/jhxh5JEIua9RNXJ/ktfvVt5lND7oOkaYqVMxamOb11y8HnWV+UkePSv9wUiyqKfHM9YSJlnRYoUPpqv9IdffMGdsUoIeW6IP2J2jcJjQWhqq4A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: When a service is disabled, all services that request this service need to be notified. This patch use poll functions of file to implement such notification. When a service is disabled, it will notify all services that request it by set bit in others services' dead_key_bitmap. And the poll function will then issue a poll epoll event, other services can aware the service has been disabled. The key of disabled service can be read from the proc file. Signed-off-by: Bo Li --- arch/x86/rpal/proc.c | 61 +++++++++++++++++++++++++++++++++++++++++ arch/x86/rpal/service.c | 37 +++++++++++++++++++++++-- include/linux/rpal.h | 10 +++++++ 3 files changed, 106 insertions(+), 2 deletions(-) diff --git a/arch/x86/rpal/proc.c b/arch/x86/rpal/proc.c index f001afd40562..16ac9612bfc5 100644 --- a/arch/x86/rpal/proc.c +++ b/arch/x86/rpal/proc.c @@ -8,6 +8,7 @@ #include #include +#include #include "internal.h" @@ -82,10 +83,70 @@ static long rpal_ioctl(struct file *file, unsigned int cmd, unsigned long arg) return ret; } +static ssize_t rpal_read(struct file *file, char __user *buf, size_t count, + loff_t *pos) +{ + struct rpal_service *cur = rpal_current_service(); + struct rpal_poll_data *rpd; + u64 released_keys[MAX_REQUEST_SERVICE]; + unsigned long flags; + int nr_key = 0; + int nr_byte = 0; + int idx; + + if (!cur) + return -EINVAL; + + rpd = &cur->rpd; + + spin_lock_irqsave(&rpd->poll_lock, flags); + idx = find_first_bit(rpd->dead_key_bitmap, RPAL_NR_ID); + while (idx < RPAL_NR_ID) { + released_keys[nr_key++] = rpd->dead_keys[idx]; + idx = find_next_bit(rpd->dead_key_bitmap, RPAL_NR_ID, idx + 1); + } + spin_unlock_irqrestore(&rpd->poll_lock, flags); + nr_byte = nr_key * sizeof(u64); + + if (copy_to_user(buf, released_keys, nr_byte)) { + nr_byte = -EAGAIN; + goto out; + } +out: + return nr_byte; +} + +static __poll_t rpal_poll(struct file *filep, struct poll_table_struct *wait) +{ + struct rpal_service *cur = rpal_current_service(); + struct rpal_poll_data *rpd; + unsigned long flags; + __poll_t mask = 0; + + if (unlikely(!cur)) { + rpal_err("Not a rpal service\n"); + goto out; + } + + rpd = &cur->rpd; + + poll_wait(filep, &rpd->rpal_waitqueue, wait); + + spin_lock_irqsave(&rpd->poll_lock, flags); + if (find_first_bit(rpd->dead_key_bitmap, RPAL_NR_ID) < RPAL_NR_ID) + mask |= EPOLLIN | EPOLLRDNORM; + spin_unlock_irqrestore(&rpd->poll_lock, flags); + +out: + return mask; +} + const struct proc_ops proc_rpal_operations = { .proc_open = rpal_open, + .proc_read = rpal_read, .proc_ioctl = rpal_ioctl, .proc_mmap = rpal_mmap, + .proc_poll = rpal_poll, }; static int __init proc_rpal_init(void) diff --git a/arch/x86/rpal/service.c b/arch/x86/rpal/service.c index 16a2155873a1..f490ab07301d 100644 --- a/arch/x86/rpal/service.c +++ b/arch/x86/rpal/service.c @@ -181,6 +181,9 @@ struct rpal_service *rpal_register_service(void) atomic_set(&rs->req_avail_cnt, MAX_REQUEST_SERVICE); bitmap_zero(rs->requested_service_bitmap, RPAL_NR_ID); spin_lock_init(&rs->lock); + spin_lock_init(&rs->rpd.poll_lock); + bitmap_zero(rs->rpd.dead_key_bitmap, RPAL_NR_ID); + init_waitqueue_head(&rs->rpd.rpal_waitqueue); rs->bad_service = false; rs->base = calculate_base_address(rs->id); @@ -296,6 +299,7 @@ static void remove_mapped_service(struct rpal_service *rs, int id, int type_bit) clear_bit(type_bit, &node->type); if (type_bit == RPAL_REQUEST_MAP) { + clear_bit(id, rs->rpd.dead_key_bitmap); clear_requested_service_bitmap(rs, id); atomic_inc(&rs->req_avail_cnt); } @@ -424,15 +428,30 @@ static int release_service(struct rpal_service *cur, struct rpal_service *tgt) return 0; } +static void rpal_notify_disable(struct rpal_poll_data *rpd, u64 key, int id) +{ + unsigned long flags; + bool need_wake = false; + + spin_lock_irqsave(&rpd->poll_lock, flags); + if (!test_bit(id, rpd->dead_key_bitmap)) { + need_wake = true; + rpd->dead_keys[id] = key; + set_bit(id, rpd->dead_key_bitmap); + } + spin_unlock_irqrestore(&rpd->poll_lock, flags); + if (need_wake) + wake_up_interruptible(&rpd->rpal_waitqueue); +} + static void rpal_release_service_all(void) { struct rpal_service *cur = rpal_current_service(); struct rpal_service *tgt; + struct rpal_mapped_service *node; int ret, i; rpal_for_each_requested_service(cur, i) { - struct rpal_mapped_service *node; - if (i == cur->id) continue; node = rpal_get_mapped_node(cur, i); @@ -449,6 +468,20 @@ static void rpal_release_service_all(void) } rpal_put_service(tgt); } + + for (i = 0; i < RPAL_NR_ID; i++) { + if (i == cur->id) + continue; + + node = rpal_get_mapped_node(cur, i); + tgt = rpal_get_service(node->rs); + if (!tgt) + continue; + + if (test_bit(RPAL_REVERSE_MAP, &node->type)) + rpal_notify_disable(&tgt->rpd, cur->key, cur->id); + rpal_put_service(tgt); + } } int rpal_release_service(u64 key) diff --git a/include/linux/rpal.h b/include/linux/rpal.h index 1fe177523a36..b9622f0235bf 100644 --- a/include/linux/rpal.h +++ b/include/linux/rpal.h @@ -107,6 +107,13 @@ struct rpal_mapped_service { struct rpal_service *rs; }; +struct rpal_poll_data { + spinlock_t poll_lock; + u64 dead_keys[RPAL_NR_ID]; + DECLARE_BITMAP(dead_key_bitmap, RPAL_NR_ID); + wait_queue_head_t rpal_waitqueue; +}; + /* * Each RPAL process (a.k.a RPAL service) should have a pointer to * struct rpal_service in all its tasks' task_struct. @@ -161,6 +168,9 @@ struct rpal_service { struct rpal_mapped_service service_map[RPAL_NR_ID]; DECLARE_BITMAP(requested_service_bitmap, RPAL_NR_ID); + /* Notify service is released by others */ + struct rpal_poll_data rpd; + /* delayed service put work */ struct delayed_work delayed_put_work; -- 2.20.1