From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C7D5C433EF for ; Tue, 4 Jan 2022 21:40:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0891E6B0073; Tue, 4 Jan 2022 16:40:45 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 039016B0074; Tue, 4 Jan 2022 16:40:44 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DF4B06B0075; Tue, 4 Jan 2022 16:40:44 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0025.hostedemail.com [216.40.44.25]) by kanga.kvack.org (Postfix) with ESMTP id D25B96B0073 for ; Tue, 4 Jan 2022 16:40:44 -0500 (EST) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 7BD548DA5E for ; Tue, 4 Jan 2022 21:40:44 +0000 (UTC) X-FDA: 78993924408.13.D08D6B5 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2040.outbound.protection.outlook.com [40.107.220.40]) by imf27.hostedemail.com (Postfix) with ESMTP id 1B9B04000A for ; Tue, 4 Jan 2022 21:40:40 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HvdRy6Ei4MLtOzCkRGKYIQREBUI4Ox1642EL8a7JYMJH5Oa3nIfKxqWL3I6kKgXDNA4XLacsOUTtXaxq4loz+HFokAaPjc15vo5wgovp84jJg+9/OX/LIYyf2eh9OuQIwNs6yeaeg4Nw4vBty92UXpRXyQ/PK4vjid+ZViFTy5za26ikoVHsJE2z3vz3edtsDoFUUAhVplyIiNHM4covArnd763SNlKFCw9+Fk9r7i3AXZt5Hr5XsWT3/wlruABaGKsE45zfEUMjyga55XJa/EyCJ5vMKXi2s1MEbRbuGwMhYvnQ97oihydqlnL35s0i0HkHRFjv8ugYq31/9Os3dA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cnf/ltj7MZx3cRbMucoAOBBVsFNgvV5WSBpZldqAB8M=; b=bQKtu+UXuOp8P4qHd+S6WhKCXDbzOE+yhW0RZTaLeSl80c3deNRfY6M1iM29vRpnCB/r0v3U7nI6kz+e1ccwLZAitSgQA6aLclk2ajwsotnYxEstO3EB1qJ8YC40PbOMjAsLYWrmt4TTy4dmUqTZ56fufT9eqFC+njNFoyFUSoEdFP/JYKGqG1dEcD/6HgghPmGhPOzaM3oaJk9bHRPk7Oz3cHrvTxVXuyOurr2FX4pax1mwsHbCKf0Ps+7pXDzJmRiJrBLIac4AYWkFZBZlRcLYvBe8sAkszrTRcC0xCpOOIb2ab0U0rzuAy5KWPEOOrH8ZBf/+rWnLybPcM6odOg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cnf/ltj7MZx3cRbMucoAOBBVsFNgvV5WSBpZldqAB8M=; b=oL+FU5mzkIVTBYfVrOINgrcLXnKNH5xMiQR0+Ao7E0nQQIIXYVg0aeoTVCr8RygBgI2Q4yzQXfAbjVRI22bed1mgfsoxQ2bfpvLsJ2InSLq8anU5lASbJoKXGXQcenynZUBiA6rbU7y7Z0OmZl4/eCBTuIiJ5/FvzXdIgR+k2IyAscVFL44vVUyzGFWuoMdDxXKbENqBK6HF6xlK7ovHD9AlR13OQolKfbSAn2qMf2bJCBtACFV7xbIb5knrwgsP9DlFuvB8Ph3wU1+OT4ylATj5PPzO27X7Q4DW/9XeDqRmaruG/E/G/bpQlqohY74VTsGexSVa9SLPRDkttaWq6Q== Received: from BY5PR12MB4130.namprd12.prod.outlook.com (2603:10b6:a03:20b::16) by BY5PR12MB4935.namprd12.prod.outlook.com (2603:10b6:a03:1d9::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4844.15; Tue, 4 Jan 2022 21:40:38 +0000 Received: from BY5PR12MB4130.namprd12.prod.outlook.com ([fe80::8496:16fd:65c5:4af7]) by BY5PR12MB4130.namprd12.prod.outlook.com ([fe80::8496:16fd:65c5:4af7%4]) with mapi id 15.20.4844.015; Tue, 4 Jan 2022 21:40:38 +0000 Message-ID: <20a06269-3bea-27c3-568f-6459fa3374ab@nvidia.com> Date: Tue, 4 Jan 2022 13:40:36 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.1 Subject: Re: [PATCH 02/17] mm: Add folio_pincount_available() Content-Language: en-US To: "Matthew Wilcox (Oracle)" , linux-mm@kvack.org Cc: Andrew Morton References: <20220102215729.2943705-1-willy@infradead.org> <20220102215729.2943705-3-willy@infradead.org> From: John Hubbard In-Reply-To: <20220102215729.2943705-3-willy@infradead.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SJ0PR03CA0222.namprd03.prod.outlook.com (2603:10b6:a03:39f::17) To BY5PR12MB4130.namprd12.prod.outlook.com (2603:10b6:a03:20b::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0fd3856e-9695-405b-d096-08d9cfcad90c X-MS-TrafficTypeDiagnostic: BY5PR12MB4935:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2399; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: a9eFr9bi6uFzYHfnGCx/I33pal8g7AEFh1Qr2eMRZL+wnO13Aq8J8kuxuel9bR8h8NUeBnp13fSHlQsNekQd81rGzPG4diWWz/cSX7viStBLY1VOWCoiLwnViqQWLDO7V2dAdtgYQrSjp3RrcV0vf093M81INHmQrq/snv0fR7W7Fko8RN6ZJ/tqp+Htb+BALOry0WnTQ1aAVhKf3SnLRQbqLFwHgW70xqUDfVWo3225A+xGRQcwalWffHjDCXbMHUnM6c0Z6tWGjnAY7iJWd7blsDxYI2gEmhxjzVDJn1YH4I8VhYJPbNsge0VCcjNN/BPx/q2hJknEYp1ylE1OQwnqfrtERGynDNkPJxYxz/rIrvQDp/FmK8YccJaI0Q22iPZW/PIzW8viEDHy3N+bjWvRjEE9WZ9T6QN5k6CBY6tyZPvlk2fnyY9Uy/hGqxS/a7/X/LyIl8T5ocK0weMfoO12BNhrXkgqMFhJNcU1pyouuQPOE3czjgyrNURfdYdrmjCwjzKGZDGzI22MgDRDZEorcq+pyrojrvT0F7lB/ySqRSqOZMFOxrRVfn47OEbUCXeQArmdd3OeRHdGFwAXKzmHuHXj4aILX2Q+jn5YdMFgDe2H5SUr2Y6bnhK55p00K7H00XSprcpDd5mkIApN9Ar/BtAtF94buNDPIxlBqYGDk3fanQxe4i3OTlSn8k1pwTPlYt7TX6A6IjZKnEPcqZPwdWJKQ43493dz5RT0zXrXt3FkSWLe3cyG/KwaEQFIxm/BH2KuuGuYBXQbHKGsyw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BY5PR12MB4130.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(31696002)(5660300002)(66946007)(316002)(508600001)(8676002)(4326008)(31686004)(38100700002)(86362001)(53546011)(26005)(2616005)(83380400001)(6506007)(36756003)(6486002)(186003)(2906002)(6512007)(66476007)(66556008)(8936002)(131093003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?blhzSWVFeU9zeFJQclU2b1VlRkxJVzlmc1RUMVVHMmhaQ0VMUWI5Z21RSzVs?= =?utf-8?B?V1ZmZGtWbnJwNDdaTTludUc3bk5odFRzZDdlOHlrQURBcWFEd0UzR2xWaHdm?= =?utf-8?B?blB6Y0RFSVo1KytWaUNoWW43bGN0UUdDWkFnUzkyU3RsNVVBU0FsRTNBWXlQ?= =?utf-8?B?WWh4aGhEa0JSc3dpTDlvWlZOeGdQOGdHc204SDl0eEtnaXRMVGdHcUtvT2x1?= =?utf-8?B?cFpjdTRHL205SXROZTJaQnBCby9RRzNJSlYzd0VOTmlWSFNGTlJpeGNVcE1k?= =?utf-8?B?QnovVWxVZnIvY0FqVWp3ZHJSeDlRTWxidXliT2h2anlUdnhVRXpxNUc1YVZh?= =?utf-8?B?NU1haTdoVmpRMnlRVnVqM2VMMy9Pc04ySHl0d25FemlLTmljb1FLUzMrd0lw?= =?utf-8?B?SjhWUVc4WWZNeC9TR3YrQWp3RkZNSjE2UFN3cTV4djFValY2bXlrNERRdXJm?= =?utf-8?B?M2FIUjVlcWN0UGk3Q3REM0VodUREblF6Z3N5d1ZPRlluNEVnS1RUSDhsS1Ev?= =?utf-8?B?b2t4R3lVRFNMTUlLaDZmUDRiRDhGdEJjSzYyaEtuRUVncUh5YW9jSlp3Znc0?= =?utf-8?B?YjlyUE9XbmdTTnJXeTB0YS93UEtwbndMTGVodndidk9Kb0xqcWM3dkY5b3NQ?= =?utf-8?B?eU8zd0NpTUtXYTY0TkROcUZFVDRpQm9tYzVRRmNqeEN4dENndUVIN2xyREMx?= =?utf-8?B?S1NFVFViNjVhUmpWNkhGdEZJQUloM0pmNmpKalRWeEZtK00vM1ZOVmRDalhJ?= =?utf-8?B?QW96Y0JCS1ZKZnpoVjNOTnVvaFBua1FDVEJrK3pVcHdUZlM1Y3dGQXgxaXFp?= =?utf-8?B?QnNYVDFRK2gyOTZzQUNFZGZ6bEl6aVNuVTlySWtMdUNJT0luU3k2Z0tEbUlz?= =?utf-8?B?L09CQ2hMT09mRjNYeVFVTXRONWcxcWlZemVONlRodi9pcGdZTThaUWZWTnRQ?= =?utf-8?B?bUxhR1NkSWluQTZOUGF2NkFiQVpYcE4ydTN4M0NqYVBLWC8yRlcrdTE2MHFB?= =?utf-8?B?VTFvSUxGZmdtMTF4bnZEWEIvSEk2YThDT2JhOW94UWJ1UzBEdVVMaXRGOCtB?= =?utf-8?B?Z2RJRWpGQ0d0cFhZR0pYSHl1Skl0S3ZsQnNaQStrWVR3QmwrUWtiYmFBa25H?= =?utf-8?B?dUJhV0RoZzE5N2hlUGJiY21vN3JPNVNwNkY4UlFTTU5ETzZabWpodjd3R09y?= =?utf-8?B?MjZndVg4WFBHRWg4MWVYZllVL3VZZFV3VDk3QW9OM240MkY5L0Zqdk5MbVlQ?= =?utf-8?B?cmtnaTBja3FFK3FMR0p0SkpuOERzQThqeDcvM3dtVGp1NFova3dacmltMGw3?= =?utf-8?B?aWhEem1GOWlYNDJidFVXR0FRKytCc3lHaEpwTDdoRVR0RHVFWnFxQ0IxSDUw?= =?utf-8?B?QWxyNzR4VVNibTdpdjhwRVVWY0FWSXFBd281WEhERHExY3hLZW5SR0Fra1BP?= =?utf-8?B?UWN2dTFTV0xWSXd4VWlCdG00SjVWQWFsS2Q3ZXczQjJpbE1ISDQwMHExRzdr?= =?utf-8?B?VmY4YW1HdjA1amJTNTlUaklMNjhUSldNelZLUmJMQXFYWG9EbnNJYWJqVnlE?= =?utf-8?B?ZE41a2FTZDd6Y2hZT0taZFRnRVZjWkNJcTBKODZNTmtCTWxXbGRnQ0taa050?= =?utf-8?B?Y3BJblJadDd4RkVoem9XVmtNeTBiOU4yRHB3RWEzT3RNckMvSms1ZzlvdVRF?= =?utf-8?B?U2xuMktUZ1FHelcxZEVWZkYrdFhsTkVqbnNKUEowUHZVUGdZOFlKcXNMUzdo?= =?utf-8?B?bFZUN09Tb3E4bzk3S0Z2c29nRjFCYjdmOUtqZzhKaGhhTlpjb2F1ekgrVFhp?= =?utf-8?B?M0Mrak5RU2FvOFdGUjRUN1pLMFdmQ0NCKzRMZmZjU2oyYWtZUkdmZG5od0ds?= =?utf-8?B?OEw1bU5wN3JvMjVRek5MSjBkMmg0TlE2ZGx5dnhKQVg3NkVwTmxtOGJWaTdj?= =?utf-8?B?RGQzeUU5NUN0QTlYallKTFgvUDJDeHl3T3ozNE1EMFgreWhpT1VobCtsYzFz?= =?utf-8?B?di9SQXlJZlVMK09vV1MvZ01yelh3R05najd6ZlJNZlQwTHpSa1c5THloVUZl?= =?utf-8?B?OW5palE1dGhqSHNjTWQrUk9FQ2tDcjBDdTZQZVBncGR4T3ROVE5RRU1laVF4?= =?utf-8?B?ZnBGRGxqSHlSV05ueGRhMHV1Q0hQUldDWWJIdWdxakcvc09pZk4xcnB1NnNQ?= =?utf-8?Q?BWS074pi37RMrm2PrMjQvaI=3D?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0fd3856e-9695-405b-d096-08d9cfcad90c X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB4130.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jan 2022 21:40:38.2255 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: g8zVJkGNQEuEQ+HHnfwebSMau9f1jOo+sDeimpsyu0XeY5WTP4Afb3RqSuEIcNC8lSO0qekKoHupb8SJT2D+Eg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4935 X-Rspamd-Queue-Id: 1B9B04000A X-Stat-Signature: won1i4d7kfsjccgsc1y3wcy4p7ewt9g5 Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=oL+FU5mz; dmarc=pass (policy=reject) header.from=nvidia.com; spf=none (imf27.hostedemail.com: domain of jhubbard@nvidia.com has no SPF policy when checking 40.107.220.40) smtp.mailfrom=jhubbard@nvidia.com X-Rspamd-Server: rspam11 X-HE-Tag: 1641332440-327803 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 1/2/22 13:57, Matthew Wilcox (Oracle) wrote: > Convert hpage_pincount_available() into folio_pincount_available() and > turn hpage_pincount_available() into a wrapper. We don't need to > check folio_test_large() before checking folio_order() as > folio_order() includes a check of folio_test_large(). > > Signed-off-by: Matthew Wilcox (Oracle) > --- > include/linux/mm.h | 12 ++++++++---- > 1 file changed, 8 insertions(+), 4 deletions(-) > > diff --git a/include/linux/mm.h b/include/linux/mm.h > index 98a10412d581..269b5484d66e 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -927,15 +927,19 @@ static inline void destroy_compound_page(struct page *page) > compound_page_dtors[page[1].compound_dtor](page); > } > > -static inline bool hpage_pincount_available(struct page *page) > +static inline bool folio_pincount_available(struct folio *folio) > { > /* > - * Can the page->hpage_pinned_refcount field be used? That field is in > + * Can the folio->hpage_pinned_refcount field be used? That field is in > * the 3rd page of the compound page, so the smallest (2-page) compound > * pages cannot support it. > */ > - page = compound_head(page); > - return PageCompound(page) && compound_order(page) > 1; > + return folio_order(folio) > 1; I see, no need to look at the compound page head, because folio_order() returns zero for tail pages, and neatly avoids all of that. > +} > + > +static inline bool hpage_pincount_available(struct page *page) > +{ > + return folio_pincount_available(page_folio(page)); > } > > static inline int head_compound_pincount(struct page *head) Reviewed-by: John Hubbard thanks, -- John Hubbard NVIDIA