From: "Luruo, Kuthonuzo" <kuthonuzo.luruo@hpe.com>
To: Dmitry Vyukov <dvyukov@google.com>
Cc: Andrey Ryabinin <aryabinin@virtuozzo.com>,
Alexander Potapenko <glider@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
kasan-dev <kasan-dev@googlegroups.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] kasan: improve double-free detection
Date: Tue, 3 May 2016 07:53:17 +0000 [thread overview]
Message-ID: <20E775CA4D599049A25800DE5799F6DD1F61F1B2@G9W0752.americas.hpqcorp.net> (raw)
In-Reply-To: <CACT4Y+Z_+crRUm0U89YwW3x99dtx9cfPoO+L6mD-uyzfZAMkKw@mail.gmail.com>
> I missed that Alexander already landed patches that reduce header size
> to 16 bytes.
> It is not OK to increase them again. Please leave state as bitfield
> and update it with CAS (if we introduce helper functions for state
> manipulation, they will hide the CAS loop, which is nice).
>
Available CAS primitives/compiler do not support CAS with bitfield. I propose
to change kasan_alloc_meta to:
struct kasan_alloc_meta {
struct kasan_track track;
u16 size_delta; /* object_size - alloc size */
u8 state; /* enum kasan_state */
u8 reserved1;
u32 reserved2;
}
This shrinks _used_ meta object by 1 byte wrt the original. (btw, patch v1 does
not increase overall alloc meta object size). "Alloc size", where needed, is
easily calculated as a delta from cache->object_size.
Kuthonuzo
next prev parent reply other threads:[~2016-05-03 7:53 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-02 9:49 Kuthonuzo Luruo
2016-05-02 10:09 ` Dmitry Vyukov
2016-05-02 11:30 ` Luruo, Kuthonuzo
2016-05-02 11:35 ` Dmitry Vyukov
2016-05-03 9:24 ` Luruo, Kuthonuzo
2016-05-03 17:50 ` Dmitry Vyukov
2016-05-07 10:21 ` Luruo, Kuthonuzo
2016-05-02 11:41 ` Dmitry Vyukov
2016-05-02 11:47 ` Alexander Potapenko
2016-05-03 7:58 ` Luruo, Kuthonuzo
2016-05-03 7:53 ` Luruo, Kuthonuzo [this message]
2016-05-03 17:42 ` Dmitry Vyukov
2016-05-04 20:13 ` Luruo, Kuthonuzo
2016-05-05 5:34 ` Dmitry Vyukov
2016-05-05 6:23 ` Luruo, Kuthonuzo
2016-05-05 6:55 ` Dmitry Vyukov
2016-05-07 8:56 ` Luruo, Kuthonuzo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20E775CA4D599049A25800DE5799F6DD1F61F1B2@G9W0752.americas.hpqcorp.net \
--to=kuthonuzo.luruo@hpe.com \
--cc=akpm@linux-foundation.org \
--cc=aryabinin@virtuozzo.com \
--cc=dvyukov@google.com \
--cc=glider@google.com \
--cc=kasan-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox