From: Aruna Ramakrishna <aruna.ramakrishna@oracle.com>
To: Jeff Xu <jeffxu@chromium.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"x86@kernel.org" <x86@kernel.org>,
"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Ingo Molnar" <mingo@kernel.org>,
"Keith Lucas" <keith.lucas@oracle.com>,
"rick.p.edgecombe@intel.com" <rick.p.edgecombe@intel.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"Jorge Lucangeli Obes" <jorgelo@chromium.org>,
"Jeff Xu" <jeffxu@google.com>,
"Kees Cook" <keescook@chromium.org>,
"Stephen Röttger" <sroettger@google.com>,
"Jann Horn" <jannh@google.com>
Subject: Re: [PATCH v6 0/5] x86/pkeys: update PKRU to enable pkey 0 before
Date: Tue, 30 Jul 2024 23:06:51 +0000 [thread overview]
Message-ID: <20B4F26C-A5E8-433C-A441-EAAEE8A31658@oracle.com> (raw)
In-Reply-To: <CABi2SkVFpDK_Dugz68Vu4dZ+Jk5bhiEYDuPbNnGu8W9Nbw1m4g@mail.gmail.com>
> On Jul 16, 2024, at 9:25 PM, Jeff Xu <jeffxu@chromium.org> wrote:
>
> Hi Aruna,
>
> I added Rick who commented on the previous version of patch. I added
> Kees/Jorge/Stephan/Yann, they expressed interest in similar
> functionality before. It would be best to keep them in future versions
> of this patch.
>
> I also add linux-mm for more reviews/feedback on signal handling path.
>
> On Thu, Jun 27, 2024 at 2:17 PM Aruna Ramakrishna
> <aruna.ramakrishna@oracle.com> wrote:
>>
>> v6 updates:
>> - Rebased patchset to v6.10.0-rc5
>> - Changed sig_prepare_pkru() back to enabling all pkeys, based on
>> discussion with Jeff Xu
> Thanks for taking the suggestion.
>
>>
>> As Jeff mentioned, I'm unsure if we need to retain the changes to the
>> 32-bit functions. Maintainers - please advise.
>>
> It is possible to reduce the size of change.
> Not touching the ia32 or x32 code path also means less test in
> multiple architectures and less risk of regression.
Apologies for the delay in responding - I was on vacation and got back
yesterday.
I agree, I’m unsure if 32-bit support is needed here - as you pointed out in an
earlier email, the man page says:
“The feature is only available in 64-bit mode, even though there is theoretically
space in the PAE PTEs.”
I was hoping that Dave/Thomas would review and clarify. I will remove the
32-bit support from this patchset and send out a v7.
Thanks,
Aruna
next prev parent reply other threads:[~2024-07-30 23:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240627211737.323214-1-aruna.ramakrishna@oracle.com>
2024-07-17 4:25 ` Jeff Xu
2024-07-30 23:06 ` Aruna Ramakrishna [this message]
[not found] ` <20240627211737.323214-2-aruna.ramakrishna@oracle.com>
2024-07-17 4:25 ` [PATCH v6 1/5] x86/pkeys: Add PKRU as a parameter in signal handling functions Jeff Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20B4F26C-A5E8-433C-A441-EAAEE8A31658@oracle.com \
--to=aruna.ramakrishna@oracle.com \
--cc=dave.hansen@linux.intel.com \
--cc=jannh@google.com \
--cc=jeffxu@chromium.org \
--cc=jeffxu@google.com \
--cc=jorgelo@chromium.org \
--cc=keescook@chromium.org \
--cc=keith.lucas@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@kernel.org \
--cc=rick.p.edgecombe@intel.com \
--cc=sroettger@google.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox