From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A5AEC27C53 for ; Fri, 7 Jun 2024 19:36:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 98C486B00B5; Fri, 7 Jun 2024 15:36:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 93CDD6B00B7; Fri, 7 Jun 2024 15:36:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 804356B00B9; Fri, 7 Jun 2024 15:36:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 6234B6B00B5 for ; Fri, 7 Jun 2024 15:36:43 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 0475EC0361 for ; Fri, 7 Jun 2024 19:36:42 +0000 (UTC) X-FDA: 82205099886.14.2041D4B Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6]) by imf08.hostedemail.com (Postfix) with ESMTP id EC23B16000F for ; Fri, 7 Jun 2024 19:36:40 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=igalia.com header.s=20170329 header.b=VIHXZStj; dmarc=none; spf=pass (imf08.hostedemail.com: domain of gpiccoli@igalia.com designates 178.60.130.6 as permitted sender) smtp.mailfrom=gpiccoli@igalia.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717789001; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zu1ZBxNv57bpE9Use4oXfVWpCn5+Wvtvp0w80A7iIPs=; b=XYLt/LmSF5SMj178Xiu1EarJbZ6LKtnn4N30ahcVRGQJkn1MmfSDOSjoTlnXTqJpkhsrwY fKOAICRF3qTe8C8QI09NGwSqVEFMEeKnbScFOKpmOhadbU7NOVKAg6AVDXPO5ZIMSPAWcd keVB264BPx5+Sp/lE/SOu2N6rgWMolY= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=igalia.com header.s=20170329 header.b=VIHXZStj; dmarc=none; spf=pass (imf08.hostedemail.com: domain of gpiccoli@igalia.com designates 178.60.130.6 as permitted sender) smtp.mailfrom=gpiccoli@igalia.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717789001; a=rsa-sha256; cv=none; b=4t1iC6Er0izH5XFE275QXClkS17ymcjSmhOMehBQPn1UA1hb444HM1PssFq2aBhbXxG7wg GB9kwLptczK9awgEKYYUfyTg2gJ/8Bkecn2LC5w+R3ym6nXU5m2zi9RLs2hIznHu6kfhDD i7pZNoJ3mZp/ccIwt43fEc1zxoolFLs= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=zu1ZBxNv57bpE9Use4oXfVWpCn5+Wvtvp0w80A7iIPs=; b=VIHXZStjS7kU9eFQIqDC3lMeVW 86rBHkG8Egbh2q0zQ0qw8h3oMaIIPuVJLqEUdH1Tg9ZOPq3iCI5zwK6k2mINRgwEwjtk34GVpxatf m8zuPTORwUv3B0S21w8p5XwBm+cQtbWGc485UhSaou/E7/RZt3oo+HzeBdW4ohjToTYmAsfG3B1r/ dKQlxcUqzN7ZGPVm0s7vyiZ5Enl2dcpIAhpRV8+ldBYGoCriapn1lubufMK7/p7v0EX7T5mFtOvT+ QlmAtB1ylZnv9/faiy1iQoLYK2hx59aUu8IyIeP4zxziyBcE/C7BClDar9TboR27AQ2yE9gZsrqVE P5xdpP2g==; Received: from [191.205.188.103] (helo=[192.168.1.60]) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_128_GCM:128) (Exim) id 1sFfNa-000e7M-9Y; Fri, 07 Jun 2024 21:36:02 +0200 Message-ID: <2093d20d-23e1-1c22-f3ad-8b7413b5a60f@igalia.com> Date: Fri, 7 Jun 2024 16:35:50 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH v2 1/2] mm/memblock: Add "reserve_mem" to reserved named memory at boot up Content-Language: en-US To: Steven Rostedt Cc: linux-kernel@vger.kernel.org, Masami Hiramatsu , Mark Rutland , Mathieu Desnoyers , Andrew Morton , "Liam R. Howlett" , Vlastimil Babka , Lorenzo Stoakes , linux-mm@kvack.org, Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Peter Zijlstra , Kees Cook , Tony Luck , linux-hardening@vger.kernel.org, Guenter Roeck , Ross Zwisler , wklin@google.com, Vineeth Remanan Pillai , Joel Fernandes , Suleiman Souhlal , Linus Torvalds , Catalin Marinas , Will Deacon , Ard Biesheuvel , Mike Rapoport , linux-trace-kernel@vger.kernel.org References: <20240606150143.876469296@goodmis.org> <20240606150316.751642266@goodmis.org> From: "Guilherme G. Piccoli" In-Reply-To: <20240606150316.751642266@goodmis.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: EC23B16000F X-Stat-Signature: btb8ee5br7x7zpgc5yox4ob6macu49om X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1717789000-46356 X-HE-Meta: U2FsdGVkX1/nSfXpyfjI6Z4b4qOMwpT8tjOU1kllXs8N2upi4Oc+zDsfp76Z9o76j9jCx6X0Hbl6IpbIp54hp4NhMP1QEPyymw6vgwaHgV4l9Wm/tmlM1eioRKvX2Vr99v5RCa0D4pIt+QTG6+h5d4ZD9exAmqQet7dubRb7S1K/ejwKwuatcZ5siYL/CRyIfNfYfrSUgvl38seDD4Bf7iE26WOUVW5wIkdi2NxBIFyILseiUBEnFvsjBKJ93LMzO06YD657a/raHqZlg4MmD6JHrQvMeAHrmKxsItsxewRqNhUCpDvl4BWE2lVpCfWzqIV/FGSb7Xndq4bD+bQ1uz7g1RHN9aQLeZgALreeIxxLYjRw++3AVNhu17CtP1181GliFCCqN8GBM3PUz/94qJMyLRqg7qscBAMSCO2aMyklDDVppaVdol2c21CHNG9oE8qSaM26YlwMoRptL+PxIVZ2WLQ2I06Y1dUpeCX1Kdl9KziRLNztGNiffXuwfOL24pzmNUfmu6jXakw9mtCfsO5aR02jwO2Nd5RSraA/lVOjQ3h0qycJkUD8XXJToRPsuudcIXkDFBeUYbI/Khj8HaN+Gs4sevvHX+l+SG3O0ic0O9u/Q+hLVlCefMc8FxSeeXjUpGuCDhp8TvU2tqBMqeSFQPkCOqWm8+96x8FfvxdbA9KjrDXrtERXof5olKVBjuYlwZ9GPDpParUpnv1R7zWR2OYCxkRGxZwZ9yxMtGuNCMF1WK86w96tkdRisXukGsyReByap0Z+X7fJZFUv6i3tb4AZITWMKuDcZoR+lH/4fLiVqTMr7208yfSIOeJd6sEnc7TTfdoUaFkC+boRHQfcwj1dFX2ZiGXYAayODp6tPmhf3/RM3IgiHeOMTwx4bgdD9l/ZZkZGTyj06muD3quTYComZ58eTy51EsQcZKxFmXB5rR8OZ6CdredZF20ExA/lXj2C0wS+HWPBJl4 GePNNan8 7H8Jd2OdVbiH/JzIT1Q+noSrpIke5ygcryaC9UCdOqygZEis10+5WVmIP47lM/lRnIGBvqRDyjo25P3QUIG4/LTI12qLhgeQvcqfzHyHg8IrCjWis83W3bsp1K3nrNac6jsjFYE2eYZcSKJAuMPKQ4vf/kO7Q5QckC7PiuqSWIT+5kl4Akv38CMBclGSt7ZULb8oG X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Steve, thanks for the patch! Some suggestions/fixes below, inline. On 06/06/2024 12:01, Steven Rostedt wrote: > [...] > + > + The format is size:align:label for example, to request > + 12 megabytes of 4096 alignment for ramoops: > + > + reserver_mem=12M:4096:oops ramoops.mem_name=oops s/reserver/reserve > [...] > + * reserve_mem_find_by_name - Find reserved memory region with a given name > + * @name: The name that is attached to a reserved memory region > + * @start: If found, holds the start address > + * @size: If found, holds the size of the address. > + * > + * Returns: 1 if found or 0 if not found. > + */ > +int reserve_mem_find_by_name(const char *name, unsigned long *start, unsigned long *size) > +{ > + struct reserve_mem_table *map; > + int i; > + > + for (i = 0; i < reserved_mem_count; i++) { > + map = &reserved_mem_table[i]; > + if (!map->size) > + continue; > + if (strcmp(name, map->name) == 0) { > + *start = map->start; > + *size = map->size; > + return 1; > + } > + } > + return 0; > +} > + An EXPORT_SYMBOL_GPL(reserve_mem_find_by_name) is needed here, or else ramoops fails to build as module - at least it worked with this exporting in my build of 6.10.0-rc2 =) Cheers, Guilherme