* [PATCH -next] mm/hugetlb: stop using 0 as NULL pointer
@ 2022-11-21 10:20 Yang Li
2022-11-21 12:48 ` David Hildenbrand
0 siblings, 1 reply; 2+ messages in thread
From: Yang Li @ 2022-11-21 10:20 UTC (permalink / raw)
To: mike.kravetz
Cc: songmuchun, akpm, linux-mm, linux-kernel, Yang Li, Abaci Robot
mm/hugetlb.c:1531:37: warning: Using plain integer as NULL pointer
Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3224
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
mm/hugetlb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/hugetlb.c b/mm/hugetlb.c
index 222937d512c4..b6c2fc882f21 100644
--- a/mm/hugetlb.c
+++ b/mm/hugetlb.c
@@ -1528,7 +1528,7 @@ static void add_hugetlb_folio(struct hstate *h, struct folio *folio,
}
folio_set_compound_dtor(folio, HUGETLB_PAGE_DTOR);
- folio_change_private(folio, 0);
+ folio_change_private(folio, NULL);
/*
* We have to set HPageVmemmapOptimized again as above
* folio_change_private(folio, 0) cleared it.
--
2.20.1.7.g153144c
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH -next] mm/hugetlb: stop using 0 as NULL pointer
2022-11-21 10:20 [PATCH -next] mm/hugetlb: stop using 0 as NULL pointer Yang Li
@ 2022-11-21 12:48 ` David Hildenbrand
0 siblings, 0 replies; 2+ messages in thread
From: David Hildenbrand @ 2022-11-21 12:48 UTC (permalink / raw)
To: Yang Li, mike.kravetz
Cc: songmuchun, akpm, linux-mm, linux-kernel, Abaci Robot
On 21.11.22 11:20, Yang Li wrote:
> mm/hugetlb.c:1531:37: warning: Using plain integer as NULL pointer
>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3224
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
> mm/hugetlb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/hugetlb.c b/mm/hugetlb.c
> index 222937d512c4..b6c2fc882f21 100644
> --- a/mm/hugetlb.c
> +++ b/mm/hugetlb.c
> @@ -1528,7 +1528,7 @@ static void add_hugetlb_folio(struct hstate *h, struct folio *folio,
> }
>
> folio_set_compound_dtor(folio, HUGETLB_PAGE_DTOR);
> - folio_change_private(folio, 0);
> + folio_change_private(folio, NULL);
> /*
> * We have to set HPageVmemmapOptimized again as above
> * folio_change_private(folio, 0) cleared it.
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-11-21 12:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-21 10:20 [PATCH -next] mm/hugetlb: stop using 0 as NULL pointer Yang Li
2022-11-21 12:48 ` David Hildenbrand
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox