From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C6C3C4332F for ; Mon, 21 Nov 2022 12:48:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5579B8E0013; Mon, 21 Nov 2022 07:48:51 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5074E8E000C; Mon, 21 Nov 2022 07:48:51 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3CF5E8E0013; Mon, 21 Nov 2022 07:48:51 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 2D7B58E000C for ; Mon, 21 Nov 2022 07:48:51 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 0A8CB40A83 for ; Mon, 21 Nov 2022 12:48:51 +0000 (UTC) X-FDA: 80157428862.15.49329FE Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf03.hostedemail.com (Postfix) with ESMTP id 0A5292000E for ; Mon, 21 Nov 2022 12:48:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1669034929; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aHf92GqKpS09QwwfFT9qcxPp2ZW8/6FXVgc85jLdYtQ=; b=cNaFqOLn20NZ0PeXcLNpY3D7lRmy//VvsQEwIceD8vTH8D+7imL7oRUjrc9d/pRDxHG00n 9HpDeHP96guQaV2t/63MR/CGI8rLu8IZ7cyJSZ6HGlyg9xzBGa4eCS7b3ZiJIn1scvr3A8 IkYisTIXQT3i5MlJT3rVotEblb1boI0= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-206-3UIqaapNMnq8N_h1RCBVcQ-1; Mon, 21 Nov 2022 07:48:47 -0500 X-MC-Unique: 3UIqaapNMnq8N_h1RCBVcQ-1 Received: by mail-wm1-f69.google.com with SMTP id l42-20020a05600c1d2a00b003cf8e70c1ecso9235718wms.4 for ; Mon, 21 Nov 2022 04:48:47 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=aHf92GqKpS09QwwfFT9qcxPp2ZW8/6FXVgc85jLdYtQ=; b=e1Izr+5x36H/yB0W/fWdOhFHnE43AkyTkxFXDTfCpRddv/hNE7RxLgkdUCmsD5Maka yyDZ66Muh4oANgFe6zFMaV6hzIVdJyarQL1EMFyud+JEuvCG+ZtPjC9GiUtlvMb20kZ1 Sbp16fqe9nWA3AGgWG4yGTrSQ3jjnv+KZcnJ8NDwdOh4b2U9Fe+0h+CV1qT5HOwbtUhh OJwbXGmHM6p026hHUyUGKu3ExBAlrmN/vlr8XiXxRucoDJQQh63EVPeOZntaejBmoMqN 2l1w26tKKy9hFeONeLYLaDs/t4K4A6mL+rU8INXzmL0fUGgTYRwIRu13kOTxBU1ADJXL F+vg== X-Gm-Message-State: ANoB5pmeDwFu2DzVdpcdqgs3y/FNpZMPvkoEq4EEuabpwNT+SyUdoei6 Fz5nbgrdw8LdgVcmnqNkVcz/os3BcJk5XU0nZnths5s0wG+BgWnCHb0cP1JVIE0mBAihYCGTsUV 5OPW/6ccMiqY= X-Received: by 2002:adf:e2c9:0:b0:241:db86:176d with SMTP id d9-20020adfe2c9000000b00241db86176dmr1463201wrj.40.1669034926684; Mon, 21 Nov 2022 04:48:46 -0800 (PST) X-Google-Smtp-Source: AA0mqf4P9jvmww0P1quzMMscjBvUsyD5TxdE1CgpVjmHjZzvQrrZef/mUpNWvrKeTlgogAZ2QpjMAA== X-Received: by 2002:adf:e2c9:0:b0:241:db86:176d with SMTP id d9-20020adfe2c9000000b00241db86176dmr1463185wrj.40.1669034926351; Mon, 21 Nov 2022 04:48:46 -0800 (PST) Received: from ?IPV6:2003:cb:c702:dc00:2571:c3c2:c6ea:84ef? (p200300cbc702dc002571c3c2c6ea84ef.dip0.t-ipconnect.de. [2003:cb:c702:dc00:2571:c3c2:c6ea:84ef]) by smtp.gmail.com with ESMTPSA id q2-20020adffec2000000b00241d544c9b1sm3880875wrs.90.2022.11.21.04.48.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 21 Nov 2022 04:48:45 -0800 (PST) Message-ID: <208d4106-97e9-79b7-4077-788cdafa1b16@redhat.com> Date: Mon, 21 Nov 2022 13:48:45 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH -next] mm/hugetlb: stop using 0 as NULL pointer To: Yang Li , mike.kravetz@oracle.com Cc: songmuchun@bytedance.com, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Abaci Robot References: <20221121102037.75307-1-yang.lee@linux.alibaba.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20221121102037.75307-1-yang.lee@linux.alibaba.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1669034930; a=rsa-sha256; cv=none; b=JkdkiZwLJxS6JXEAga8OW/OOo790CUI5pBbPjq6sDbg34wVNELF5fOFVMdvzge69J90L8X 398xKfg5h9WdInX4lfE/18ZshZc1ojyVc+Pdw3Es2uxgw0MupVKpN4hsSpX9D/Po11rsHN PZv4z9uo37r7wQEQXW+Yp68DeBvRml8= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=cNaFqOLn; spf=pass (imf03.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1669034930; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=aHf92GqKpS09QwwfFT9qcxPp2ZW8/6FXVgc85jLdYtQ=; b=7CLTvLknb8DLd3EF0vTafHTht+R5OptmX07BaZ9cnEgVBXpJ2Q+HGhIfX4xFcSkr7UE8mY ODOik/d9L4ZhLBgMPibyMzndElnjt8t9VNhCIW7q0oOoGsa9Seo2wEDcBSuE4wrFEVabIA 6efSTJq44h+pdd9I4zKDjWUjpO0MQgQ= Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=cNaFqOLn; spf=pass (imf03.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 0A5292000E X-Rspam-User: X-Stat-Signature: ai6yw89r7f93y6ro1m4pw4e6xywwxs8m X-HE-Tag: 1669034929-690905 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 21.11.22 11:20, Yang Li wrote: > mm/hugetlb.c:1531:37: warning: Using plain integer as NULL pointer > > Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3224 > Reported-by: Abaci Robot > Signed-off-by: Yang Li > --- > mm/hugetlb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/hugetlb.c b/mm/hugetlb.c > index 222937d512c4..b6c2fc882f21 100644 > --- a/mm/hugetlb.c > +++ b/mm/hugetlb.c > @@ -1528,7 +1528,7 @@ static void add_hugetlb_folio(struct hstate *h, struct folio *folio, > } > > folio_set_compound_dtor(folio, HUGETLB_PAGE_DTOR); > - folio_change_private(folio, 0); > + folio_change_private(folio, NULL); > /* > * We have to set HPageVmemmapOptimized again as above > * folio_change_private(folio, 0) cleared it. Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb