linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: David Hildenbrand <david@redhat.com>
To: Yang Li <yang.lee@linux.alibaba.com>, mike.kravetz@oracle.com
Cc: songmuchun@bytedance.com, akpm@linux-foundation.org,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH -next] mm/hugetlb: stop using 0 as NULL pointer
Date: Mon, 21 Nov 2022 13:48:45 +0100	[thread overview]
Message-ID: <208d4106-97e9-79b7-4077-788cdafa1b16@redhat.com> (raw)
In-Reply-To: <20221121102037.75307-1-yang.lee@linux.alibaba.com>

On 21.11.22 11:20, Yang Li wrote:
> mm/hugetlb.c:1531:37: warning: Using plain integer as NULL pointer
> 
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3224
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
>   mm/hugetlb.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/hugetlb.c b/mm/hugetlb.c
> index 222937d512c4..b6c2fc882f21 100644
> --- a/mm/hugetlb.c
> +++ b/mm/hugetlb.c
> @@ -1528,7 +1528,7 @@ static void add_hugetlb_folio(struct hstate *h, struct folio *folio,
>   	}
>   
>   	folio_set_compound_dtor(folio, HUGETLB_PAGE_DTOR);
> -	folio_change_private(folio, 0);
> +	folio_change_private(folio, NULL);
>   	/*
>   	 * We have to set HPageVmemmapOptimized again as above
>   	 * folio_change_private(folio, 0) cleared it.

Reviewed-by: David Hildenbrand <david@redhat.com>

-- 
Thanks,

David / dhildenb



      reply	other threads:[~2022-11-21 12:48 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-21 10:20 Yang Li
2022-11-21 12:48 ` David Hildenbrand [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=208d4106-97e9-79b7-4077-788cdafa1b16@redhat.com \
    --to=david@redhat.com \
    --cc=abaci@linux.alibaba.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mike.kravetz@oracle.com \
    --cc=songmuchun@bytedance.com \
    --cc=yang.lee@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox