From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20CB0C43461 for ; Tue, 15 Sep 2020 01:05:18 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9C4CE20897 for ; Tue, 15 Sep 2020 01:05:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="omD2/Cik" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9C4CE20897 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D40CE900008; Mon, 14 Sep 2020 21:05:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CF0D38E0001; Mon, 14 Sep 2020 21:05:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BEDCA900008; Mon, 14 Sep 2020 21:05:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0052.hostedemail.com [216.40.44.52]) by kanga.kvack.org (Postfix) with ESMTP id A8EF28E0001 for ; Mon, 14 Sep 2020 21:05:16 -0400 (EDT) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 6BE66181AEF1A for ; Tue, 15 Sep 2020 01:05:16 +0000 (UTC) X-FDA: 77263502232.18.dust19_170464e2710d Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin18.hostedemail.com (Postfix) with ESMTP id 3F453100EC683 for ; Tue, 15 Sep 2020 01:05:16 +0000 (UTC) X-HE-Tag: dust19_170464e2710d X-Filterd-Recvd-Size: 3785 Received: from hqnvemgate24.nvidia.com (hqnvemgate24.nvidia.com [216.228.121.143]) by imf14.hostedemail.com (Postfix) with ESMTP for ; Tue, 15 Sep 2020 01:05:15 +0000 (UTC) Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate24.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Mon, 14 Sep 2020 18:02:54 -0700 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Mon, 14 Sep 2020 18:05:14 -0700 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Mon, 14 Sep 2020 18:05:14 -0700 Received: from nvdebian.localnet (10.124.1.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Tue, 15 Sep 2020 01:05:12 +0000 From: Alistair Popple To: CC: Jason Gunthorpe , Jonathan Corbet , "Ralph Campbell" , , , =?ISO-8859-1?Q?J=E9r=F4me?= Glisse , Andrew Morton Subject: Re: [PATCH] mm/doc: add usage description for migrate_vma_*() Date: Tue, 15 Sep 2020 11:05:10 +1000 Message-ID: <2077765.OaWJzLOgzI@nvdebian> In-Reply-To: <20200910172514.GN87483@ziepe.ca> References: <20200909212956.20104-1-rcampbell@nvidia.com> <20200910105657.6007c5ca@lwn.net> <20200910172514.GN87483@ziepe.ca> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL101.nvidia.com (172.20.187.10) To HQMAIL107.nvidia.com (172.20.187.13) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1600131774; bh=swLcarL+SErbGe4glwQXQ2j09SBuEg2MIzY+X2J3l/E=; h=X-PGP-Universal:From:To:CC:Subject:Date:Message-ID:In-Reply-To: References:MIME-Version:Content-Transfer-Encoding:Content-Type: X-Originating-IP:X-ClientProxiedBy; b=omD2/CikmXtQsewRW5Xcm6oLfynqUJws+0m9UxbArOKZ0GcmdQre2epYqgYYw8iY1 1x9LjsDoKmZRL9kIaukuFDfwbS6Km5frbBRyNf9YV0fjqIjsrcWvGFsxJ59HXFf0h1 jToV31axdAx0lqMhhQ6XL2SNOas1CrCe1MroFFMgJtg3bsZ52RlDfJCeIIiM47vvXU XGYPrk+OgKNVYE+wNkYb/3T9iUL5KFvqaQMa+GG0nBGgvDf1vwHUsOTv2m3qRv2SPM mD4H8N1RDdROB9zI0eUB4hRzp8LU86Dhmtmv/p8ECXlAsDvwmP+KNpTiEcm5Zuucsq x4VpKil5RbPIQ== X-Rspamd-Queue-Id: 3F453100EC683 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam03 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Friday, 11 September 2020 3:25:14 AM AEST Jason Gunthorpe wrote: > On Thu, Sep 10, 2020 at 10:56:57AM -0600, Jonathan Corbet wrote: > > On Wed, 9 Sep 2020 14:29:56 -0700 > > > > Ralph Campbell wrote: > > > The migrate_vma_setup(), migrate_vma_pages(), and migrate_vma_finalize() > > > API usage by device drivers is not well documented. > > > Add a description for how device drivers are expected to use it. > > > > > > Signed-off-by: Ralph Campbell > > > > > > There shouldn't be any merge conflict with my previous patch which > > > touched hmm.rst but since Jonathan Corbet took my last patch, perhaps he > > > would like to take this one through his tree too. > > > > I'm happy to take it, but it certainly needs an ack from somebody who > > understands HMM better than I do. > > Ralph wrote all the in kernel tests for this API, so I think he is > well positioned to write the documentation :) I have recently read through most of the code to get back up to date with recent HMM developments and the documentation here didn't conflict with my understanding based on the code. The description of pgmap_owner is good as it's usage wasn't immediately clear on the first code read through. So feel free to add: Reviewed-by: Alistair Popple > Jason