From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03D13C433F5 for ; Fri, 7 Oct 2022 06:47:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6B5708E0001; Fri, 7 Oct 2022 02:47:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 664386B0073; Fri, 7 Oct 2022 02:47:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4B7918E0001; Fri, 7 Oct 2022 02:47:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 3024A6B0072 for ; Fri, 7 Oct 2022 02:47:21 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id D6EBA1C6B73 for ; Fri, 7 Oct 2022 06:47:20 +0000 (UTC) X-FDA: 79993221840.23.F292004 Received: from mx0a-00082601.pphosted.com (mx0a-00082601.pphosted.com [67.231.145.42]) by imf22.hostedemail.com (Postfix) with ESMTP id 48106C001B for ; Fri, 7 Oct 2022 06:47:20 +0000 (UTC) Received: from pps.filterd (m0044010.ppops.net [127.0.0.1]) by mx0a-00082601.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 296NpEVr010640; Thu, 6 Oct 2022 23:46:52 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fb.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-id : content-transfer-encoding : mime-version; s=facebook; bh=xdSGJHcBX8Ya5nJFQXD8Zl9BCYW9mw+93GQFJJjr790=; b=Ddzz4wNd62Gc7GOwdhaYH1Fhe5S8yZbP9kBiois1bSPp5u8REndQLJLS9TTGT1AKTn7+ 08S9mL8+Vo+XmGmAqGZaiieaz8oX/vGPjOW302H/e3cHtKlzICfMsGqrdSdPedIoqWMS oiRR44qOTMR0jRjyTcPWXCWIgsvgeWADwZY= Received: from nam12-dm6-obe.outbound.protection.outlook.com (mail-dm6nam12lp2175.outbound.protection.outlook.com [104.47.59.175]) by mx0a-00082601.pphosted.com (PPS) with ESMTPS id 3k1mng1g8n-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 06 Oct 2022 23:46:52 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EaWiQqvASWsFdsv1LU6RUUyrx1URf3Sevlp7D9/cDCnbRNTsxV2ihEP9bitCi+Cw67FE7qVLMaOIKOnQNQMuBvLaRB2LBTlcHKNAMCiOv06k4jhmaiAHO+FkhsiTJLHocayKFEYWAgqssV3yI4mcwPCF+hzoaC+ySKa6RfPlpWRFxkFYORKHgC0efsxFQJm31fNX3FTuSOPWo6SjHeKKHVwHZTYR6UiM7gZdFfyoN+/3D+BT/5u9BpsliIWCIjXl3OlpUr8kEkhA1tUCNBTKpsjRIdJRGKbH9SzxITYgrm7RgO1UZ+H1Ebk6hy2882sd2oIDoZ3FN9qp47zbc0ITPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xdSGJHcBX8Ya5nJFQXD8Zl9BCYW9mw+93GQFJJjr790=; b=PVhlVCtCSPXUfJaEBVHHpKw+EnD4TAAKCUus3COXmu7edWlEqkyF/4D1Q5bBsNUtEsdVNKYokBvt9JTFghWJdv3j955QqqEot0oUNMVOEPGAIF3/klQEqQY5izRL1Dw/qzSZTzgetp9z0CNqaHhwPv6Wn/rBw5Ef1616oiVOoiw8/VoD+o6rbB9Zf0lCp9+xPhNAXrX2x3offjbGvqg+/ywFW6VW9A/DDwWiu2tjvx6cUIoNAcWlyeZDbTEa2IcVQVLLr7U0GpBCXLZOXFycjNiK83gctAIWSBqBTv+b9ir86RgTz0+G2NxQqJVXWV0TbtJ//WX5N4vEZaxH33wlxw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=fb.com; dmarc=pass action=none header.from=fb.com; dkim=pass header.d=fb.com; arc=none Received: from SA1PR15MB5109.namprd15.prod.outlook.com (2603:10b6:806:1dc::10) by DM6PR15MB3020.namprd15.prod.outlook.com (2603:10b6:5:140::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.32; Fri, 7 Oct 2022 06:46:49 +0000 Received: from SA1PR15MB5109.namprd15.prod.outlook.com ([fe80::d70d:8cce:bb1:e537]) by SA1PR15MB5109.namprd15.prod.outlook.com ([fe80::d70d:8cce:bb1:e537%7]) with mapi id 15.20.5676.028; Fri, 7 Oct 2022 06:46:49 +0000 From: Song Liu To: Luis Chamberlain CC: Song Liu , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , "akpm@linux-foundation.org" , "x86@kernel.org" , "peterz@infradead.org" , "hch@lst.de" , Kernel Team , "rick.p.edgecombe@intel.com" , "dave.hansen@intel.com" Subject: Re: [RFC 3/5] modules, x86: use vmalloc_exec for module core Thread-Topic: [RFC 3/5] modules, x86: use vmalloc_exec for module core Thread-Index: AQHYs1V2zJdM19sU5USbQ1Rz1fxRya4CUs0AgAB3rQA= Date: Fri, 7 Oct 2022 06:46:49 +0000 Message-ID: <2063847A-42D6-4A26-992F-0DD32A5E1F05@fb.com> References: <20220818224218.2399791-1-song@kernel.org> <20220818224218.2399791-4-song@kernel.org> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SA1PR15MB5109:EE_|DM6PR15MB3020:EE_ x-ms-office365-filtering-correlation-id: c4cb2da9-296b-4c87-4a4e-08daa82fb5ce x-fb-source: Internal x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: l9gyKbiVVkrDgAyrIiMQu3/STFN2vFAyVnwb0z1OLuoSvxirhajuM5Fe0Jt+CUmwfEIZxQIF1FwkTJZvGa7RifwV+VnLmGsGRgODJiPDYnxdqSDlez85x2I17RSPHIBYXmA6h5WlAEvRbN+bfsjr7g325M843SKaS8vOZHhCAJNp5zIQwlVA4ubhv8JQQn7ODUrIRUTRoCGelbTqAIkfL50oMtbpYc5IH3fBwxuj/9sZRlE71y0TXHok7pg/P7WrhTnnwQL8d3Fjr54AsRz1jhLQdlfw/M42K9n+xLGn6dZKoku0RmSYM99ezzgHDu1fKcisOxNeX6UAsyUgCbJX3JBc31u7l73ludWXgAZYarCKwZQeqqdMjd54W4PDlBBpwodR5iL4Ta+250f5XPGoaFTCVbYyhRyERZ29BbnXwj3WqCZ3dRoO9Z3Vpo7Tj3fmkbIDMZi/4gL7HAWSJo0RrtNYLJ6uKZBsXqZsuDQCjbvzs9ze4L/4pXaa2r4Vp/0MGNtVldMtTl2iqxeZObTOMVr8jc48ltF6tgPLO01gBz9pMayu3pvdkUGeuczaifRj0JFhPASMzQDmRVh4LtcMjRdHupZFdFLgkeYYIhjCh7wVuwjzaJBqJofnmSH2SNfzfu0XRerr5JTphBLwR35OeKeEmoqSq6OXJ8oMndmJPvSZWG7G5W2KyiGVtDbnCAlw/aCn9Z/2CpW7N6ExAgg3fBLY8JQoqhWIod9Wj/wu4+m5YAw2oPIyxZoWUxo59NNu8axm6QMbFDaFkR2Z6ZDffdZ/8c2UjAl7q0AW54iXcNc= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SA1PR15MB5109.namprd15.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(366004)(136003)(346002)(39860400002)(396003)(451199015)(86362001)(6486002)(186003)(316002)(54906003)(71200400001)(478600001)(6916009)(2906002)(4326008)(66446008)(66556008)(66946007)(76116006)(64756008)(66476007)(8676002)(41300700001)(91956017)(53546011)(6506007)(5660300002)(6512007)(8936002)(38100700002)(4744005)(83380400001)(122000001)(36756003)(38070700005)(33656002)(2616005)(7416002)(45980500001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?jN0+mEkxACYadB6MXiro4zeJyjrdmvs4WSRs288Epjngo41bEYPO2DN6U7dz?= =?us-ascii?Q?iDeL9p6wCngy/CnetjQPmOKzTAjA7tCA99w1gCHI3Q7sSrWLCWSAVbKjBa/l?= =?us-ascii?Q?BXdnhYWKhT+jNZx26h1bPHAp9LCQ04vGLLKStkVjjFOnhm+/r6Am3mZEyG/t?= =?us-ascii?Q?ywqgYqrDqxMcxYsAMI1xfvZF1ufuTH/ALPop9Wr/1ZW9E0o7YZbx5y7HmrD0?= =?us-ascii?Q?ckF/gcv1IgTpzuOcyb268NLIzo++R9LTvY66O/zarJ8iwvfFHia05zWCTCnC?= =?us-ascii?Q?5gYZr0nFlhyEqQnuJwUUOyYvB3DUJfpi9yRxSiufSxC+stTN1I/a4bC2/PTL?= =?us-ascii?Q?kfO9WkrVFPMc9TFIv3IgqHwXlQyqRLsAiXpvoZbum5e6+Xd/aXDtdv6Gci+3?= =?us-ascii?Q?Yy6/zowLgtxopIV9Y6mXUrOqFKhpDeDPvFLKYKlX/0E9kpVIusCG7xPqEzk9?= =?us-ascii?Q?UEqW+37pu3El2jndPrj1haJXQEJqAe/sdffhsyRumxwv2cTZxBeUB9csNyei?= =?us-ascii?Q?y8luDTgN9RbcTRPMYTngJBi9YY4REoql/8wFWLd7hwC3XbAAv0gVPGBHL9yz?= =?us-ascii?Q?5CGQtHi9Iz1UG13pBQ1qPXEUmKRwY/xXcRj63nUqKnyulgjbhvdE6kAZD3q+?= =?us-ascii?Q?l8qUHlDI90fm64q6o02mlq6K8FmGWYG7XpWz2SY20+71RW+Lng+ZpS7NaU7n?= =?us-ascii?Q?dDs1ksL0a+60ZCgL0e7EHlf+XOP4H98Gc2MklWQ+Hfzx8Lev6Q+Rgr24FbKx?= =?us-ascii?Q?zV07IzsF5ncZzsqbPBPzitP6WHXPrj4vy+aEGfRdoKqU61YgZuji9Hxrp4qr?= =?us-ascii?Q?eB/I2NrHiVffxgx8FwTYLjhz2ArfSRSrCfSscRnvlp7hw9JTgxQtzkDflyaz?= =?us-ascii?Q?7ufdizoatQkhCEeqPoqbkg+Js9jClDf45ud3/889/YGz5dRN3Qfb3k4dnVqD?= =?us-ascii?Q?xJAxDwOnwfwOU4j0cIleTK0q/DOpc2Hj07pdVXfXPCuQwS8wKIUqumr546ps?= =?us-ascii?Q?6CsNTW6ZME+gls8tzAxpQkWDA+xH+Fv+4KrJ0gVi1+VfOIfJngixf7JyLvkV?= =?us-ascii?Q?BLwd8tLArWqZxp1dLj86UQ3rDXBF8/XLhkAEd8Pcgn8VbJxVMLpNlQBPhLHG?= =?us-ascii?Q?NHsXzy7Aoh1UXUB1vfC8DveR0MpvM+ysVrWJSTCL+eJJCZ0QH4aAbPDOnA2u?= =?us-ascii?Q?nkwHGEEX7IIEzaIUzCq2DIlQ/bs4cUe1sNHN2GFqwaoarQFkv5Knzsqyqnxc?= =?us-ascii?Q?QgOddGr4YrWRtrfhZ5TuNHAHHtHEhjb7aclMSrX5lCLbOcGjoHN3ce8QYaIE?= =?us-ascii?Q?ix55/DsgYoMzd0FKqAfmqo0ry2GX6c3kA7Fe2Gtuc0OmsMOk9MzxdxUl8Bkr?= =?us-ascii?Q?C44YeNRx6paCyqZU/OB+KDE/QQKISCs12D6lumYxFypVcOT4lD8t8e8Q1tE/?= =?us-ascii?Q?cw63wwOVmmG1FpNQBmof83qgOTRpW+/+vgn8JlfFZNrll73QRCn8QKMOV7Dt?= =?us-ascii?Q?P0pbHPPOI5mQVl+lduiB7f5S5AiTwtRz9mH6EYof3kksLvZ1bob1QtspO1Sd?= =?us-ascii?Q?RnRdD+cFI0Xs77rR3GCLT87CaCQhXWCYFMA30W57sgDlR8zApb7Emit9jwVB?= =?us-ascii?Q?kOFf+1LkP5vnC8RodTjQGpM=3D?= Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: fb.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SA1PR15MB5109.namprd15.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c4cb2da9-296b-4c87-4a4e-08daa82fb5ce X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Oct 2022 06:46:49.2846 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: lOuRDqX3xTGyiv4syv7VviME/kb9LVSMSq0ieTGAGjacRpX2Ys6TlJWlCsmytGqekMjDRlWayrTCQmKeUnVyKQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR15MB3020 X-Proofpoint-ORIG-GUID: _0Sp6M-JCXVtx3TCmDYqRLHcLvy6Ha8j X-Proofpoint-GUID: _0Sp6M-JCXVtx3TCmDYqRLHcLvy6Ha8j X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1 definitions=2022-10-06_05,2022-10-06_02,2022-06-22_01 ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1665125240; a=rsa-sha256; cv=pass; b=rDrtPg/SnSN8RlSDQjhumAHRo/hNyh9pDlwrnv0K6gprFpSe5lwnUHrHE6CCQTgwdX9GYS U4r+xLmZ5EnNCce7Klh41TYaOFUr3zAh7SgT269NoY8wzuVuA7Mmt6yzVAQNsBe/R89D0s RRCGhMZ2xfpwKzT0gHcP58xMcEdZokI= ARC-Authentication-Results: i=2; imf22.hostedemail.com; dkim=pass header.d=fb.com header.s=facebook header.b=Ddzz4wNd; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (imf22.hostedemail.com: domain of "prvs=1279faf8c2=songliubraving@fb.com" designates 67.231.145.42 as permitted sender) smtp.mailfrom="prvs=1279faf8c2=songliubraving@fb.com"; dmarc=pass (policy=reject) header.from=fb.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1665125240; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xdSGJHcBX8Ya5nJFQXD8Zl9BCYW9mw+93GQFJJjr790=; b=wGRNXhx33bnKtNSw8A+QkXH7vQzSaKpA7eIAKTfvkuiWssjNLS/Q8+lTB6V4x0naRFm/9J CsG/yZ0QNULA7SZXm/PIhZFZNn/UEfAcf9OJ25idB2gp5h9W7skcU3wIpWrShC19uTuAUu jQAAESn3US2EHl0ij3tfTwLLuQh9ewU= X-Rspam-User: Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=fb.com header.s=facebook header.b=Ddzz4wNd; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (imf22.hostedemail.com: domain of "prvs=1279faf8c2=songliubraving@fb.com" designates 67.231.145.42 as permitted sender) smtp.mailfrom="prvs=1279faf8c2=songliubraving@fb.com"; dmarc=pass (policy=reject) header.from=fb.com X-Stat-Signature: cdjko1cwokbys6dri5gj6i9ja8bg85yg X-Rspamd-Queue-Id: 48106C001B X-Rspamd-Server: rspam01 X-HE-Tag: 1665125240-965236 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > On Oct 6, 2022, at 4:38 PM, Luis Chamberlain wrote: >=20 > On Thu, Aug 18, 2022 at 03:42:16PM -0700, Song Liu wrote: >> diff --git a/arch/x86/kernel/module.c b/arch/x86/kernel/module.c >> index 100446ffdc1d..570af623e28f 100644 >> --- a/arch/x86/kernel/module.c >> +++ b/arch/x86/kernel/module.c >> @@ -229,6 +229,7 @@ int apply_relocate_add(Elf64_Shdr *sechdrs, >> bool early =3D me->state =3D=3D MODULE_STATE_UNFORMED; >> void *(*write)(void *, const void *, size_t) =3D memcpy; >>=20 >> + early =3D false; >> if (!early) { >> write =3D text_poke; >> mutex_lock(&text_mutex); >=20 > As per 88fc078a7a8f6 ("x86/module: Use text_poke() for late > relocations") I'm curious why we have to take the live patching > path now all the time? Since vmalloc_exec returns read-only memory, we need text_poke() for any operation to it.=20 Does this answer your question? Song