From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B009CC67871 for ; Tue, 25 Oct 2022 03:07:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4AE1380008; Mon, 24 Oct 2022 23:07:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 45E3680007; Mon, 24 Oct 2022 23:07:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 34D4880008; Mon, 24 Oct 2022 23:07:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 2574C80007 for ; Mon, 24 Oct 2022 23:07:56 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id EC8D01C6465 for ; Tue, 25 Oct 2022 03:07:55 +0000 (UTC) X-FDA: 80057987310.22.42C43FB Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by imf24.hostedemail.com (Postfix) with ESMTP id E5D1D18003C for ; Tue, 25 Oct 2022 03:07:54 +0000 (UTC) Received: from canpemm500002.china.huawei.com (unknown [172.30.72.55]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4MxH1P3GJdzHvDd; Tue, 25 Oct 2022 11:07:37 +0800 (CST) Received: from [10.174.151.185] (10.174.151.185) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 25 Oct 2022 11:07:48 +0800 Subject: Re: [PATCH v2] mm: memory-failure: make action_result() return int To: Kefeng Wang CC: , , Naoya Horiguchi , Andrew Morton References: <20221021084611.53765-3-wangkefeng.wang@huawei.com> <20221024035138.99119-1-wangkefeng.wang@huawei.com> From: Miaohe Lin Message-ID: <2045a25b-368b-1590-a787-fc802a7a8eb4@huawei.com> Date: Tue, 25 Oct 2022 11:07:48 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20221024035138.99119-1-wangkefeng.wang@huawei.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.151.185] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To canpemm500002.china.huawei.com (7.192.104.244) X-CFilter-Loop: Reflected ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1666667275; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XUu8CP2+iLuHmWm1FYA4sc4nNObM8u/pH7m3Utksq7k=; b=cbJWNDAKyGgbUYX3F9FCg6vFHI1qGGQMwB2R5Z3PsMIjvDhfrrn7ScQn/VZlCUpRBzN2oh iQm/2N+NNejtcaomYLLAo/uvNPjkpDCuXAAdfX3s+Y38JRpBZp/+k9JjD47ntw+l9WF4sA F1sCunYgUGnQ3tviTeSQLDjyx14bkVY= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf24.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1666667275; a=rsa-sha256; cv=none; b=7g3FbSakz2d8BniAerzVlg5rSEMjhODlnKQbMKaDU6rLm65NDIp/YSh87B4pjyn6EO9bOt De9WlwV3/hr2DQ/WzexHtEhmXELjf9OgLwJGB/7FWuPFNH7WeVP7ADjWVzs8Q9onYfGvyb PItDNZwHM2c1x+4IC1jWgkPvpHb+MtM= X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: E5D1D18003C X-Rspam-User: Authentication-Results: imf24.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf24.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com X-Stat-Signature: qw66fjjrctxf9sc6pe9ewj9iswskthqo X-HE-Tag: 1666667274-716412 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022/10/24 11:51, Kefeng Wang wrote: > Check mf_result in action_result(), only return 0 when > MF_RECOVERED/MF_DELAYED, or return -EBUSY, which will > simplify code a bit. > > Signed-off-by: Kefeng Wang Thanks for cleanup. This really makes code cleaner. Reviewed-by: Miaohe Lin Thanks, Miaohe Lin