From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77463C369A2 for ; Wed, 9 Apr 2025 11:52:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F39A96B0192; Wed, 9 Apr 2025 07:52:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EE899280056; Wed, 9 Apr 2025 07:52:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D622B280053; Wed, 9 Apr 2025 07:52:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id B3DAE6B0192 for ; Wed, 9 Apr 2025 07:52:34 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 698DD1403AA for ; Wed, 9 Apr 2025 11:52:36 +0000 (UTC) X-FDA: 83314343112.17.A852D49 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf14.hostedemail.com (Postfix) with ESMTP id AC133100008 for ; Wed, 9 Apr 2025 11:52:33 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="ShdNNQa/"; spf=pass (imf14.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744199553; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZlAh5BF+/VKy4R6pJBU59qZDQS0XAI1pwtnPwkboZ94=; b=qM+03Eqca3V2qOJY1YLSA/NmcSE+1xN8vxDyIWELAfQoOhNOc+D5RdjRfaKFExoJnfVlqM LkPG4McKPpgvipXUDKLvrjyU+odmHtdIUnsD8b2PiNuP1/TILBblWANSLp1rE3O9YrtRcX q74MF8DO4ePq1GfhDWgRcucBXTlRyB0= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="ShdNNQa/"; spf=pass (imf14.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744199553; a=rsa-sha256; cv=none; b=dtiaqvzonuuTeweb62pN66jjInyOFFc+Ir5ftRWQ/gyFesFYOIx1QE7OqVTBGUpHQcRzH0 cmuVjVUs2P2nMY9wsMy7K9fKXc+QRvHODOsuiJ0auXyIdNSEojPUdVlMfI9nUTOxkM9OSl Y8U9wUJEbXdmg1ngASJ5f92VDwM8VUo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1744199553; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ZlAh5BF+/VKy4R6pJBU59qZDQS0XAI1pwtnPwkboZ94=; b=ShdNNQa/ijGf13vCfDx6GYcw5kQ+hiEqTpWuYLKXkgH7BY3wq9eKJ5VprPtBm/Yh2E+bPZ 25qv0n7C3dymoLLpz2hclagONixK8Q+Nwk3uU7+q7zuZ2w+CsLqPLJiVoELt7Ed9N+tQV8 VyaOSFtTr+ricRNrX+tVgCJhRfUVsXg= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-543-7HgMpfZkMziormG4_grfyg-1; Wed, 09 Apr 2025 07:52:31 -0400 X-MC-Unique: 7HgMpfZkMziormG4_grfyg-1 X-Mimecast-MFC-AGG-ID: 7HgMpfZkMziormG4_grfyg_1744199550 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-43cf5196c25so38878995e9.0 for ; Wed, 09 Apr 2025 04:52:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744199550; x=1744804350; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=ZlAh5BF+/VKy4R6pJBU59qZDQS0XAI1pwtnPwkboZ94=; b=st/nGZhJJCmcbY8YR0J2ag+fhscrKqNqneskj0tN3pQZEsOxk9tbiUISqbCn962llX FyDKkrK5T4CsIdxnX1pZus8GIux9OiNuxUI6atWdmY+PFuMd42eRxCtVIpXYtszGz7Dd olYn3n+OmGI5Ia8zb+6riwhxPqZY5b5dozohAR9g0Men7zs2lvOFP4kK+BLQxseXhjFv VhYp0cxJNdTVvuA5qhN/SX5PuCJ/Y9nAqHx0zOpjKTZ5iYJlGVFvQu91Elc2gpA4DhUG +7h82MIPMr77WACCkQ8JQ+dCRUhvM1QIutTMCYKuhO9GE/c9VwQzxYun9F5ZX8l2H55h /p/g== X-Forwarded-Encrypted: i=1; AJvYcCVMH39XZvD5EhOHphiAoHJ+EE8K6B1MBc1ykEYAq6s3TL5YQuV5c8E+3fysY8M9RHQireVCrXAAcw==@kvack.org X-Gm-Message-State: AOJu0YwUjRxU5ZTQfPnx8F6jw/n/mhjQxN/c2tU/hyP/u/VR7B5IuBK/ F7QauimUPDm+PRy2buRB1g212UOL/beZHRQ8iIBziPTLFo+eufjg02Pjan45YCR7AJDmMRjhFYt 61XPeZWK/pZA8Qx7OrmOlHSNwhw6bEIcnO/HOKnUkqxvHszpB X-Gm-Gg: ASbGncszibgmPQs9gDT1dHcR281ZPu+sf38MVJZ5+a54gVJcbGQPtltRGaRD0rUgeiU lN28pRNln1XsVKdT7D016zZBJODgJa21UC3a0ZMuJs4lCB+CsxTRPMwPT73DeQ+fE7whuWxTcwf sGBGcxbstV8Zxu7CDJ+g4rUfhJR1iYs5ggoMYeeW8koePaaFJV6OuLiaNBqlxGLoEkz5Z09Jntm B7qbcMijItn40bipbDYHRvaMBLAZa6O7fQexd/MtZtNRx10K9QmvvFNFG8GgeYnVVfLljw3mmsO AaPSoUsSw0fcAEGYllehSLzeg2WjcYQfagfvgYsgLQ== X-Received: by 2002:a05:600c:1d8a:b0:43c:f050:fed3 with SMTP id 5b1f17b1804b1-43f1eca819cmr27432955e9.11.1744199550428; Wed, 09 Apr 2025 04:52:30 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGXhzHj+xMdvlRohVTa4JmpL3IBWUzjbyb6iOg/HTDb5KSd2qF22C/o+XaXrMaZB8WmHtER/Q== X-Received: by 2002:a05:600c:1d8a:b0:43c:f050:fed3 with SMTP id 5b1f17b1804b1-43f1eca819cmr27432735e9.11.1744199550088; Wed, 09 Apr 2025 04:52:30 -0700 (PDT) Received: from [192.168.3.141] (p4ff23667.dip0.t-ipconnect.de. [79.242.54.103]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43f233a2c46sm13881765e9.13.2025.04.09.04.52.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 09 Apr 2025 04:52:29 -0700 (PDT) Message-ID: <203ed4e9-4691-483c-bf42-3035b3ad3539@redhat.com> Date: Wed, 9 Apr 2025 13:52:28 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 3/3] mm/mempolicy: Support memory hotplug in weighted interleave To: Honggyu Kim , Rakie Kim , akpm@linux-foundation.org Cc: kernel_team@skhynix.com, gourry@gourry.net, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-cxl@vger.kernel.org, joshua.hahnjy@gmail.com, dan.j.williams@intel.com, ying.huang@linux.alibaba.com, Jonathan.Cameron@huawei.com, osalvador@suse.de, yunjeong.mun@sk.com References: <20250408073243.488-1-rakie.kim@sk.com> <20250408073243.488-4-rakie.kim@sk.com> <19562f7e-38ce-41fc-8dfc-bfd6b1259291@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 9xNwimKsotlOEQu6e38JjsJQ0I5gNYt6MuO1-94GONI_1744199550 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: AC133100008 X-Stat-Signature: mrek7ys4gqzqyemn76o8efbmrbbxw65o X-HE-Tag: 1744199553-462878 X-HE-Meta: U2FsdGVkX1+dfyg6ma/c/R8QCYRbjdL3Cx/j2zA/8V11hIeqCZnasFYRe3YZ6RdB6IWJCHBB828wTV/CLnhjLcLKiB7HUsKNjIVRRXKyjuM895GxJZC0nYt2KOqPddD6A1tpFbLJYXnoPmBgE/rpw8xoN53UhXYcV9RdrGSeObHxVCKOdUiBrus5yf1Y05hdFT03PIRUVmVjykIU7R7/x5qpRvKt9encbEjYNAvEpUtxctcuDsAif6mxmURghEuorjchew3fvj5HIsWGHezrrEJzlhFVuLHePMJ9sfwZjSa5LezIAxa3VQFhyXK0GvqoODRBYrcyYi1NEH1e9nv1NKjaPYi7gdIIQxDgZsli+OX0+jX+CPAQ6r5Mbbv/XjzHwHaR2jqPPAJF7AaJ0muoo6YQZYU0DOJcATHHeo3F8DnehxftCTmXY6/MDbavbbGMW4UnQWPKubDJTVPBdp/C5jKJD2v4sDiAFI+SJ73uVGuyFxYmB2FkeDu0LQEre7GOy3tehxC93Ag0JVb7vGgGGcitWf+YVoDnlik+GuN4L5EQ8ekAM7RyQVPdzIiSnbVVwF0EypNJttTA0yYhNkLiwGfJ7jjctR4j6x2M9SNHCnqCcWjCDGzK4p1JyqsMw4hZoiZZE1wX7EwTq0ermCT70JPzIULMKAI24FlisAem88FsLDo0WGwXsBW6i3zKqocW9HvOgffAIXUp1jleXvwEkEUUVj5v2JdcErop+4CWGOAl2EHEAItGABWKwPJCzpyX46a2tqZiOHqeS9gJfwiKVDc9mHM59vZGrNbETjDJjwtsHPc9dyvx34zsJKrNL8ymwRdeBFeaN+IRoDsqVBlwRNIWl53ODr0FjhQefJjg8Ve6WQfaeHEsv2bFUuU7YptxhKsT7B+pRhSD7a5SWgNDCdWMZTcIKUqO8bF/sjTh6W+lhQaTA7cwkh4cvBvWJjKncHnb5pL3mcljOo+IyhV QHN0SdZR 30tVu9ewiu9ZqGCpqwlXzp/xGN4Krs+w5/Fm2nlnPiJa69A4kCfRW70dNs/w/k40HQmOJYUn5Z2mACl6XCESsWwo3d88FgcnVWhNgq0eYp6D2QJ92sFYRaa48P7BKG+rmY2grxX5dDJd4o0rXRAQB0cTet6G+UE88dIS5KD+hPuUoYHX7x+IYJtU+fOcYywfND0KAw5rijxo4vUHO/aCOazULcdUup9Vd3drWopo9gbrcn0tfZ4WmN2+OYaDQ4BV+2DQ5pOLVYkFbkeYA+c/2xExqHSQhe5o2OnYq/IWULhPOrHoXnfXWviR6b9xl29CchMa2BjmA2rJqU96QwnyLpWnJo2jEynxZ6c1AAQvYC7nw+9lkoluBIaG74/PugGuE5EWOFSqCTejFi89KaKCHYZTd6xgGiblkIXC9w0OyIGpI/wOI8VzsaI6q+pFS7+zGF+CSYHg6eYRheenD10bd2KuPpDeeVtOlcBdGFMRDFdeol1L/BYgNUBGStL1EMkDSJBDW8OuRceZFo1RepPQiO5iXJOe2wyy4/HyAD1e2yGCqb0LH1xBXtFWD8wmhhHGAxiLevwOWGIr6G0bS/vPxPBjyyA0s6P1eabe7TjWk98i9Fkc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 09.04.25 13:39, Honggyu Kim wrote: > Hi David, > > On 4/9/2025 6:05 PM, David Hildenbrand wrote: >> On 08.04.25 09:32, Rakie Kim wrote: >>> The weighted interleave policy distributes page allocations across multiple >>> NUMA nodes based on their performance weight, thereby improving memory >>> bandwidth utilization. The weight values for each node are configured >>> through sysfs. >>> >>> Previously, sysfs entries for configuring weighted interleave were created >>> for all possible nodes (N_POSSIBLE) at initialization, including nodes that >>> might not have memory. However, not all nodes in N_POSSIBLE are usable at >>> runtime, as some may remain memoryless or offline. >>> This led to sysfs entries being created for unusable nodes, causing >>> potential misconfiguration issues. >>> >>> To address this issue, this patch modifies the sysfs creation logic to: >>> 1) Limit sysfs entries to nodes that are online and have memory, avoiding >>>     the creation of sysfs entries for nodes that cannot be used. >>> 2) Support memory hotplug by dynamically adding and removing sysfs entries >>>     based on whether a node transitions into or out of the N_MEMORY state. >>> >>> Additionally, the patch ensures that sysfs attributes are properly managed >>> when nodes go offline, preventing stale or redundant entries from persisting >>> in the system. >>> >>> By making these changes, the weighted interleave policy now manages its >>> sysfs entries more efficiently, ensuring that only relevant nodes are >>> considered for interleaving, and dynamically adapting to memory hotplug >>> events. >>> >>> Signed-off-by: Rakie Kim >>> Signed-off-by: Honggyu Kim >>> Signed-off-by: Yunjeong Mun >> >> >> Why are the other SOF in there? Are there Co-developed-by missing? > > I initially found the problem and fixed it with my internal implementation but > Rakie also had his idea so he started working on it. His initial implementation > has almost been similar to mine. > > I thought Signed-off-by is a way to express the patch series contains our > contribution, but if you think it's unusual, then I can add this. Please see Documentation/process/submitting-patches.rst, and note that these are not "patch delivery" SOB. " The Signed-off-by: tag indicates that the signer was involved in the development of the patch, or that he/she was in the patch's delivery path. " and " Co-developed-by: states that the patch was co-created by multiple developers; it is used to give attribution to co-authors (in addition to the author attributed by the From: tag) when several people work on a single patch. Since Co-developed-by: denotes authorship, every Co-developed-by: must be immediately followed by a Signed-off-by: of the associated co-author. Standard sign-off procedure applies, i.e. the ordering of Signed-off-by: tags should reflect the chronological history of the patch insofar as possible, regardless of whether the author is attributed via From: or Co-developed-by:. Notably, the last Signed-off-by: must always be that of the developer submitting the patch. " The SOB order here is also not correct. > > Co-developed-by: Honggyu Kim > Signed-off-by: Honggyu Kim > > For Yunjeong, the following can be added. > > Tested-by: Yunjeong Mun That is probably the right thing to do if contribution was focused on testing. > > However, this patch series is already in Andrew's mm-new so I don't want to > bother him again unless we need to update this patches for other reasons. mm-new is exactly for these kind of things. We can ask Andrew to fix it up. -- Cheers, David / dhildenb