From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 575BCC61DA4 for ; Mon, 6 Mar 2023 01:57:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B12D06B0072; Sun, 5 Mar 2023 20:56:59 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AC3076B0073; Sun, 5 Mar 2023 20:56:59 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 989D16B0074; Sun, 5 Mar 2023 20:56:59 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 85DA16B0072 for ; Sun, 5 Mar 2023 20:56:59 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 4D497C07B5 for ; Mon, 6 Mar 2023 01:56:59 +0000 (UTC) X-FDA: 80536810158.13.8C03525 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf04.hostedemail.com (Postfix) with ESMTP id 886F940004 for ; Mon, 6 Mar 2023 01:56:54 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf04.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678067816; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=D2L9WpltjZN0ky/hHuhbKaabjeBGhVz9xUWagtqyWLI=; b=e3mJsN2Qfot8p0gWi6I/VK+tu3Ti3SL0ChNj8qKe1dv9tjHxlAqGSeBXafLnHX64FqqUVE zqvTTH7INtIaW+kTBmlZj2Xfuo6DZwza06ZtMdeYIek0IhlExWwhANm45HhaY+i+qXp3nP q4p9t6QTp8KbzSrWCgIOhSKOrbN6keY= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf04.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678067816; a=rsa-sha256; cv=none; b=xCTDQUhisu2m1L6q22GiExd5O33Jnv12JxX4ikxwODZQ4YU5s45/Zh+CArzjqdNLZHzb3Y u+21j+SBr+/Dd/eyGLgQrvqkW1z8YBYRHtfqZyYX+7hRfcReAftUnSq5N/4neanVjC/zb+ y8o6dS50VUeXZ56KYawbX47jy2Hfsms= Received: from dggpemm500001.china.huawei.com (unknown [172.30.72.57]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4PVM9x6XcjzrSKd; Mon, 6 Mar 2023 09:56:05 +0800 (CST) Received: from [10.174.177.243] (10.174.177.243) by dggpemm500001.china.huawei.com (7.185.36.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Mon, 6 Mar 2023 09:56:49 +0800 Message-ID: <202ac11d-3692-69bf-3984-627c1b9f9d38@huawei.com> Date: Mon, 6 Mar 2023 09:56:49 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH v2 2/3] mm/damon/paddr: minor refactor of damon_pa_young() Content-Language: en-US From: Kefeng Wang To: SeongJae Park CC: Andrew Morton , , , References: <20230303183925.113520-1-sj@kernel.org> <04645c9e-2188-da5c-30da-4c4694c7283c@huawei.com> In-Reply-To: <04645c9e-2188-da5c-30da-4c4694c7283c@huawei.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggpemm500001.china.huawei.com (7.185.36.107) X-CFilter-Loop: Reflected X-Rspamd-Queue-Id: 886F940004 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: 4jp5okrcuse1tjhpmfk8df4y6qgds3zr X-HE-Tag: 1678067814-779985 X-HE-Meta: U2FsdGVkX18iNGtYRpfImA0rNHQiucJcu5AfodTuYGaIRa0lprdVgU+q30uJsI0uojYZD+RpBNmM9imt3QuGU8Da8OZh28R9S3xHcOesGIMzzNsfvOJz+P/7XLU5kO79gudPaK6BJccoo9myzvGTxPluEdZdihZNl1KBedYbTfmCIaQqW1vRhs89/esJ/8LK1zakS1XB2M2fIVbgPRAIHy3VWcvgLOhRYNfiI8Tj2w75n9fLyOOtBz8c4vU0ji4c0DpWnroZiClB/l4u77zLhmcFSA9KLoq+0spyi9dBIpyMXMb0sniL0JNHWwgfEazl+KAeczNHpzES4DonxopjlGjhxiT2zpraZjVgumgO5KNqHZOnZge6pKKMfXJFiRTRlRwbL93MlX9f9mQsKae7YYqLIuz7l61qE1SexDAsYOZ/73vcljj332o7kdWwierG6+dxUF4q5VYRQhxxGaUNI/UbSSXG5N7QqJL/KMdRSki7WfBt57qkFVpwpT7QmTgf6Ymi96cDwVUZeBbMwYlZ5PxbtCQeQPT74Uvy1KLToTNXNGwDPgowzMp2ItIhhy3eQXmgxMIpZ6XqAvAJHzdDCqYNgwebmdzrkCbxo8GpTTWTnGYb/Y0NWg2an6nr+yjeYIUzZ6kusZG1DAZSYpSIO3xqo4pTxhEWS6M+PPj7rRSiYJPF4bBBtPDbmTB5foNQWYd4HvcSRE/r2tEkN0c/FA/pTSuU3KUvSbS481y+2fKAVxYeKy4s2rqGfbgMgQGrMMMh2nliCC1wuGPMqDihdM5G+SIXSIBSXjSTUn5Hlh5XTmPQol8T8ZZUvhPegGcHTEnvEgNXMPR/Gu3jq9nawMaaop9evSayH6euiQYnlh0ywv+IjhrUMT5CfKts9d3ZyahiDedZsVM0tuBSWd/Ieu+/yeYrukkGJUJ7a4BO+EcPFNxBQkD202ysvGmZYFVVe5fXrzVxvNGgClk+sDZ SaKlwUyU UDxjJmgJujbvRmZlmrR9vIbtXwsGWTiTEVlF3kxxBwY0nfSQXf0o+Pa+/a+BvHoEHK5DtPZqQV0o0e2Yqi1xJS2VkRcFMsgaHY9y9K6E+V9HKmC3GtZn7Hr4LWMI8adZTawUDI0EcucQ3ViJzQOMOx4jFvcQWdn28omnecWuOcV1zHLjadvYBA+7SErqpliQrtaAMYy0WhAmitvnSXr4sRyX/KQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000112, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023/3/6 9:10, Kefeng Wang wrote: > > > On 2023/3/4 2:39, SeongJae Park wrote: >> Hi Kefeng, >> >> On Fri, 3 Mar 2023 16:43:42 +0800 Kefeng Wang >> wrote: >> >>> Omit three lines by unified folio_put(), and make code more clear. >>> >>> Signed-off-by: Kefeng Wang >>> --- >>>   mm/damon/paddr.c | 11 ++++------- >>>   1 file changed, 4 insertions(+), 7 deletions(-) >>> >>> diff --git a/mm/damon/paddr.c b/mm/damon/paddr.c >>> index 3fda00a0f786..2ef9db0189ca 100644 >>> --- a/mm/damon/paddr.c >>> +++ b/mm/damon/paddr.c >>> @@ -130,24 +130,21 @@ static bool damon_pa_young(unsigned long paddr, >>> unsigned long *folio_sz) >>>               accessed = false; >>>           else >>>               accessed = true; >>> -        folio_put(folio); >>>           goto out; >> >> Because you moved 'out' label to not include *folio_sz setting, >> folio_sz will >> not set in this case.  It should be set. > oh, it should be fixed. >> >>>       } >>>       need_lock = !folio_test_anon(folio) || folio_test_ksm(folio); >>> -    if (need_lock && !folio_trylock(folio)) { >>> -        folio_put(folio); >>> -        return false; >>> -    } Hi SJ, apart from above issue, it looks that this branch need the folio_size() setting, right? Thanks >>> +    if (need_lock && !folio_trylock(folio)) >>> +        goto out; >>>       rmap_walk(folio, &rwc); >>>       if (need_lock) >>>           folio_unlock(folio); >>> -    folio_put(folio); >>> -out: >>>       *folio_sz = folio_size(folio); >>> +out: >>> +    folio_put(folio); >> >> Before this change, folio_size() is called after folio_put(). >> Shouldn't it be >> called before folio_put()?  If so, could we make a separate fix for >> that first, >> and then make this change on top of it, so that it can be easily >> applied to >> relevant stable kernels? >> > Yes， I could separate it, after folio_put(), the folio could be > re-allocated and the folio_size calculation is not right. >> >> Thanks, >> SJ >> >>>       return accessed; >>>   } >>> -- >>> 2.35.3 >>> >>>