From: Xiang Gao <gxxa03070307@gmail.com>
To: akpm@linux-foundation.org, vbabka@kernel.org
Cc: surenb@google.com, mhocko@suse.com, jackmanb@google.com,
hannes@cmpxchg.org, ziy@nvidia.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, Xiang Gao <gaoxiang17@xiaomi.com>
Subject: [PATCH] mm/page_alloc: fix spaces used for indentation instead of tabs
Date: Thu, 16 Apr 2026 10:19:45 +0800 [thread overview]
Message-ID: <20260416021945.682234-1-gxxa03070307@gmail.com> (raw)
From: Xiang Gao <gaoxiang17@xiaomi.com>
checkpatch.pl reports two indentation errors in page_alloc.c where
spaces are used instead of tabs:
ERROR: code indent should use tabs where possible
#887: FILE: mm/page_alloc.c:887:
+ VM_WARN_ONCE(get_pageblock_migratetype(page) != migratetype,$
ERROR: code indent should use tabs where possible
#6626: FILE: mm/page_alloc.c:6626:
+ sysctl_min_unmapped_ratio) / 100;$
In __del_page_from_free_list(), the VM_WARN_ONCE at line 887 uses 8
spaces for indentation instead of a tab. The identical VM_WARN_ONCE
calls in __add_to_free_list() and move_to_free_list() both correctly
use a tab.
In setup_min_unmapped_ratio(), the continuation line at 6626 uses 6
tabs + 9 spaces for alignment. Replace the excess spaces with 6 tabs
+ 1 space to correctly align with the opening parenthesis on the
previous line.
Signed-off-by: gaoxiang17 <gaoxiang17@xiaomi.com>
---
mm/page_alloc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index 2d4b6f1a554e..752673a9b43c 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -884,7 +884,7 @@ static inline void __del_page_from_free_list(struct page *page, struct zone *zon
{
int nr_pages = 1 << order;
- VM_WARN_ONCE(get_pageblock_migratetype(page) != migratetype,
+ VM_WARN_ONCE(get_pageblock_migratetype(page) != migratetype,
"page type is %d, passed migratetype is %d (nr=%d)\n",
get_pageblock_migratetype(page), migratetype, nr_pages);
@@ -6623,7 +6623,7 @@ static void setup_min_unmapped_ratio(void)
for_each_zone(zone)
zone->zone_pgdat->min_unmapped_pages += (zone_managed_pages(zone) *
- sysctl_min_unmapped_ratio) / 100;
+ sysctl_min_unmapped_ratio) / 100;
}
--
2.34.1
next reply other threads:[~2026-04-16 2:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-16 2:19 Xiang Gao [this message]
2026-04-16 4:22 ` Donet Tom
2026-04-16 5:19 ` 答复: [External Mail]Re: " 高翔
2026-04-16 5:27 ` [PATCH v2] " Xiang Gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260416021945.682234-1-gxxa03070307@gmail.com \
--to=gxxa03070307@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=gaoxiang17@xiaomi.com \
--cc=hannes@cmpxchg.org \
--cc=jackmanb@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=surenb@google.com \
--cc=vbabka@kernel.org \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox