From: Sang-Heon Jeon <ekffu200098@gmail.com>
To: akpm@linux-foundation.org, rppt@kernel.org, djbw@kernel.org,
mingo@kernel.org
Cc: linux-mm@kvack.org, Sang-Heon Jeon <ekffu200098@gmail.com>,
Donghyeon Lee <asd142513@gmail.com>,
Munhui Chae <mochae@student.42seoul.kr>
Subject: [RFC PATCH 1/2] mm/fake-numa: fix under-allocation detection logic in uniform split
Date: Tue, 14 Apr 2026 00:44:37 +0900 [thread overview]
Message-ID: <20260413154438.396031-2-ekffu200098@gmail.com> (raw)
In-Reply-To: <20260413154438.396031-1-ekffu200098@gmail.com>
When split NUMA node uniformly, split_nodes_size_interleave_uniform()
returns the next absolute node ID, not the number of nodes created.
The previous under-allocation detection logic compares next absolute node
ID (ret) and request count (n), which only works when nid starts at 0.
Fix under-allocation detection logic to compare the number of actually
created nodes (ret - nid) against the request count (n).
Signed-off-by: Sang-Heon Jeon <ekffu200098@gmail.com>
Reported-by: Donghyeon Lee <asd142513@gmail.com>
Reported-by: Munhui Chae <mochae@student.42seoul.kr>
Fixes: cc9aec03e58f ("x86/numa_emulation: Introduce uniform split capability") # 4.19
---
mm/numa_emulation.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/numa_emulation.c b/mm/numa_emulation.c
index 703c8fa05048..e7f856c8f2a1 100644
--- a/mm/numa_emulation.c
+++ b/mm/numa_emulation.c
@@ -416,7 +416,7 @@ void __init numa_emulation(struct numa_meminfo *numa_meminfo, int numa_dist_cnt)
n, &pi.blk[0], nid);
if (ret < 0)
break;
- if (ret < n) {
+ if (ret - nid < n) {
pr_info("%s: phys: %d only got %d of %ld nodes, failing\n",
__func__, i, ret, n);
ret = -1;
--
2.43.0
next prev parent reply other threads:[~2026-04-13 15:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-13 15:44 [RFC PATCH 0/2] " Sang-Heon Jeon
2026-04-13 15:44 ` Sang-Heon Jeon [this message]
2026-04-13 15:44 ` [RFC PATCH 2/2] mm/fake-numa: fix outdated return value comment Sang-Heon Jeon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260413154438.396031-2-ekffu200098@gmail.com \
--to=ekffu200098@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=asd142513@gmail.com \
--cc=djbw@kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@kernel.org \
--cc=mochae@student.42seoul.kr \
--cc=rppt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox