* [PATCH] mm/damon/core: disallow non-power of two min_region_sz on damon_start()
@ 2026-04-11 21:36 SeongJae Park
0 siblings, 0 replies; only message in thread
From: SeongJae Park @ 2026-04-11 21:36 UTC (permalink / raw)
To: Andrew Morton
Cc: SeongJae Park, # 6 . 18 . x, Quanmin Yan, damon, linux-kernel, linux-mm
Commit d8f867fa0825 ("mm/damon: add damon_ctx->min_sz_region")
introduced a bug that allows unaligned DAMON region address ranges.
Commit c80f46ac228b ("mm/damon/core: disallow non-power of two
min_region_sz") fixed it, but only for damon_commit_ctx() use case.
Still, DAMON sysfs interface can emit non-power of two min_region_sz via
damon_start(). Fix the path by adding the is_power_of_2() check on
damon_start().
The issue was discovered by sashiko [1].
[1] https://lore.kernel.org/20260403155530.64647-1-sj@kernel.org
Fixes: d8f867fa0825 ("mm/damon: add damon_ctx->min_sz_region")
Cc: <stable@vger.kernel.org> # 6.18.x
Signed-off-by: SeongJae Park <sj@kernel.org>
---
mm/damon/core.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/mm/damon/core.c b/mm/damon/core.c
index 3703f62a876b3..c107d74c77e74 100644
--- a/mm/damon/core.c
+++ b/mm/damon/core.c
@@ -1368,6 +1368,11 @@ int damon_start(struct damon_ctx **ctxs, int nr_ctxs, bool exclusive)
int i;
int err = 0;
+ for (i = 0; i < nr_ctxs; i++) {
+ if (!is_power_of_2(ctxs[i]->min_region_sz))
+ return -EINVAL;
+ }
+
mutex_lock(&damon_lock);
if ((exclusive && nr_running_ctxs) ||
(!exclusive && running_exclusive_ctxs)) {
base-commit: 872b6168e577ea326324255fa8b6716a89124680
--
2.47.3
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2026-04-11 21:36 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-04-11 21:36 [PATCH] mm/damon/core: disallow non-power of two min_region_sz on damon_start() SeongJae Park
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox