From: Liew Rui Yan <aethernet65535@gmail.com>
To: sj@kernel.org
Cc: aethernet65535@gmail.com, damon@lists.linux.dev, linux-mm@kvack.org
Subject: Re: (sashiko review) [PATCH v4 1/2] mm/damon/lru_sort: validate min_region_size to be power of 2
Date: Sat, 11 Apr 2026 00:46:10 +0800 [thread overview]
Message-ID: <20260410164610.6764-1-aethernet65535@gmail.com> (raw)
In-Reply-To: <20260410135500.81989-1-sj@kernel.org>
On Fri, 10 Apr 2026 06:55:00 -0700 SeongJae Park <sj@kernel.org> wrote:
> On Fri, 10 Apr 2026 17:40:04 +0800 Liew Rui Yan <aethernet65535@gmail.com> wrote:
>
> > Sashiko found some issues.
>
> Clarifying what is the following action for the sashiko finding would be
> helpful. For example, if you say "Sashiko found some issues, so I will post a
> new versiuon soon", and if I'm busy, I can save my time by saying "Ok, then I
> will skip or delaying review of this version and wait for your next review".
Okay, I will keep that in mind next time I foward a Sashiko's Review.
Thank you for you suggestion.
> [...]
>
> Agreed. This was unclear to me in previous disucssions, though. I still agree
> it is out of the scope of this patch. But now I think we need to let users
> force-restart. Adding this to my todo list.
Just to make sure - is this the same issue that my recent RFC patch [1]
aims to address? I want to make sure we're not duplicating efforts.
I'm still actively working on that patch, and I plan to send the next
version next week. I've been holding off because I didn't want to send
multiple patches in parallel.
[1] https://lore.kernel.org/20260330164347.12772-1-aethernet65535@gmail.com
Best regards,
Rui Yan
next prev parent reply other threads:[~2026-04-10 16:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-10 4:42 [PATCH v4 0/2] mm/damon: " Liew Rui Yan
2026-04-10 4:42 ` [PATCH v4 1/2] mm/damon/lru_sort: " Liew Rui Yan
2026-04-10 9:40 ` (sashiko review) " Liew Rui Yan
2026-04-10 13:55 ` SeongJae Park
2026-04-10 16:46 ` Liew Rui Yan [this message]
2026-04-10 17:00 ` SeongJae Park
2026-04-10 13:56 ` SeongJae Park
2026-04-10 4:42 ` [PATCH v4 2/2] mm/damon/reclaim: " Liew Rui Yan
2026-04-10 10:08 ` (sashiko review) " Liew Rui Yan
2026-04-10 13:44 ` SeongJae Park
2026-04-10 13:57 ` SeongJae Park
2026-04-10 14:05 ` [PATCH v4 0/2] mm/damon: " SeongJae Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260410164610.6764-1-aethernet65535@gmail.com \
--to=aethernet65535@gmail.com \
--cc=damon@lists.linux.dev \
--cc=linux-mm@kvack.org \
--cc=sj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox