From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2F68EF364AB for ; Thu, 9 Apr 2026 18:13:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 660FE6B008A; Thu, 9 Apr 2026 14:13:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 610E96B008C; Thu, 9 Apr 2026 14:13:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 48A846B0092; Thu, 9 Apr 2026 14:13:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 370DF6B008A for ; Thu, 9 Apr 2026 14:13:06 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id D044F56593 for ; Thu, 9 Apr 2026 18:13:05 +0000 (UTC) X-FDA: 84639813930.23.400D3B5 Received: from zeniv.linux.org.uk (zeniv.linux.org.uk [62.89.141.173]) by imf30.hostedemail.com (Postfix) with ESMTP id E5C8180005 for ; Thu, 9 Apr 2026 18:13:03 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=linux.org.uk header.s=zeniv-20220401 header.b=JJcsCEca; spf=none (imf30.hostedemail.com: domain of viro@ftp.linux.org.uk has no SPF policy when checking 62.89.141.173) smtp.mailfrom=viro@ftp.linux.org.uk; dmarc=pass (policy=none) header.from=zeniv.linux.org.uk ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1775758384; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BoGW7oywgvm57yYmgFIJhKPYzBfyhEW/uN+KSu6heaU=; b=gcG4Y/VtPLwh7cSbbCZm2bhkewiMxA3ayUxqn8lU2xSU03i+UdzzXB1D55rjMVzvv1ce2w lgzOVvBkBxiBucYk6o7GOiXNA9Zp94tBzIk4JqSgDRlDZgCYjmVGtIHleVqiIK1r/+eXyw ezJ+vmQhZ8f0Nd2zu34MHqX0o675ADM= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=linux.org.uk header.s=zeniv-20220401 header.b=JJcsCEca; spf=none (imf30.hostedemail.com: domain of viro@ftp.linux.org.uk has no SPF policy when checking 62.89.141.173) smtp.mailfrom=viro@ftp.linux.org.uk; dmarc=pass (policy=none) header.from=zeniv.linux.org.uk ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1775758384; a=rsa-sha256; cv=none; b=t+fM6B1qDOBd6BAMKbtkxbi92Lj7UdnPI2/nEnQAJ2J3f+RtzIMvC0I8sF0q3Hb6k/29B+ 50u843NqA9+8RaLa9khVseasDjCETNSz2Am9RHmqMlZZs3XiMGzSxMQOvUnivPvPnihGZV vvC6tP+Sx/DmbVGOS9iL8GnwcU1NUBo= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=linux.org.uk; s=zeniv-20220401; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=BoGW7oywgvm57yYmgFIJhKPYzBfyhEW/uN+KSu6heaU=; b=JJcsCEcaKqyNrvJOUZ8XOnA1AS yC//2gnLRa8FcBRiXofOYljopOoyt9r8CbkWaLEFmbUVfW5qK5utkUh3D77jxlkhKoZiYVbvdTEnm X8jEr88bUddVEJ+24e8elVa7rPEDm9C+KeO3Yi+QSp+riwZi9Be8u3P2jnyNq7RhzU24dEi9YT5JB 9o5OjQL5vQk2h32ksN+l6XHB7LZbu7YtKRAMPXU1ZH+Yata0JOXemtl88QWI3UJ7mBXR7GCgddkg5 qrhpzNPrKwHYiMCapxKfC0E4ZwUatWZBULD1y88efyo7haqTewJrOOn317SRlKBwAg9TXV76h3bsC A/eZOWQA==; Received: from viro by zeniv.linux.org.uk with local (Exim 4.99.1 #2 (Red Hat Linux)) id 1wAtvH-00000003xj6-26He; Thu, 09 Apr 2026 18:16:11 +0000 Date: Thu, 9 Apr 2026 19:16:11 +0100 From: Al Viro To: Philipp Hahn Cc: amd-gfx@lists.freedesktop.org, apparmor@lists.ubuntu.com, bpf@vger.kernel.org, ceph-devel@vger.kernel.org, cocci@inria.fr, dm-devel@lists.linux.dev, dri-devel@lists.freedesktop.org, gfs2@lists.linux.dev, intel-gfx@lists.freedesktop.org, intel-wired-lan@lists.osuosl.org, iommu@lists.linux.dev, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-block@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-cifs@vger.kernel.org, linux-clk@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org, linux-media@vger.kernel.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, linux-mtd@lists.infradead.org, linux-nfs@vger.kernel.org, linux-omap@vger.kernel.org, linux-phy@lists.infradead.org, linux-pm@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, linux-sctp@vger.kernel.org, linux-security-module@vger.kernel.org, linux-sh@vger.kernel.org, linux-sound@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-trace-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, ntfs3@lists.linux.dev, samba-technical@lists.samba.org, sched-ext@lists.linux.dev, target-devel@vger.kernel.org, tipc-discussion@lists.sourceforge.net, v9fs@lists.linux.dev, Julia Lawall , Nicolas Palix , Chris Mason , David Sterba , Ilya Dryomov , Alex Markuze , Viacheslav Dubeyko , Theodore Ts'o , Andreas Dilger , Steve French , Paulo Alcantara , Ronnie Sahlberg , Shyam Prasad N , Tom Talpey , Bharath SM , Eric Van Hensbergen , Latchesar Ionkov , Dominique Martinet , Christian Schoenebeck , Gao Xiang , Chao Yu , Yue Hu , Jeffle Xu , Sandeep Dhavale , Hongbo Li , Chunhai Guo , Miklos Szeredi , Konstantin Komarov , Andreas Gruenbacher , Kees Cook , Tony Luck , "Guilherme G. Piccoli" , Jan Kara , Phillip Lougher , Christian Brauner , Jan Kara , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Tejun Heo , David Vernet , Andrea Righi , Changwoo Min , Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Ben Segall , Mel Gorman , Valentin Schneider , Luis Chamberlain , Petr Pavlu , Daniel Gomez , Sami Tolvanen , Aaron Tomlin , Sylwester Nawrocki , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Max Filippov , Paolo Bonzini , John Johansen , Paul Moore , James Morris , "Serge E. Hallyn" , Andrew Morton , Alasdair Kergon , Mike Snitzer , Mikulas Patocka , Benjamin Marzinski , "David S. Miller" , David Ahern , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Marcel Holtmann , Johan Hedberg , Luiz Augusto von Dentz , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Stanislav Fomichev , Jamal Hadi Salim , Jiri Pirko , Marcelo Ricardo Leitner , Xin Long , Trond Myklebust , Anna Schumaker , Chuck Lever , Jeff Layton , NeilBrown , Olga Kornievskaia , Dai Ngo , Jon Maloy , Johannes Berg , Catalin Marinas , Russell King , John Crispin , Thomas Bogendoerfer , Yoshinori Sato , Rich Felker , John Paul Adrian Glaubitz , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Zhenyu Wang , Zhi Wang , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , Alex Deucher , Christian =?iso-8859-1?Q?K=F6nig?= , Sandy Huang , Heiko =?iso-8859-1?Q?St=FCbner?= , Andy Yan , Igor Russkikh , Andrew Lunn , Pavan Chebbi , Michael Chan , Potnuri Bharat Teja , Tony Nguyen , Przemek Kitszel , Taras Chornyi , Maxime Coquelin , Alexandre Torgue , Iyappan Subramanian , Keyur Chudgar , Quan Nguyen , Heiner Kallweit , Marc Zyngier , Thomas Gleixner , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Vinod Koul , Linus Walleij , Ulf Hansson , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , "Martin K. Petersen" , Eduardo Valentin , Keerthy , "Rafael J. Wysocki" , Daniel Lezcano , Zhang Rui , Lukasz Luba , Alex Williamson , Mark Greer , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Shuah Khan , Kieran Bingham , Mauro Carvalho Chehab , Joerg Roedel , Will Deacon , Robin Murphy , Lee Jones , Pavel Machek , Dave Penkler , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Justin Sanders , Jens Axboe , Georgi Djakov , Michael Turquette , Stephen Boyd , Philipp Zabel , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Pali =?iso-8859-1?Q?Roh=E1r?= , Dmitry Torokhov Subject: Re: [PATCH 00/61] treewide: Use IS_ERR_OR_NULL over manual NULL check - refactor Message-ID: <20260409181611.GP3836593@ZenIV> References: <20260310-b4-is_err_or_null-v1-0-bd63b656022d@avm.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260310-b4-is_err_or_null-v1-0-bd63b656022d@avm.de> X-Rspam-User: X-Stat-Signature: 1umhcepdegs7zw5zuwc8muknpotdy8ya X-Rspamd-Queue-Id: E5C8180005 X-Rspamd-Server: rspam09 X-HE-Tag: 1775758383-406023 X-HE-Meta: U2FsdGVkX1/K0WrdZTdcOTwsvCrzEfZPv9Y1mZSh0t4Ptrk4+PUgKcrSeh/Nv3BdRNwJMyZjRnaP4VGisLqEenlXkTZmogodUwtuL1Z82XILx0byF9K5TR+89jcgXiB7l4RXX2N+e9B0se5XHTlhQdQbEuS72YV4+Ygz9UD/BMkAhEe0rNLzlusZJMNUofnNCQv1fayYzs9Pv4R6ZXovHrNwBRxsqIJujr8lXO1jul422QZJ8tBBztTrrx7cTkshr5Xa12f6G7JPFQ2PvLC7XSidLBlz/x+r+EZMj996rz1ky8eZ22NgRKSFlMyXUN7sLmrSD23FM+ESwnrN1x2y7AtaaTH5XhZ6O1/ArFoIGlySZKl6w9gkW/1Y10c3DvzM54FGX9R9jF1VIsFdUYvt8cbDDVWKge00lohlAt3P1kIwrjDngVJKP6aCNX+QqCIXwSEcxpczdqA6mMlPdSWzLgcAeMI4EBuVFdK13/3iBJ9FuD7lRCTBUt9bvgqfMCg+jQWx4JrHryoCmp5TS/r1w5BGRtnP5Vh5eod2JCtXEWWtz4ZuIyKJFLRCxPn+PYt9xed9JDkMjmfYUK9H+k45wkAmkExxyqE+FIKhmYp617i7DDqRAACVwYJ3LQWsDFhmOHNBmnxK0YtCKPTd5wkb9gPhc6JVRXqL/J55LJY70XMfDh+/1Z4KMsfhE1VZTmzpgZ2zUeC5FaWCaVuKLDbbU59+RURguEQGqXpJIB1Yw2EullM/ZQclPWC9cO8biyW3IiL+Y+qTtJMkoHGrNuQWKYG5yCjAlJ1YpvSLMqNI0uRBQXRKcFqMKv7CdTv5S8MEtFFPntvafa2IobDsR89mMv5Q20Ofd5Xkf9Gc1ToMcSHLCJ+q7u/VevVzk0Ob4DzeoH8YGw1M+rVtEwwWY6Q6DCizEYJ+Aba2yceeluAlCytL3p9fp5OkSGnsSoxEy3DCdGqZK+mW7hvJIm8a/wE kCOZbc0B ZT2fbAiQU5UiK+D133BmY1/+7JA4ti4PYYhDg11G+TFNAgADuKPx8lW3/tonjF73gOx6MxILnEFl90h7V6uLji+aP2iGJiAVepz7LBGoGZQXmmgVOklIDgKPRQAX9QYvbC8UArR4UY3kGZCMTP0dPI8r3TK2oaFK3uF3eiVjfaLClUBvuRbqmD1L+Nh2zcCW90n2PkoM3AG5ew7TYS+z7WRkOE8lyRXi/l96kXgQOlDnW2EX+uNEjOaWr66TOoW5NUPH9FFLh+mziUfE= Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Mar 10, 2026 at 12:48:26PM +0100, Philipp Hahn wrote: > While doing some static code analysis I stumbled over a common pattern, > where IS_ERR() is combined with a NULL check. For that there is > IS_ERR_OR_NULL(). ... and valid uses of IS_ERR_OR_NULL are rare as hen teeth. Most of those are "I'm not sure how this function returns an error, let's use that just in case". Please, do not introduce more of that crap.